Bug 5104 – "Now Playing - (SqueezeBox IP)" is on the playlist.

Bug 5104 - "Now Playing - (SqueezeBox IP)" is on the playlist.

Summary:

"Now Playing - (SqueezeBox IP)" is on the playlist.

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Playlists
Version:	6.5.3
Platform:	PC Windows (legacy)

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	KDF

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2007-06-04 11:43 UTC by Wallace Lai
Modified:	2008-12-18 11:12 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
Log.txt for this bug. (51.43 KB, text/plain) 2007-06-04 11:44 UTC, Wallace Lai	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Wallace Lai 2007-06-04 11:43:51 UTC

System Info:  Gateway, P4, 2.0 GHz, 1.25 GB of RAM, Win 2K, SP4, ENU
SlimServer Version: 6.5.3 - 12202 - Windows 2000 - EN - cp1252 (2007-06-04 build)
Perl Version: 5.8.8 MSWin32-x86-multi-thread
MySQL Version: 5.0.22-community-nt

Steps to Reproduce:
1.  Start SlimServer, start the web interface.
2.  On the PlayList frame, click the "Clear" button.
3.  Refresh the web browser.
4.  On the "Browser" frame, go to "Album".
5.  Click "All Songs".
6.  The the play button for "All Songs".  All those songs are now on the PlayList frame.
7.  Notice "Now Playing - XXX.XXX.XXX.XXX" is on the PlayList also.  "XXX.XXX.XXX.XXX" is the SqueezeBox' IP.

Comment 1 Wallace Lai 2007-06-04 11:44:31 UTC

Created attachment 2035 [details]
Log.txt for this bug.

Comment 2 KDF 2007-06-04 12:36:25 UTC

we should probably look at just removeing EVERY case of "all songs" everywhere.  It's a stupid way to add music.  We have random mix now and that just works.  Too many special cases required to work around things we need in the db but don't want played as part of "all"

Comment 3 KDF 2007-06-04 13:14:59 UTC

Comparing: C:\slim\server\Slim\Control\Commands.pm.old
To: C:\slim\server\Slim\Control\Commands.pm
====
====
841	 <! 
	 !> 	
	 !> 		
	 !> 		# on search, only grab audio items.
	 !> 		$find{'audio'} = 1;


possibly even adding $find{'remote'} = 0 would be useful to avoid all remote files too.

this actually means that any playXtracks command will use local audio files only when the command has had to parse search terms.  Specific db items or lists will not be affected.

Comment 4 KDF 2007-06-20 23:16:58 UTC

see bug 5100, bug 4571

Comment 5 KDF 2007-06-20 23:21:41 UTC

assigning to myself as a note to fix this tomorrow night.  It will also fix the related bug "for now", for "for good" depending on what kind of rework might really be wanted to future features.  There are open requests for items that can be played without scanning, so radio links could also fall into that category, leaving lots of room to call them dupes in that respect.

Comment 6 KDF 2007-06-24 20:32:05 UTC

committed to trunk at change 12299, 6.5.3 at change 12300.

Please verify, also worth verifying bug 5100 and bug 4571 as these could be fixed as well for 6.5.3 with this change

reopen if there are any issues.