Bug 6783 - XMLBrowser type="text" items should not have a ">" char
: XMLBrowser type="text" items should not have a ">" char
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: Browser
: unspecified
: Macintosh Other
: P3 normal (vote)
: 7.0
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-25 14:08 UTC by Andy Grundman
Modified: 2009-09-08 09:13 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Grundman 2008-01-25 14:08:42 UTC
 
Comment 1 Blackketter Dean 2008-01-25 17:25:34 UTC
Andy: who should take this?
Comment 2 Blackketter Dean 2008-01-25 17:26:04 UTC
I'm guessing Ben.
Comment 3 Blackketter Dean 2008-01-26 17:41:29 UTC
Is this a dup of bug 6768?
Comment 4 Ben Klaas 2008-01-28 21:52:40 UTC
Andy, can you give me an example of somewhere this shows up?

I already have code to set the menu item style to 'itemNoAction' (no ">") in several spots in XMLBrowser. Don't know where it's missing.
Comment 5 Ben Klaas 2008-01-28 22:00:09 UTC
I think this may be what's needed, but I don't know where to test the fix

=== XMLBrowser.pm
==================================================================
--- XMLBrowser.pm       (revision 18539)
+++ XMLBrowser.pm       (local)
@@ -1810,6 +1811,10 @@
                                                        $request->addResultLoop( $loopname, $cnt, 'input', $input );
                                                }
 
+                                               if ( $item->{type} eq 'text' && !$hasImage ) {
+                                                       $request->addResultLoop( $loopname, $cnt, 'style', 'itemNoAction');
+                                               }
+
                                                if ( scalar keys %{$params} ) {
                                                        $request->addResultLoop( $loopname, $cnt, 'params', $params );
                                                }
Comment 6 Andy Grundman 2008-01-29 05:36:46 UTC
One example would be going right from a Rhapsody album.  The menu should contain a "Year" item which is just type="text".
Comment 7 Ben Klaas 2008-01-29 08:43:17 UTC
fixed in SC change 16895
Comment 8 James Richardson 2008-05-15 13:02:17 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html