Bug 6768 - Items with icons/artwork should have a > if they can be descended into.
: Items with icons/artwork should have a > if they can be descended into.
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: Browser
: unspecified
: Macintosh Other
: -- minor (vote)
: 7.0.1
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-24 22:46 UTC by Blackketter Dean
Modified: 2008-05-15 12:27 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Blackketter Dean 2008-01-24 22:46:29 UTC
Right now we don't show the > symbol (or any other symbol) on items with artwork/icons.  We should use the standard > and play/add icons whenever appropriate.

Ben: Is this doable for 7.0?
Comment 1 Ben Klaas 2008-01-25 14:49:30 UTC
Though the addition of this bug is what is blocking me from having single-digit bugs at the end of the week, I will concede to try to get this in for 7.0 :). 

Bottom of the list: P5.
Comment 2 KDF 2008-01-25 16:05:30 UTC
am I right in thinking this isn't trivial, since the skin basically supports only one icon per album item?
Comment 3 Ben Klaas 2008-01-25 20:06:20 UTC
KDF-- quite right. 1 icon per line item right now in the skin.

pushing to 7.0.1
Comment 4 Ben Klaas 2008-01-25 20:10:22 UTC
hmmm...not so sure now. the choose player screen puts a check and a right arrow icon on one line, so I think this might not be hard. Back to 7.0 you go....
Comment 5 KDF 2008-01-25 23:16:33 UTC
thing is, the check is for a checked item.   'check' can't just be arbitrarily added. I'm seeing funny things with album lists that don't add up so I'm getting lost.  Main album list behaves one way, album list with a play item at the top behaves another way (added intents on the selected item) so I can't follow back to the right style.
hoping to help, but I might just be getting in the way :)
Comment 6 KDF 2008-01-26 01:12:46 UTC
one option is below.  alternate would be to not use 'play', but some other identifier and create the group with an added ocmponent in SlimBrowser.


Index: jive/share/applets/DefaultSkin/DefaultSkinApplet.lua
===================================================================
--- jive/share/applets/DefaultSkin/DefaultSkinApplet.lua	(revision 1631)
+++ jive/share/applets/DefaultSkin/DefaultSkinApplet.lua	(working copy)
@@ -974,9 +974,11 @@
 	s.selected.albumitem.text.fg = SELECT_COLOR
 	s.selected.albumitem.text.sh = SELECT_SH_COLOR
 	s.selected.albumitem.bgImg = albumSelectionBox
+	s.selected.albumitem.order = {"icon","text","play","check"}
+	s.selected.albumitem.play={}
+	s.selected.albumitem.play.img=Surface:loadImage(imgpath .. "selection_right.png")
+	s.selected.albumitem.play.align="right"
 
-
-
 	-- locked item with artwork and song info
 	s.locked.albumitem = {}
 	s.locked.albumitem.text = {}
Comment 7 Blackketter Dean 2008-01-26 17:40:58 UTC
I'm sorry, my initial description was misleading.  I do NOT want multiple icons per item (except check marks). 

What I do want is consistent display of the >, play and add symbols, and only one of these at a time.

For example, in the song info on a pandora song, Artist, Album, Song, Duration, Volume Adjustment, File Format and Bitrate should not have > symbols, as you can't descend on them.


Comment 8 KDF 2008-01-26 17:49:52 UTC
so did you want > on album listings or not?  If so, that's two 'icons'.

can't help with pandora, I'm afraid.  I expect it would be tricky as it is probably using the standard song info, except in this case the usual items that can be dropped into, can't.
Comment 9 Ben Klaas 2008-01-26 18:00:17 UTC
yes, what KDF said.

an artwork icon and a > icon is two icons.

I think what KDF proposed in an earlier comment might work just fine, but haven't had the opportunity to test yet.
Comment 10 KDF 2008-01-26 18:17:38 UTC
it doesn't cover the song info stuff, and it would be BEST to not use 'play' which would guess is for some other unused purpose.  I tried adding descend=>Icon("desend"), and editing the style. This works, but the > is up in the top right instead of centred.  I don't know why, but it's not critical if "play" isn't being used right now.
Comment 11 Blackketter Dean 2008-01-26 18:52:11 UTC
Ok, thanks.  So, the preference would be:

Items with album art would indeed have a > item, centered vertically and on the right.    This sounds harder and we should punt this to 7.0.1.  (We need the ability to have more than one graphic per menu item.)

Items in song info that you can't descend into (like pandora or bug 6783) we should fix for 7.0.
Comment 12 Ben Klaas 2008-01-26 20:19:13 UTC
for the record, this bug is ONLY against the > icon not showing up in the albumitem style. The songinfo page has nothing to do with this one. Also, the > icon behavior works correctly in local songinfo pages, only problems with XML browser-driven pages.

Comment 13 Blackketter Dean 2008-01-26 20:44:42 UTC
Great.  Let's punt on this to 7.0.1.  And 6783 should cover the other case.
Comment 14 Ben Klaas 2008-03-19 08:30:52 UTC
removing priorities from all 7.0.1 target bugs for re-prioritizing
Comment 15 Ben Klaas 2008-04-01 11:35:25 UTC
fixed in trunk r2164
Comment 16 James Richardson 2008-05-06 14:42:34 UTC
verified fixed in 7.0.1 - 19422 controller r2409

If any other instances are found, please reopen this bug
Comment 17 James Richardson 2008-05-15 12:27:24 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html