Bug 6667 - Choose player menu option missing since r1495
: Choose player menu option missing since r1495
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: UI
: unspecified
: PC Windows XP
: P1 major (vote)
: 7.0
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-19 11:33 UTC by Mick
Modified: 2009-09-08 09:20 UTC (History)
6 users (show)

See Also:
Category: ---


Attachments
Patch (2.17 KB, patch)
2008-02-12 13:25 UTC, Richard Titmuss
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mick 2008-01-19 11:33:26 UTC
I can longer change between players, the option exists when the remote powers up with no SC running, but once I bring SC online, Jive connects and chnages to contolling the last associated player.

The main menu does not contain an option to change between players.

The latest rev has not changed this behaviour.
Comment 1 KDF 2008-01-19 12:48:58 UTC
"choose player" shows up as the second last item for me.
Comment 2 Patrick Dixon 2008-01-20 07:02:50 UTC
*** Bug 6676 has been marked as a duplicate of this bug. ***
Comment 3 Patrick Dixon 2008-01-20 07:04:54 UTC
Please see 6676 for my comments - the home key takes you to now playing, and there doesn't seem to be anyway to get to the home menu and the choose player option.
Comment 4 Blackketter Dean 2008-01-20 14:05:54 UTC
Mick: is this still happening for you with the latest firmware?

Ben: Is this familiar to you?
Comment 5 Mick 2008-01-20 14:16:46 UTC
As I mentioned in the forum, I left the Jive in it's cradle. Went out for about 6 hours. Came back, and the menu item had returned.

Now that i think about it, I may have done a New & Changed re-scan as I fixed some tags in my library.

Wonder did the template cache get wiped.
Comment 6 Patrick Dixon 2008-01-21 01:02:25 UTC
As I mentioned on the thread, having updated jive fw, I now see this option in the player menu 2nd from bottom.

However, I'm now slightly confused about the Jive 'Home' key - which doesn't take you to the Jive menu labelled 'Home' any more!  If the player menu is going to be the new 'Home', maybe the old 'Home' menu needs renaming (to Setup?).  If the 'Choose Player' option is going to stay in the player menu, could I suggest that you call it 'Switch (or Change) Player' as it seems more appropriate here?

Comment 7 Richard Titmuss 2008-01-24 13:07:18 UTC
Does anyone still have this issue, or can we close this bug?
Comment 8 Patrick Dixon 2008-01-24 15:08:26 UTC
From the associated thread, http://forums.slimdevices.com/showthread.php?t=42489&page=2:-


Quote:
Originally Posted by bklaas
It could be that when the home menu was first put together it only discovered 1, thereby leaving the item off, then more came online and the item didn't get added. Just a guess...

Seems like a good guess, as that's what happens here ...

So unless that's been fixed, it's still a bug.

I reproduced it by starting with one player, choosing it on Jive, and then adding another.  When the second SB/TP was added, the choose player option didn't come up on Jive without a restart.

Bug 6697 may be related.
Comment 9 Clive Backham 2008-01-25 02:42:00 UTC
What I've observed may be relevant.

I have two players, and when I first boot up the Jive handset, it connects to the player it was previously connected to and displays that player's home menu. But the "Choose Player" option is missing.

If you then hold down the Back button for a couple of seconds, it goes to some sort of "basic home menu", which has the three options "Settings", "Extras", and "Choose Player". You can then choose a player, and from that point on, each player's home menu does include the Choose Player option.

The problem with this behaviour is that the only way to get to choose a player is if you know to hold down the Back key for a while, which a lot of casual users probably won't ever figure out.

I've seen this happening in the last few firmwares (including r1605, which is the one I currently run).

Comment 10 Blackketter Dean 2008-01-26 17:31:50 UTC
Ben: any idea why this could be happening?  I haven't seen this.
Comment 11 Clive Backham 2008-01-27 04:35:32 UTC
Installed r1628 today, and the Choose Player menu item is now shown on the home page after boot-up. So it looks like this is fixed.
Comment 12 Patrick Dixon 2008-01-27 04:52:02 UTC
Well yes, but it comes and goes depending on how many players you have connected and the order in which they are connected and jive is started up - so unless you've checked all those, I'd be cautious about saying it's fixed.

The other day I had the Choose Player option on the Transporter screen, even though it was the only player connected.  This isn't exactly a disaster, but I'm guessing that it's not intended behaviour.
Comment 13 Ben Klaas 2008-01-28 06:55:26 UTC
Today I'm going to investigate my theory that Jive initially sees one player, does not display the Choose Player menu item as a result, then when SlimDiscovery finds more players doesn't add the menu item.

I have yet to see this issue reproduced myself, so that will be the first part of my test--to see if I can reliably reproduce it. If I can do that, I can put in some debug code to examine why the menu item isn't added as > 1 players are detected.
Comment 14 Ben Klaas 2008-01-28 08:01:55 UTC
after discussing this at length with Richard, the underlying problem is likely bug #6683.

a workaround/test for that: when you see this condition (Choose Player not there after adding a second player), try going to Settings->Music Source. When you do this you force a scan of players available. Then go back to home and see if Choose Player is there now.

Pat/Mick/Clive, can you try that and report results back?
Comment 15 Patrick Dixon 2008-01-28 10:19:36 UTC
I have the situation where I have removed all players except a Transporter, but I am still getting 'Choose Player' on the home menu.

Going to Settings->Music Source made no difference.  Then the remote (blue wireless) and transporter both locked up, and rebooting both removed the Choose Player option???

The Log says:-

[08-01-28 18:01:11.0870] Slim::Schema::Track::coverArt (299) Error: Exception when trying to call readCoverArt() for [file:///Music/Vol2/Music6/Various/Mojo%20-%20Chili%20Peppers%20Jukebox/01_Natural%27s%20Not%20In%20It%20by%20Gang%20Of%20Four.flac] : [[/Music/Vol2/Music6/Various/Mojo - Chili Peppers Jukebox/01_Natural's Not In It by Gang Of Four.flac] does not exist or cannot be read: No such file or directory at /usr/share/squeezecenter/lib/Audio/FLAC/Header.pm line 67.
]
[08-01-28 18:01:11.2317] Slim::Networking::Slimproto::client_readable (364) Client sent bad data: S /  / 0 data: ""
Comment 16 Ben Klaas 2008-01-28 14:50:52 UTC
"I have the situation where I have removed all players except a Transporter, but
I am still getting 'Choose Player' on the home menu."

that's bug 6683

but the rest, yuck. Your Transporter locked up? :( 
This seems pretty far beyond what's going on with Jive.
Comment 17 Blackketter Dean 2008-01-28 21:26:29 UTC
Ok, so is the "Choose Player" issue resolved now?  
Comment 18 Patrick Dixon 2008-01-29 00:49:31 UTC
"that's bug 6683" - Ahh. OK - I thought it must be related.

"but the rest, yuck. Your Transporter locked up? :( 
This seems pretty far beyond what's going on with Jive."

It seems to occur when I'm browsing on Jive though, and I've had it a couple of times now.  I'll open it as a separate bug.
Comment 19 Patrick Dixon 2008-01-29 02:38:07 UTC
No I still see it.  Just added an SB3 to the single TP and don't get a Choose Player option.
Comment 20 Ben Klaas 2008-01-29 08:39:15 UTC
Patrick, how many SqueezeCenters are you running? Just one? How about SqueezeNetwork? Are you connecting to that with either player?
Comment 21 Patrick Dixon 2008-01-29 09:17:55 UTC
Just one SC7 - on Ubuntu.  And I'm not using SqueezeNetwork at all.

The devices do sometimes get taken out and connected to other people's networks, but not recently.
Comment 22 Blackketter Dean 2008-02-01 17:38:05 UTC
Ping Ben, any thoughts on this?
Comment 23 Ben Klaas 2008-02-04 15:57:29 UTC
I've had no luck reproducing this (I should note, I can reproduce bug 6683, which is at least in some measure associated with this one).

Hate to do it, but I need to punt this to QA for reproducing...
Comment 24 Blackketter Dean 2008-02-04 16:40:35 UTC
Patrick & Mick: Is this still happening with the latest nightly release?  We've been unable to reproduce here.
Comment 25 Blackketter Dean 2008-02-04 16:42:28 UTC
Steven: Can I ask you to look at this on our side?
Comment 26 Patrick Dixon 2008-02-05 07:44:42 UTC
I can't reproduce this at the moment because the home menu always displays the choose player option even though I've only had one player connected for the past couple of days!

If I could get rid of that, I'm sure I could reproduce it very easily.
Comment 27 Blackketter Dean 2008-02-05 09:23:52 UTC
Please reopen if you see this again.
Comment 28 Patrick Dixon 2008-02-05 09:51:51 UTC
Hmm, so is having 'choose player' in the menu even with only one player a different bug, not a bug, or youjustcan'tbebotheredanymore'costhecodeneedstobereleased? ;-)
Comment 29 Patrick Dixon 2008-02-07 03:13:07 UTC
This is easy to replicate

Switch off Jive
Switch off all players but one.
'Forget' all players but the one connected
Switch on Jive
Choose the Player connected on Jive
Switch on another player and wait for it to be connected to SC7
Choose Player option not available in Jive home menu, so cannot be selected.

Please re-open this bug.
Comment 30 Blackketter Dean 2008-02-07 07:03:21 UTC
Thanks for the details, Patrick.  We'll look at this.

Comment 31 Blackketter Dean 2008-02-07 22:40:19 UTC
Ping: steven...  Any news here?
Comment 32 Ross Levine 2008-02-08 15:22:12 UTC
I just tried this an I'm not able to reproduce. It could be because there is no more forget this player, Patrick could you try reproducing with a more recent nightly build? Its possible I'm not seeing this bug because I'm not able to forget the player I disconnect. 
Comment 33 Spies Steven 2008-02-08 15:28:31 UTC
Ross, we discussed the forget player option in the bug meeting the other day and determined it should not matter.  Having said that I have not been able to reproduce so far myself.
Comment 34 Ross Levine 2008-02-08 15:52:16 UTC
(In reply to comment #32)
> I just tried this an I'm not able to reproduce. It could be because there is no
> more forget this player, Patrick could you try reproducing with a more recent
> nightly build? Its possible I'm not seeing this bug because I'm not able to
> forget the player I disconnect. 
> 

Never mind this ^. I just reproduced it. I waited another 5 minutes and my player was finally forgotten, then switched Jive on powered on my other player and once it connected the choose player menu was no longer on Jive. 

I'll take a closer look at the player forgetting and file another bug if I can reproduce the long delay before the player is forgotten. 
Comment 35 Ben Klaas 2008-02-08 15:54:45 UTC
I'm also going to give another shot at reproducing this over the weekend.
Comment 36 Ben Klaas 2008-02-12 08:51:05 UTC
this debug output is the smoking gun. I'm connected to 1 player, "Office SB3". When I add a second player, "Officesbr", I get a playerNew notification, but SlimDiscovery still thinks I have only 1 player. 

104717:1124492 INFO (Player.lua:257) - Player {Officesbr} new for SlimServer {DaddyMac.slimdevices.com}
104717:1124492 INFO (NetworkThread.lua:245) - NOTIFY playerNew: Player {Officesbr}
104717:1124492 WARN (SelectPlayerApplet.lua:131) - SlimDiscovery says that I now have this many players: 1
104717:1124492 WARN (SelectPlayerApplet.lua:132) - This is my currently selected player: Player {Office SB3}

Even after restarting Jive SlimDiscovery returns numberOfPlayers as 1

Comment 37 Ben Klaas 2008-02-12 09:06:21 UTC
this is the console sequence on boot... server "DaddyMac" is found, and two playerNew notifications are seen, but SlimDiscovery reports the number of players as 1

110153:537 INFO (SlimServers.lua:82) - Creating server DaddyMac.slimdevices.com (172.19.164.76:9000)
110153:538 INFO (SlimServer.lua:351) - SlimServer {DaddyMac.slimdevices.com}:connect()
110153:538 INFO (NetworkThread.lua:245) - NOTIFY serverNew: SlimServer {DaddyMac.slimdevices.com}
110153:585 INFO (Player.lua:257) - Player {Officesbr} new for SlimServer {DaddyMac.slimdevices.com}
110153:585 INFO (NetworkThread.lua:245) - NOTIFY playerNew: Player {Officesbr}
function: 0x160c12d0
110153:585 WARN (SelectPlayerApplet.lua:131) - SlimDiscovery says that I now have this many players: 0
110153:585 WARN (SelectPlayerApplet.lua:132) - This is my currently selected player: nil
110153:585 INFO (Player.lua:257) - Player {Office SB3} new for SlimServer {DaddyMac.slimdevices.com}
110153:585 INFO (NetworkThread.lua:245) - NOTIFY playerNew: Player {Office SB3}
function: 0x160c12d0
110153:585 WARN (SlimDiscoveryApplet.lua:130) - 1
110153:585 WARN (SelectPlayerApplet.lua:131) - SlimDiscovery says that I now have this many players: 1
Comment 38 Ben Klaas 2008-02-12 09:20:11 UTC
more interesting output...I just fired up my other SC, and the grand total of connected players should now be 6. SlimDiscovery has the number at 5. So perhaps I just need to find out why our count is always one short.
 
111755:2101 INFO (NetworkThread.lua:245) - NOTIFY playerNew: Player {Squeezebox 2}
function: 0x160c13d0
111755:2101 WARN (SlimDiscoveryApplet.lua:130) - 1
111755:2101 WARN (SlimDiscoveryApplet.lua:130) - 2
111755:2101 WARN (SelectPlayerApplet.lua:131) - SlimDiscovery says that I now have this many players: 2
111755:2101 WARN (SelectPlayerApplet.lua:132) - This is my currently selected player: Player {Office SB3}
111755:2101 INFO (Player.lua:257) - Player {Living Room} new for SlimServer {mediumspicy}
111755:2101 INFO (NetworkThread.lua:245) - NOTIFY playerNew: Player {Living Room}
function: 0x160c13d0
111755:2102 WARN (SlimDiscoveryApplet.lua:130) - 1
111755:2102 WARN (SlimDiscoveryApplet.lua:130) - 2
111755:2102 WARN (SlimDiscoveryApplet.lua:130) - 3
111755:2102 WARN (SelectPlayerApplet.lua:131) - SlimDiscovery says that I now have this many players: 3
111755:2102 WARN (SelectPlayerApplet.lua:132) - This is my currently selected player: Player {Office SB3}
111755:2102 INFO (Player.lua:257) - Player {Bedroom} new for SlimServer {mediumspicy}
111755:2102 INFO (NetworkThread.lua:245) - NOTIFY playerNew: Player {Bedroom}
function: 0x160c13d0
111755:2102 WARN (SlimDiscoveryApplet.lua:130) - 1
111755:2102 WARN (SlimDiscoveryApplet.lua:130) - 2
111755:2102 WARN (SlimDiscoveryApplet.lua:130) - 3
111755:2102 WARN (SlimDiscoveryApplet.lua:130) - 4
111755:2102 WARN (SelectPlayerApplet.lua:131) - SlimDiscovery says that I now have this many players: 4
111755:2102 WARN (SelectPlayerApplet.lua:132) - This is my currently selected player: Player {Office SB3}
111755:2103 INFO (Player.lua:257) - Player {Squeezebox} new for SlimServer {mediumspicy}
111755:2103 INFO (NetworkThread.lua:245) - NOTIFY playerNew: Player {Squeezebox}
function: 0x160c13d0
111755:2103 WARN (SlimDiscoveryApplet.lua:130) - 1
111755:2103 WARN (SlimDiscoveryApplet.lua:130) - 2
111755:2103 WARN (SlimDiscoveryApplet.lua:130) - 3
111755:2103 WARN (SlimDiscoveryApplet.lua:130) - 4
111755:2103 WARN (SlimDiscoveryApplet.lua:130) - 5
111755:2103 WARN (SelectPlayerApplet.lua:131) - SlimDiscovery says that I now have this many players: 5
Comment 39 Richard Titmuss 2008-02-12 13:25:07 UTC
Created attachment 2847 [details]
Patch
Comment 40 Richard Titmuss 2008-02-12 13:25:40 UTC
Ben, please try the attached patch. It also fixes some stray playerPower notifications too.
Comment 41 Ben Klaas 2008-02-12 13:51:51 UTC
fixed in r19381

this was a reproducible problem, and Richard's patch effectively fixes the issue.
Comment 42 Ben Klaas 2008-02-12 14:13:59 UTC
sorry, that should have read:

fixed in Jive r1919
Comment 43 James Richardson 2008-05-15 13:01:42 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html