Bugzilla – Bug 6643
Searching for "Various Artists" Hangs SC
Last modified: 2009-07-31 10:16:13 UTC
Running build 16330 under Win XP. To reproduce issue: 1) Search for Various Artists. 2) Click on the link "Various Artists" that SC finds SC now hangs, browser keeps waiting for page to be updated. However, clicking on any other link brings back normal functionality. Log extract: [08-01-17 20:54:00.0282] Slim::Networking::Select::select (245) Error: Select task failed: Carp::Clan::__ANON__(): Error executing 'SELECT COUNT( DISTINCT( album.id ) ) FROM contributors me LEFT JOIN contributor_album contributorAlbums ON ( contributorAlbums.contributor = me.id ) JOIN albums album ON ( album.id = contributorAlbums.album ) WHERE ( ( ( album.compilation = ? ) AND ( me.role = ? ) ) )': DBD::mysql::st execute failed: Unknown column 'me.role' in 'where clause' at C:\Program Files\Media\SqueezeCenter\server\CPAN/DBIx/Class/Storage/DBI.pm line 771. [08-01-17 20:58:32.2173] Slim::Schema::Storage::throw_exception (67) Error: Error executing 'SELECT COUNT( DISTINCT( album.id ) ) FROM contributors me LEFT JOIN contributor_album contributorAlbums ON ( contributorAlbums.contributor = me.id ) JOIN albums album ON ( album.id = contributorAlbums.album ) WHERE ( ( ( album.compilation = ? ) AND ( me.role = ? ) ) )': DBD::mysql::st execute failed: Unknown column 'me.role' in 'where clause' at C:\Program Files\Media\SqueezeCenter\server\CPAN/DBIx/Class/Storage/DBI.pm line 771. [08-01-17 20:58:32.2181] Slim::Schema::Storage::throw_exception (67) Backtrace: frame 0: Slim::Utils::Log::logBacktrace (C:/Program Files/Media/SqueezeCenter/server/Slim/Schema/Storage.pm line 67) frame 1: Slim::Schema::Storage::throw_exception (C:\Program Files\Media\SqueezeCenter\server\CPAN/DBIx/Class/Storage/DBI.pm line 773) frame 2: DBIx::Class::Storage::DBI::_execute (C:\Program Files\Media\SqueezeCenter\server\CPAN/DBIx/Class/Storage/DBI.pm line 826) frame 3: DBIx::Class::Storage::DBI::_select (C:\Program Files\Media\SqueezeCenter\server\CPAN/DBIx/Class/Storage/DBI/Cursor.pm line 79) frame 4: DBIx::Class::Storage::DBI::Cursor::next (C:\Program Files\Media\SqueezeCenter\server\CPAN/DBIx/Class/ResultSet.pm line 888) frame 5: DBIx::Class::ResultSet::_count (C:\Program Files\Media\SqueezeCenter\server\CPAN/DBIx/Class/ResultSet.pm line 849) frame 6: DBIx::Class::ResultSet::count (/<C:\Program Files\Media\SqueezeCenter\server\squeezecenter.exe >Slim/Web/Pages/BrowseDB.pm line 265) frame 7: Slim::Web::Pages::BrowseDB::browsedb (/<C:\Program Files\Media\SqueezeCenter\server\squeezecenter.exe >Slim/Web/HTTP.pm line 1071) frame 8: Slim::Web::HTTP::generateHTTPResponse (/<C:\Program Files\Media\SqueezeCenter\server\squeezecenter.exe >Slim/Web/HTTP.pm line 938) frame 9: Slim::Web::HTTP::processURL (/<C:\Program Files\Media\SqueezeCenter\server\squeezecenter.exe >Slim/Web/HTTP.pm line 750) frame 10: Slim::Web::HTTP::processHTTP (/<C:\Program Files\Media\SqueezeCenter\server\squeezecenter.exe >Slim/Networking/Select.pm line 243) frame 11: (eval) (/<C:\Program Files\Media\SqueezeCenter\server\squeezecenter.exe >Slim/Networking/Select.pm line 243) frame 12: Slim::Networking::Select::select (slimserver.pl line 503) frame 13: main::idle (slimserver.pl line 43) frame 14: PerlSvc::Startup (perlsvc line 851) frame 15: PerlSvc::_startup (slimserver.pl line 0) frame 16: (eval) (slimserver.pl line 0) [08-01-17 20:58:32.2189] Slim::Networking::Select::select (245) Error: Select task failed: Carp::Clan::__ANON__(): Error executing 'SELECT COUNT( DISTINCT( album.id ) ) FROM contributors me LEFT JOIN contributor_album contributorAlbums ON ( contributorAlbums.contributor = me.id ) JOIN albums album ON ( album.id = contributorAlbums.album ) WHERE ( ( ( album.compilation = ? ) AND ( me.role = ? ) ) )': DBD::mysql::st execute failed: Unknown column 'me.role' in 'where clause' at C:\Program Files\Media\SqueezeCenter\server\CPAN/DBIx/Class/Storage/DBI.pm line 771.
Will take a look at this post-7.0.
Might this be the same thing as bug 6548? https://bugs-archive.lyrion.org/show_bug.cgi?id=6548
Simon, it doesn't look like these are related aside from their connection to "various artists". I didn't see any indication of "Unknown column 'me.role'" in any logs in the other bug. this one is clearly a problem in Slim::Schema->rs()->generateConditionsFromFilters
it is also related to this block of code. The removal of contributor.id seems to mess up the levels so contributor.role ends up assumed as part of the album table as me.role if ($params->{'contributor.id'}) { if ($params->{'contributor.id'} == Slim::Schema->variousArtistsObject->id) { delete $params->{'contributor.id'}; $attrs{'album.compilation'} = 1; } }
Created attachment 3058 [details] one option move the confitionsFromFilters block to a point prior to messing with the various artist id.
I can't even reproduce this issue. Do you actually have an artist entry "Various Artists" or only the generic one, created by SC?
Simon/feroxity - is this issue still reproduceable for you? I still can't reproduce it.
I'm running SqueezeCenter Version: 7.0.1 - 18163 - Windows XP - EN - cp1252. If you search for Various Artists, it appears as an artist, but clicking on the link keeps Firefox busy without anything happening, i.e. the list of albums does not load. However, SC doesn't crash and clicking on something else works fine. Clicking on Play *does* queue all the tracks in the player though and starts playing them.
> If you search for Various Artists, it appears as an artist, but clicking on the But do you actually have tags with the value "Various Artsists"?
(In reply to comment #9) > > If you search for Various Artists, it appears as an artist, but clicking on the > > But do you actually have tags with the value "Various Artsists"? > Well, I have albums which have TPE2(?) and ALBUMARTIST tagged as Various Artist and the actual artist on the main Artist tag. I would expect those to appear when I search for "Various Artists", no? Or at least not to keep the browser waiting.
> Well, I have albums which have TPE2(?) and ALBUMARTIST tagged as Various Artist > and the actual artist on the main Artist tag. I would expect those to appear > when I search for "Various Artists", no? Sure! I just wanted to be sure I'm not on the wrong track trying to reproduce this. And I was: I don't have any such file... Thanks for the specification.
Hehe... now I see why I wasn't able to reproduce: the artist title has to match the VA string as defined in the settings. As I'm usually running SC in German, this wasn't "Various Artists", thus the issue didn't arise. Now I'm seeing it myself.
change 18484 - don't remove contributor ID if at the same time we're filtering for a contributor.role; this case can happen if some track has a contributor tag set to the VA string
Wigster, ET. AL. Can you verify that 7.0.1 - 19325 fixes the issues you are seeing. If not, please reopen the bug with added details.
Everything seems to work well. Thanks!
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1 Please try that version, if you still see the error, then reopen this bug. To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html
Reduce number of active targets for SC