Bug 6595 - Now Playing screensaver occasionally flickers the lower 1/5th of screen
: Now Playing screensaver occasionally flickers the lower 1/5th of screen
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: Screensavers
: unspecified
: Other Other
: P1 normal (vote)
: 7.0.1
Assigned To: Richard Titmuss
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-13 08:21 UTC by Doug Williams
Modified: 2009-09-08 09:28 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
captured on film, though during a push transition (826.04 KB, video/quicktime)
2008-02-15 07:34 UTC, Blackketter Dean
Details
Kernel patch that blocks until vertical sync in framebuffer (3.17 KB, patch)
2008-03-12 13:01 UTC, Richard Titmuss
Details | Diff
Patch that resets the timer used to control when the screen is redrawn (601 bytes, patch)
2008-03-12 13:03 UTC, Richard Titmuss
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Doug Williams 2008-01-13 08:21:43 UTC
This is an intermittent problem.  Not sure how/why it comes and goes but the Now Playing screensaver will flicker the bottom 1/5th of the screen every few seconds every now and then.  When it starts it seems that most of the time it does it for the entire screensaver "session".

I generally leave the controller sitting at the main menu sitting on the Music Library option (but not selected).

I may have just noticed a pattern:  When it occurs something is scrolling.  Either the artist or title at the top of the screen.
Comment 1 Blackketter Dean 2008-01-18 09:27:09 UTC
Not a showstopper for 7.0
Comment 2 Doug Williams 2008-02-09 14:18:05 UTC
It occurred starting to play Faith Hill's "One Cry".
I had to virtually "power down" the main player and then turn it back on (from the web UI) before it would start playing the track again.  Once it was turned back on the track played with no further issues.  The bedroom unit was not changed/controlled in any way during this time.  The main unit is connected with a wired network cable, the bedroom unit is connected wirelessly.

Attaching log file excerpt.
Comment 3 Doug Williams 2008-02-09 14:19:52 UTC
Ignore the previous comment - dang bug tracking system jumped issues on me again...  sorry.
Comment 4 Richard Titmuss 2008-02-15 07:28:16 UTC
*** Bug 7159 has been marked as a duplicate of this bug. ***
Comment 5 Blackketter Dean 2008-02-15 07:34:36 UTC
Created attachment 2892 [details]
captured on film, though during a push transition
Comment 6 Richard Titmuss 2008-03-07 14:36:52 UTC
*** Bug 6562 has been marked as a duplicate of this bug. ***
Comment 7 Richard Titmuss 2008-03-12 04:53:31 UTC
Reset priority
Comment 8 Richard Titmuss 2008-03-12 13:01:45 UTC
Created attachment 3073 [details]
Kernel patch that blocks until vertical sync in framebuffer

This vsync patch is probably the wrong solution, as the application will block while waiting for the vertical sync. But I now have the code, so I'll add it here in case it's useful in the future.
Comment 9 Richard Titmuss 2008-03-12 13:03:22 UTC
Created attachment 3074 [details]
Patch that resets the timer used to control when the screen is redrawn

When screen drawing takes too long it can cause flicker due to the double buffering. This patch resets the time to make sure the flicker does not happen.
Comment 10 Richard Titmuss 2008-03-12 13:05:20 UTC
Triode, I'd like a second opinion on bug6595.patch (the lua patch attached). Does this seem ok to you? Thanks.
Comment 11 Adrian Smith 2008-03-12 13:23:25 UTC
Hum - not sure - isn't the display part of the event loop now:

		now = self:getTicks()
		if now >= framedue then
			logTask:info("--------")

			-- draw screen
			self:updateScreen()

			-- keep on top of the garbage
			collectgarbage("step")

			-- process ui event once per frame
			running = eventTask:resume()

			-- when is the next frame due?
			now = self:getTicks()
			if now > framedue then
				framedue = now
			end

			framedue = framedue + framerate
		end
	end

The second if now > framedue will always be true and hence you slow down the framerate?
Comment 12 Richard Titmuss 2008-03-12 14:26:45 UTC
Fixed in jive 7.0.1 r2106 (a different fix from the patches above). The screen flicker is not always possible to easily recreate, so if you still see it please reopen this bug.
Comment 13 James Richardson 2008-05-06 13:50:38 UTC
(In reply to comment #12)
> Fixed in jive 7.0.1 r2106 (a different fix from the patches above). The screen
> flicker is not always possible to easily recreate, so if you still see it
> please reopen this bug.
> 

Marking as verified in 7.0.1 - 19422.  Please reopen if you still see the error
Comment 14 James Richardson 2008-05-15 12:26:59 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html