Bugzilla – Bug 6507
ALBUMARTIST tag causes ARTISTSORT tags to be lost
Last modified: 2008-12-18 11:12:53 UTC
I first reported this in comment #5 of bug 6490 but decided it should be a separate bug. In the code added to fix bugs 2317 & 2638, the ARTIST role is transformed to TRACKARTIST when there is an ALBUMARTIST. When this is done, any ARTISTSORT tag that goes along with the ARTIST tag is lost. Adding a line to also transform the ARTISTSORT tag to TRACKARTISTSORT fixes that. I will attach a patch.
Created attachment 2595 [details] fix this fixes the problem.
This seems reasonable - I'll add unless Andy disagrees..
Can anyone explain exactly what a "TRACKARTIST" is and whether the role is necessary for some particular functionality? It certainly doesn't correspond to any known tag. Why not just leave the role as ARTIST when a ALBUMARTIST is present? I notice that on compilations, artists are never assigned this TRACKARTIST role, so wonder if it's just some leftover from an unfinished idea someone had about how contributor roles would be used. I've been writing SQL queries to pull data from the SC database in another application, and this is just one of the many oddities that greatly complicates working with the data. If you want the artist(s) for a track, you have to get those with a role of either artist or trackartist. And I can think of no reason you'd ever want to know just the trackartists. The role has no significance.
Jim, I very much agree, the TRACKARTIST role looks fishy to me. I have not dug deeply, but here are the relevant commits and bug references, mostly by Dan. Maybe someone who knows his current email can CC him on this bug so we can get his input? ------------------------------------------------------------------------ r8140 | dsully | 2006-06-26 18:47:46 -0400 (Mon, 26 Jun 2006) | 7 lines Bug: 2317 & 2638 Description: Bring brack TRACKARTIST for internal use: * If the user hasn't explictly marked an album as a compilation, and there is an ALBUMARTIST tag, set the ARTIST to be TRACKARTIST instead. * Turn on a progress bar for track cleanup. ------------------------------------------------------------------------ r8784 | dsully | 2006-08-03 20:44:29 -0400 (Thu, 03 Aug 2006) | 25 lines Bug: 3824 & 3835 Description: Various Artists rework: [...trimmed some lines here...] * Fixes for when we generate a 'TRACKARTIST' role - allow it to be searched, displayed and linked to in the UI, but don't show those artists in the Artist list. ------------------------------------------------------------------------ r10163 | dsully | 2006-10-03 19:04:25 -0400 (Tue, 03 Oct 2006) | 2 lines Bug: 4024 Description: Include TRACKARTIST when displaying 'ARTIST' on the player. ------------------------------------------------------------------------ r15387 | andy | 2007-12-17 15:06:27 -0500 (Mon, 17 Dec 2007) | 1 line Bug 4629, fix search results when searching for a track artist ------------------------------------------------------------------------
Hmmm I think the key insight might be that a TRACKARTIST is an artist that should not appear in the "Browse Artists" list (unless it also appears in some "first class" role elsewhere).
Committed r15749.
thank you Triode!
This bug is being closed since it was resolved for a version which is now released! Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html If you are still seeing this bug, please re-open it and we will consider it for a future release.