Bug 4629 - For albums with ALBUMARTIST, track artists don't have any albums listed when searching for track artists from the player UI
: For albums with ALBUMARTIST, track artists don't have any albums listed when ...
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 7.0
: PC Windows XP
: P2 minor with 3 votes (vote)
: 7.x
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-12-31 03:20 UTC by Nigel Birch
Modified: 2009-07-31 10:14 UTC (History)
6 users (show)

See Also:
Category: ---


Attachments
Files to reproduce behavior (4.00 KB, application/octet-stream)
2007-01-05 15:50 UTC, Spies Steven
Details
FLAC and mp3 files to reproduce behavior (5.56 KB, application/octet-stream)
2007-01-08 16:46 UTC, Spies Steven
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nigel Birch 2006-12-31 03:20:43 UTC
This is with SlimServer v6.5.1 - 11024 - Windows XP - EN - cp1252, Perl v5.8.8 MSWin32-x86-multi-thread & MySQL v5.0.22-community-nt.

With an album like this:

SongA by TrackArtistA; AlbumArtistD
SongB by TrackArtistB; AlbumArtistD
SongC by TrackArtistC; AlbumArtistD

from the player UI, when browsing artists only AlbumArtistD is listed (track artists are listed only if they have another non-ALBUMARTIST or non-compilation album) (OK).  When searching for artists, both AlbumArtistD and track artists are found (OK).  However, track artists don't have any albums listed - the player UI says "Empty" when navigating right to list albums (not OK).

Adding COMPILATION=1 to each track and wipe/re-scan fixes the problem.  I'm not sure of the intended behaviour difference between ALBUMARTIST and compilation albums, but listing no albums (i.e. "Empty") doesn't look like the correct behaviour.

"Group compilation albums together" and "List albums by all artists for that album" are enabled.

Thanks.
Comment 1 Spies Steven 2007-01-04 17:42:14 UTC
So Nigel just to make sure I understand what you're saying, the behavior you would prefer is to see the compilation album listed for the trackartist?  I also am not sure what the correct behavior should be :)
Comment 2 Nigel Birch 2007-01-04 23:58:27 UTC
Showing "Empty" has to be wrong (either show the album for that track artist, or don't show the track artist at all).  If a compilation album has track artists being shown under a artist search (adding COMPILATION=1 does this), then I think ALBUMARTIST albums should too.
Comment 3 Spies Steven 2007-01-05 11:08:45 UTC
I'll have a look at the behavior.
Comment 4 Spies Steven 2007-01-05 15:50:47 UTC
Created attachment 1760 [details]
Files to reproduce behavior

Nigel, the behavior I am seeing with your example is as follows:

On the SB UI:
Search -> Artists -> "Track"

My result is:
Artists Matching "Track" (1 of 4)
TrackArtistA
TrackArtistB
TrackArtistC
All Albums -> Empty

Is the "Empty" for "All Albums" the behavior that you are seeing?
Comment 5 Nigel Birch 2007-01-05 17:46:28 UTC
I didn't spot the "All Albums" showing "Empty", but yes I can see that too now that I look.

I've not tested with your MP3s, but the equivalent behaviour I see with FLACs is Search > Artists > "Track" giving these results:

TrackArtistA > "Empty"
TrackArtistB > "Empty"
TrackArtistC > "Empty"
Comment 6 Spies Steven 2007-01-08 16:46:22 UTC
Created attachment 1762 [details]
FLAC and mp3 files to reproduce behavior

I see it here now too, thanks!
Comment 7 windowshade 2007-04-01 14:59:59 UTC
This sounds like Bug 3824. Are you using MusicMagic?
Comment 8 Nigel Birch 2007-04-02 00:30:48 UTC
No MusicMagic, just one-FLAC-per-track FLACs.
Comment 9 Ross Levine 2007-05-23 16:31:31 UTC
Marking this as fixed and verified, if anyone is still seeing this please feel free to re-open with more details. See also bug 4979 4694 4925 & 4882. 
Comment 10 Nigel Birch 2007-09-06 04:34:26 UTC
I've re-opened this because after re-testing, the problem is still there.

1. The problem as described in the original bug (searching for track artist finds the artist buy going right shoes "Empty" rather than the album(s).  Setting "COMPILATION"="1" fixes this problem, but not 2. below.

2. I'm not seeing the behavior is comment 4 and comment 5, but instead I'm seeing something different.

- From the player UI, search for an artist.
- Use a sub-string of a track artist (e.g. "van" from "Vandross").
- The returned artists lists the track artist, plus other artists (e.g. "Luvig van Beethoven", "Luther Vandross", "Van Morrison", "Nirvana", etc.).
- Go right from "All Albums" lists one album only: "Requiem & Pavane".  This album isn't by any of the artists above, but has been matched based on "van" in the album name.

If there's any more info you need, please let me know.  Thanks.

Comment 11 Nigel Birch 2007-09-06 04:36:28 UTC
I've updated the version to v6.5.4 as I've now on v6.5.5 r12598.
Comment 12 Nigel Birch 2007-09-06 04:52:51 UTC
Another problem:

3. From the web interface, a simple search for "vand" finds the artist, clicking on the artists list a single album (OK) but clicking on the album lists no tracks (not OK).

Trying the same simple search again (actually after trying an advanced search, first) now lists two albums for artist (both "Duets") but one has the proper album artwork, and the other has a ? placeholder.  The proper album artwork one lists no tracks, whereas the placeholder album lists the correct track.

An advanced search shows the correct artist/album/tracks.
Comment 13 Nigel Birch 2007-09-06 04:55:05 UTC
I forgot to mention that problem 3. in comment 12 is with "COMPILATION"="1".  I've not tested with "COMPILATION"="0".
Comment 14 Blackketter Dean 2007-10-26 09:49:35 UTC
Nigel, is this still happening in 7.0?
Comment 15 Nigel Birch 2007-10-26 10:31:51 UTC
Good question. I'm on 6.5 still, so I can't test.  I'm also a bit too busy right now to install 7.0 do a test. Anyone on the CC list using 7.0?
Comment 16 Blackketter Dean 2007-11-21 09:30:23 UTC
Please retest with 7.0.
Comment 17 Blackketter Dean 2007-11-25 12:08:40 UTC
are you the right person to retest?
Comment 18 Nigel Birch 2007-11-25 12:10:49 UTC
I've just been moving up to v7.0, so I should be able to test this week (not sure whether it'll be today or next weekend).
Comment 19 Spies Steven 2007-11-26 10:49:56 UTC
Yes, I still see this behavior with SC 7.  I think the issue has something to do with the fact that these artists are only listed as 'TRACKARTIST' and not 'ARTSIST' in the database based on the 'contributorToRoleMap' schema.
Comment 20 Spies Steven 2007-11-26 10:54:48 UTC
*** Bug 4386 has been marked as a duplicate of this bug. ***
Comment 21 Blackketter Dean 2007-12-17 10:34:31 UTC
Yes, if you are searching by "Artist" then it shouldn't matter if it's an ALBUMARTIST or a TRACKARTIST to find a matching album.  It's far worse for an album to be missing from a search result than to have possibly non-matching items appear.
Comment 22 Andy Grundman 2007-12-17 11:10:07 UTC
Marking won't fix.

Please see bug 2479, it's the reason search works this way.  

The workaround is to check the Composer box under Server Settings -> Music Library -> Composer, Band and Orchestra in Artists.
Comment 23 Andy Grundman 2007-12-17 11:15:56 UTC
Hang on, I was testing with a file with different tags, let me retest with a valid file. :)
Comment 24 Andy Grundman 2007-12-17 12:06:44 UTC
Found it, fixed in change 15387.

Hopefully this won't break anything else.
Comment 25 Nigel Birch 2007-12-22 02:32:35 UTC
In a quick test, it looks like that fixed it for me.  Thanks.
Comment 26 Nigel Birch 2007-12-23 14:42:17 UTC
I've re-opened the bug as I'm seeing an odd behaviour.

When searching for the album artists or track artists, they're found okay.  However, when browsing (under browse artists, from player UI or web) the album artist isn't listed when COMPILATION=1 is set.  Setting COMPILATION=0 or removing the comment (so that the VA detection kicks in), and doing a wipe/rescan, causes the album artist to be listed.

I'm not sure if the change in comment 24 caused this, or whether it was introduced between 6.5 and 7.0.
Comment 27 rickwookie 2008-01-17 02:57:46 UTC
I'm sure this is related to the same problem so here goes:

All my tacks are single-track FLACs.

I have an album, for example, 'best of bowie' by 'David Bowie'. It's a 2CD set and all of the tracks from CD1 have ARTIST set as 'David Bowie', however some tracks from CD2 have ARTIST set as 'David Bowie; Queen' or 'David Bowie; Mick Jagger' for example. All the tracks from both CDs have ALBUMARTIST set as 'David Bowie' and there is no COMPILATION tag.
If I now Browse Artists to 'David Bowie' I only see one album - 'best of bowie' - which is the first CD. The second CD is found under 'Various Artists', however I would expect it to be found under the ALBUMARTIST, since that's what I have set up in the settings.

If I add a tag to all the tracks COMPILATION=0 then CD2 does show up under 'David Bowie', but as 'best of bowie' by 'David Bowie, Queen, Mick Jagger', etc.' which is not right, since the album is by 'David Bowie' only. This would indicate that COMPILATION=1 is assumed if there is no COMPILATION tag. This is wrong as the default should be COMPILATION=0. Also, if I add a tag BAND to all the tracks and set this to 'David Bowie', I then get the behaviour that I expect, i.e. under 'David Bowie' I have 'best of bowie CD1' and 'best of bowie CD2', both by 'David Bowie'.

This would indicate that the logic is handled correctly for BAND, but not for ALBUMARTIST.
Comment 28 Andy Grundman 2008-01-18 15:04:38 UTC
Punting to 7.0.1
Comment 29 rickwookie 2008-02-07 17:27:26 UTC
(In reply to comment #27)
> I'm sure this is related to the same problem so here goes:
> All my tacks are single-track FLACs.
> I have an album, for example, 'best of bowie' by 'David Bowie'. It's a 2CD set
> and all of the tracks from CD1 have ARTIST set as 'David Bowie', however some
> tracks from CD2 have ARTIST set as 'David Bowie; Queen' or 'David Bowie; Mick
> Jagger' for example. All the tracks from both CDs have ALBUMARTIST set as
> 'David Bowie' and there is no COMPILATION tag.
> If I now Browse Artists to 'David Bowie' I only see one album - 'best of bowie'
> - which is the first CD. The second CD is found under 'Various Artists',
> however I would expect it to be found under the ALBUMARTIST, since that's what
> I have set up in the settings.
> If I add a tag to all the tracks COMPILATION=0 then CD2 does show up under
> 'David Bowie', but as 'best of bowie' by 'David Bowie, Queen, Mick Jagger',
> etc.' which is not right, since the album is by 'David Bowie' only. This would
> indicate that COMPILATION=1 is assumed if there is no COMPILATION tag. This is
> wrong as the default should be COMPILATION=0. Also, if I add a tag BAND to all
> the tracks and set this to 'David Bowie', I then get the behaviour that I
> expect, i.e. under 'David Bowie' I have 'best of bowie CD1' and 'best of bowie
> CD2', both by 'David Bowie'.
> This would indicate that the logic is handled correctly for BAND, but not for
> ALBUMARTIST.

Forget all that! It was because I'm using dBPowerAmp and it generates the tag 'ALBUM ARTIST' (with a space) and NOT 'ALBUMARTIST', so the tag was obviously being ignored. Changing the tag to 'ALBUMARTIST' and it all behaves exactly as I would expect. Thanks to 'bcat' at the dBPowerAmp forum for pointing that out!
Comment 30 Andy Grundman 2008-04-04 14:15:06 UTC
Nigel, I'm not sure your new bug is related to this one.

I tested it a bit with the sample FLAC tracks attached to this bug and found that it shows "Various Artists" instead of "AlbumArtistD3" if I set COMPILATION = 1 in all the tracks.  This is a direct result of "Group compilation albums together" and so may not even be a bug.  If you still think it's a bug, please file a new bug and attach sample file(s) to reproduce.
Comment 31 James Richardson 2008-05-09 15:30:52 UTC
Verified not an issue with 7.0.1 - 19597
Comment 32 James Richardson 2008-05-15 12:25:58 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html
Comment 33 Chris Owens 2009-07-31 10:14:09 UTC
Reduce number of active targets for SC