Bug 6462 - "Tune in URL" should provide user feedback on errors
: "Tune in URL" should provide user feedback on errors
Status: REOPENED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 7.4.0
: All All
: -- normal (vote)
: Future
Assigned To: Unassigned bug - please assign me!
:
Depends on: 6369
Blocks:
  Show dependency treegraph
 
Reported: 2007-12-26 10:03 UTC by Mark Miksis
Modified: 2011-11-06 23:25 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments
trying to tune in to bugs.slimdevices.com (fehler=error) (66.87 KB, image/jpeg)
2008-07-28 01:52 UTC, Michael Herger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Miksis 2007-12-26 10:03:57 UTC
There are fairly regular forums post complaining that when the user enters a URL "nothing happens".  I think the web GUI will report "Tuned into station: http://www.somestation.com" even if the URL entered is completely invalid.  In some cases (I've only tested briefly) there are not even any log entries with the default logging settings.  The web GUI should report something useful.  Example messages would be:

- URL http://www.somestation.com is format XYZ.  SqueezeCenter supports the following streaming formats: a, b, c, etc.
- URL http://www.somestation.com was not found (404)
- URL http://www.somestation.com timed out waiting for data
- etc

(The first one might be tricky given that some of these are platform and player dependent, and plugins like Alien can change the list of supported formats.)
Comment 1 Michael Herger 2007-12-27 00:46:26 UTC
We'll have to make the loading a synchronous process. Today it's imho async, returning the page before the stream has started playing. Thus when the page is created, the result isn't known yet. 

I assume that's with SS6, or a different skin than Default. In the new Default skin there's no feedback at all, unless a previous playback being stopped.
Comment 2 Mark Miksis 2007-12-27 08:25:38 UTC
(In reply to comment #1)
> I assume that's with SS6, or a different skin than Default. In the new Default
> skin there's no feedback at all, unless a previous playback being stopped.
> 
This is with SC7 Default skin.  AFAICT, there is no feedback at all if you enter the URL from the home page but there is always the "Tuned into URL ..." message if you enter it from the Tune In URL page.
Comment 3 Andy Grundman 2007-12-27 21:03:15 UTC
This will be handled by the event log, see bug 6369.
Comment 4 Mark Miksis 2007-12-27 21:43:14 UTC
(In reply to comment #3)
> This will be handled by the event log, see bug 6369.
> 

Well, I can't view that bug so I guess I'll take your word for it...
Comment 5 Andy Grundman 2007-12-28 06:59:32 UTC
Yeah, sorry, the basic idea is a table in the database where any error can be logged: scan errors, network errors, etc, and a red icon would appear in the bottom of the web UI where you could click and view them.  This way we can log errors easily from anywhere in the code without having to worry about how to propagate it back up to the user on whatever interface they are using (web, Jive, etc)
Comment 6 Blackketter Dean 2007-12-28 07:03:01 UTC
I'm not sure that only using log is the best solution for this kind of message to the user.  It seems to me that on Jive and the web interface we are lacking in immediate feedback on radio station errors.  The SB is better in this regard.  There are other bugs related to Jive popups, so this bug can focus on the Web feedback.

Some kind of pop-up overlay  on the web view would be great, but even a notice with a descriptive error message at the bottom "info" area would be an improvement.

Michael: can you look at this for 7.0?
Comment 7 Michael Herger 2008-01-03 04:25:10 UTC
This bug depends on 6369 which you targetted for 7.1. Thus this won't make it into 7.0 unless you want some isolated solution which would soon be obsolete.
Comment 8 Blackketter Dean 2008-02-24 21:14:48 UTC
I'm not 100% sure that this is dependent on 6369.  We could consider hooking the showbriefly mechanism into the web UI for this kind of feedback.  I want to talk about this for 7.0.1...
Comment 9 Michael Herger 2008-03-10 01:35:42 UTC
change 17831 - return the showBriefly with the CLI's status query. To be used in cases (web UI) where we can't keep a connection open to subscribe to events.
Comment 10 Michael Herger 2008-03-10 02:26:21 UTC
change 17832 - display the showBriefly animation in the web interface's status bar
Comment 11 Michael Herger 2008-03-10 02:38:38 UTC
Not the right way to solve this issue: we're now getting all showBrieflies in the web interface, including player state changes. Argh...
Comment 12 Adrian Smith 2008-03-10 04:08:09 UTC
I tend to think a showBriefly type mechanism is the right way for flagging information to the user.

As it sounds like it is not possible to subscribe to displaystatus messages via the web, do we want to do something which categorises showbriefly messages and only sent the relavent ones to the web interface.  What about adding a 'web' key to the display hash to be used in a similar fashion to the jive one - and sending the text in the web key, but suppressing if that is not present?
Comment 13 Michael Herger 2008-03-10 05:03:44 UTC
> As it sounds like it is not possible to subscribe to displaystatus messages via
> the web, do we want to do something which categorises showbriefly messages and
> only sent the relavent ones to the web interface.  What about adding a 'web'
> key to the display hash to be used in a similar fashion to the jive one - and
> sending the text in the web key, but suppressing if that is not present?

I thought about this. But then I wondered whether the current implementation actually is: there aren't all that many showBrieflies after all. And the web UI should only be displaying the current player's events of the past 15 seconds.

But the web key would be the best approach (besides the need to add one more parameter to some of the calls). It would also allow for better wording in some cases.
Comment 14 Michael Herger 2008-03-13 09:37:39 UTC
let's consider this good enough for 7.0.1 and review for 7.1
Comment 15 Michael Herger 2008-04-22 05:01:03 UTC
change 19023 - adding instant feedback about the action taken, plus showBriefly if anything went wrong
Comment 16 Ross Levine 2008-07-25 17:16:08 UTC
So is there supposed to be a showbriefly error message in the webui? I see 404 messages on the player display but didn't see anything on the webui. 22114
Comment 17 Michael Herger 2008-07-28 01:52:58 UTC
Created attachment 3693 [details]
trying to tune in to bugs.slimdevices.com (fehler=error)
Comment 18 Blackketter Dean 2008-07-28 06:55:53 UTC
Hm, that's not really enough for an error message.   It would need to be either a pop-up window/overlay or be right next to the dialog box in red.
Comment 19 Michael Herger 2008-07-28 07:07:44 UTC
The problem is that I don't know what showBriefly is an error message and what not. showBriefly just displays a text, whether informational or error message - you can't say. The validation is done asynchronously, thus there's not even a return code or something I could wait for.
Comment 20 Ross Levine 2008-07-28 13:38:30 UTC
Re-opening this bug per comment #18. The showBriefly may not be the ideal location for this message. 
Comment 21 Michael Herger 2008-07-28 13:47:26 UTC
Now if somebody could come up with a good design. The whole showBriefly code was added for this exact issue. 
Comment 22 Adrian Smith 2008-07-28 13:48:06 UTC
I think the suggestion I had for jive still holds - we add a "type" key to the hash passed to showbriefly.   This indicates the type of message: information, warning, error etc.  I originally wanted to reflect this as an icon on jive in the popup but this didn't happen - but it would mean you could selectively make some messages more prominant than others.
Comment 23 Weldon Matt 2009-10-04 16:34:32 UTC
No idea if this is still a bug.  This whole bug predates my tenure at Logitech...
Comment 24 Michael Herger 2009-10-04 23:14:11 UTC
It's still as much an issue as it ever was (not a biggie for me, but others). Type some nonsense URL in the Tune In field and see what happens - or not.

Targeting for 8.1 sounds like "FUTURE" or "WONTFIX" to me... I doubt we should already be targeting to this release.
Comment 25 Chris Owens 2010-02-02 15:08:32 UTC
Matt Weldon doesn't work for us any more.
Comment 26 Alan Young 2011-11-06 23:25:11 UTC
Unassigned bugs cannot have a priority.