Bugzilla – Bug 6134
Skin switch preview doesn't work
Last modified: 2009-09-08 09:14:32 UTC
I have a Beta version of 7.0 - 14602. When I change from one skin to another, there is always a line which says "Click here to see the new skin". This never works - the resulting display is always some corrupted combination of the new and old skin. If the current skin is Default, the corrupted version appears in the separate browser window which was opened for "SqueezeCenter Settings" rather than the real window. Refreshing the browser always results in a correct display. This happens in two situations - when I am running IE7 on a remote client connected to the SC server, and when I am running IE6 on the SC server itself. If I don't select "click here", nothing happens, so it is always necessary to refresh the browser to get a new skin. Is it possible to initiate this refresh from SC itself? Or perhaps the message should just say "Refresh your browser to see the new skin".
I think that's what the link attempts to do - reload the page and clear the browser cache. It's not a preview.
That makes much more sense than a preview, but it still doesn't work like that.
Michael will work on this.
Created attachment 2437 [details] better info without link The various skins we have are too different to have the link working: in the new Default skin you'd have to fully refresh two windows, additionally changing the URL etc. I therefore believe it's much simpler clearly telling the user that he should close the window and fully reload SC in the browser. This patch changes the wording plus pops up a message box (Default only) with this advice. Let me know what you think about it.
Dean - could you please give this patch a try and tell me what you think about it? I think we've reached a point where a simple link just doesn't work any more.
Is there a way to simply force a refresh to the browser? Other than doing that, I would think that a simple message telling the user to refresh woudl be OK.
Created attachment 2458 [details] display a popup telling the user to reload the full page New patch, adding a similar popup to the old skins, too
I've checked in the above patch (change 15136). Unfortunately we don't have a way to do the reload automatically, as there's no common parent window in eg. the Default skin. This change adds a more explicit message about what there is to do. Please give it a try.
feel free to re-open if needed. There's not much more we can do.
I have downloaded version 7.0 - 15205 and tested many skin switch combinations. Some seem to work and some don't. The skins are divided into two types - the "dual" skins (Classic, Default, Fishbone and Light) which show the playlist in a separate right hand pane, and the "single" skins (Handheld, Nokia770 and Touch) which show only one pane. Switching between any of the "dual" skins works fine - the message pops up, and even though the message says to close and reload the window, simply refreshing the browser produces the correct result. Switching from a "dual" skin to a "single" skin never pops up the message, but after a browser refresh the result is correct. Switching from a "single" skin to a "dual" skin always pops up the message. If the browser is refreshed, the skin switches but the "dual" skin only has one pane (the playlist display is gone). Closing the window and reopening it produces the correct result. Switching between the "single" skins never pops up the message, but the result is correct. Given that the message says to close and reopen the window, I think the only real problem left is that the message never pops up if the new skin is "single".
Steve - thanks for the feedback. You're right, there are two categories of skins, which are working or not. But it's not the number of panes used, but the javascript these skins are using. I've only adapted the EN's and Default's scripts. While the (two pane) Classic and Fishbone skin are using EN's JS, Touch & Nokia770 don't. And Handheld doesn't use any JS at all. As mentioned before changing skin will never be fully automatic, due to the nature of a web based interface and the differences between the different skins. Skins in our case aren't just a set of different stylesheets and artwork files. But they are partially highly optimized for different devices, offering a wide range of flexibility and feature richness. This variety at times comes at the cost of uniformity.
This bug is being closed since it was resolved for a version which is now released! Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html If you are still seeing this bug, please re-open it and we will consider it for a future release.