Bugzilla – Bug 5928
Display of current playlist buttons in default skin
Last modified: 2007-10-30 09:37:46 UTC
A few minor things I spotted today with the current playlist option buttons in the default skin: 1. There are icons for switching on/off artwork for each song in the current playlist. These icons do not have tooltips - most other things in default skin do. 2. Don't see why both of the artwork/text icons are always visible - could toggle the displayed image to show the current mode, rather than show both (would be more consistent with the control on the browse albums page). 3. If I clear the current playlist, the save option disappears, but the clear options is still visible. Might as well hide the clear button if the playlist is already empty.
Created attachment 2324 [details] playlist link handling show/hide playlist clear, save, artwork links based on whether playlist has items or not. add tooltips to artwork link button
guess I need to add Michael in order for him to see the proposed patch :)
Thanks kdf - change 14185 But then we probably should get rid of the artwork button, too... I'm sorry I've been lazy on GUI updates recently, as I'm waiting for the final artwork.
the patch was intended to get rid of the artwork link as well. However, I accidentally deleted the hunk required (I have a number of other local patches in that code). Index: server/HTML/Default/html/main.js =================================================================== --- server/HTML/Default/html/main.js (revision 14139) +++ server/HTML/Default/html/main.js (working copy) @@ -644,6 +647,8 @@ tooltipType: 'title', handler: Playlist.save }); + } else { + Ext.get('playlistToggleArtwork').hide(); } // dragging doesn't survive a reload
Change 14216 - thanks!