Bug 5599 – Tag "Album" in frame page "title"

Bug 5599 - Tag "Album" in frame page "title"

Summary:

Tag "Album" in frame page "title"

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Skins
Version:	7.0
Platform:	PC Windows XP

Importance:	P2 minor (vote)
Target Milestone:	---
Assigned To:	Squeezebox QA Team email alias

URL:	http://192.168.1.XXX:9000/browsedb.ht...
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2007-09-28 12:18 UTC by Robin V.
Modified:	2007-09-30 23:46 UTC (History)
CC List:	2 users (show)

See Also:
Category:	---

Attachments
Tags in title name (191.99 KB, image/png) 2007-09-28 12:21 UTC, Robin V.	Details
one solution (2.78 KB, patch) 2007-09-28 12:54 UTC, KDF	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Robin V. 2007-09-28 12:18:18 UTC

Maybe less than a bug, but when you "open browsing frame in a new window" to get more room for browsing your music, the title of the page is not "Album", but "<span>Album<span>". It surely happen when browsing for something else than albums.

Comment 1 Robin V. 2007-09-28 12:21:47 UTC

Created attachment 2187 [details]
Tags in title name

Comment 2 KDF 2007-09-28 12:51:18 UTC

To clarify, this is Default skin only.  Arising from the extended use of [% pagetitle %] to create a styled header at the top of the browsedb.html pages.  Also affects home.html.  [% pagetitle %] is intended to be supplied with a localised string only, not a block or style element.

Comment 3 Michael Herger 2007-09-28 12:53:35 UTC

As kdf noticed correctly I'm kind of abusing a variable which wasn't meant to carry around HTML tags. I was too lazy so far to investigate any further as it usually is "hidden" inside the frame.

Comment 4 KDF 2007-09-28 12:54:42 UTC

Created attachment 2188 [details]
one solution

leave pagetitle as just a localised string, make use of pageHeaderInfo for the styled blocks as it is not yet being used by the Default skin pageheader.html template.

Comment 5 Michael Herger 2007-09-30 23:46:52 UTC

Change 13409 - thanks kdf!