Bugzilla – Bug 552
DRM'ed WMA files should be skipped
Last modified: 2008-12-18 11:53:10 UTC
And the user should be given some notice that they aren't playable.
*** Bug 553 has been marked as a duplicate of this bug. ***
what happens curently with a DRM WMA? If a song registers as not readable, it should be showing an error message on teh server. If the DRM file is passing as readable, we'll need a specific way to detect the DRM.
Nope - no error. SB says it's playing, but sits on 0% or 0 seconds and the server also thinks it's playing with no errors shown. BTW - Pause does nothing.... This happens for all DRM files. Also, it would be useful for the DRM status to be shown on the server / SB display screens when you go to the detailed info view on a song.
run from command line: c:\program files\slimserver\server\slim.exe --d_source or check d_source in server settings, debugging. play a DRM song and paste some of the log here. hopefully there are some sort of messages back from the decoder that may be able to be used.
Created attachment 136 [details] Log from DRM played file
Created attachment 137 [details] File that is DRM protected
given that log information, the player UI should most definately have shown a brief "cannot play file" error. It shoudl for any case where the file turns up unreadable (as this one has). I may have missed a case. Can you watch the player screen carefully when you try to play? Maybe its too short, or not there are all? This still will not address any UI request to display DRM status. It would be completely insane to play every file as we start up in order to test DRM status.
darn..check that. The error simply means its the end of the song. The server thinks its playing just fine, except that the song has simply ended very soon after it starts. evil.
Yes - I checked, there is no error. However, there must be a tag of some sort to flag DRM. In Windows, file explorer, you can right click the file and one of the fields is named "Protected" and set to yes. So, if you can find out how Windows detects this, then you should be able to pick this up in the cache scan?
I've just fired up a DRM song in notepad.exe and I can clearly see a DRM marked in the tag section of the file, so it should be detectable?
Absolutely should! well spotted. Looks like a rather sizeable block of rights info there. CPAN's Audio::WMA doesn't seem to be returning that info currently for us to use, however. We've got connections though :)
Created attachment 140 [details] show DRM info, and skip playback of DRM'd WMA Simple patch to CPAN module to return a flag when DRM block found. Show DRM info in songinfo.html and trackinfo player display. Skip song with the standard error message in player display if DRM song is played.
changing status, pending approval from CPAN.
Great!!! Thanks!!! How do I apply this patch. Is it in the nightlys?
Any update from CPAN? It would be great to get this fixed.
the cpan module has been patched, but the rest is slated for after 5.3.1. Unless that plan changes, this patch should hit the nightlies within a day or two of the release of 5.3.1. until then, you will have to be patient :)
Feel free to apply this patch to the main trunk of CVS.
ok, I'll commit tonight before nightly builds get made.
I've just tried it and it's all working - thanks!! Could I request two things? 1/On the SB instead of saying "error opening file" can it say "skipping DRM protected file" 2/on SlimeServer, next to the rescan button, can there be an option to exclude from the scan DRM protected files?
sure, you can request it. managing DRM isnt my interest tho. I'll leave that to someone else. dont want it indexed....dont have it in the slimserver music folder is my feeling.
oh yeah... for 1, you probably want to reopen this bug. for 2, that woudl probably be best done as a new request since its far enough removed from the subject of this bug
Can we have slimserver just ignore the tracks during scanning instead of adding a track that can never be played to the library?
Whoops, this bug has already been created.. *** This bug has been marked as a duplicate of 604 ***
Routine bug db maintenance; removing old versions which cause confusion. I apologize for the inconvenience.