Bug 552 - DRM'ed WMA files should be skipped
: DRM'ed WMA files should be skipped
Status: RESOLVED DUPLICATE of bug 604
Product: Logitech Media Server
Classification: Unclassified
Component: Audio
: 5.x or older
: Macintosh All
: P2 enhancement (vote)
: Future
Assigned To: KDF
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-09-14 14:05 UTC by Blackketter Dean
Modified: 2008-12-18 11:53 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
Log from DRM played file (101.11 KB, text/plain)
2004-09-21 14:37 UTC, Stuart Beesley
Details
File that is DRM protected (3.65 MB, audio/x-ms-wma)
2004-09-21 14:41 UTC, Stuart Beesley
Details
show DRM info, and skip playback of DRM'd WMA (8.26 KB, patch)
2004-09-23 00:17 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Blackketter Dean 2004-09-14 14:05:50 UTC
And the user should be given some notice that they aren't playable.
Comment 1 KDF 2004-09-15 15:20:02 UTC
*** Bug 553 has been marked as a duplicate of this bug. ***
Comment 2 KDF 2004-09-20 15:27:16 UTC
what happens curently with a DRM WMA?  If a song registers as not readable, it
should be showing an error message on teh server.  If the DRM file is passing as
readable, we'll need a specific way to detect the DRM.
Comment 3 Stuart Beesley 2004-09-21 14:19:38 UTC
Nope - no error. SB says it's playing, but sits on 0% or 0 seconds and the
server also thinks it's playing with no errors shown. BTW - Pause does
nothing.... This happens for all DRM files.

Also, it would be useful for the DRM status to be shown on the server / SB
display screens when you go to the detailed info view on a song.
Comment 4 KDF 2004-09-21 14:30:07 UTC
run from command line:
c:\program files\slimserver\server\slim.exe --d_source

or check d_source in server settings, debugging.  play a DRM song and paste some
of the log here.  hopefully there are some sort of messages back from the
decoder that may be able to be used.
Comment 5 Stuart Beesley 2004-09-21 14:37:41 UTC
Created attachment 136 [details]
Log from DRM played file
Comment 6 Stuart Beesley 2004-09-21 14:41:11 UTC
Created attachment 137 [details]
File that is DRM protected
Comment 7 KDF 2004-09-21 15:19:42 UTC
given that log information, the player UI should most definately have shown a
brief "cannot play file" error.  It shoudl for any case where the file turns up
unreadable (as this one has).  I may have missed a case.  Can you watch the
player screen carefully when you try to play?  Maybe its too short, or not there
are all?

This still will not address any UI request to display DRM status.  It would be
completely insane to play every file as we start up in order to test DRM status.
Comment 8 KDF 2004-09-21 15:22:08 UTC
darn..check that.  The error simply means its the end of the song.  The server
thinks its playing just fine, except that the song has simply ended very soon
after it starts. evil.
Comment 9 Stuart Beesley 2004-09-22 12:15:08 UTC
Yes - I checked, there is no error.
However, there must be a tag of some sort to flag DRM. In Windows, file 
explorer, you can right click the file and one of the fields is 
named "Protected" and set to yes. So, if you can find out how Windows detects 
this, then you should be able to pick this up in the cache scan?
Comment 10 Stuart Beesley 2004-09-22 12:26:30 UTC
I've just fired up a DRM song in notepad.exe and I can clearly see a DRM marked 
in the tag section of the file, so it should be detectable?
Comment 11 KDF 2004-09-22 13:40:26 UTC
Absolutely should! well spotted.  Looks like a rather sizeable block of rights
info there.  CPAN's Audio::WMA doesn't seem to be returning that info currently
for us to use, however. We've got connections though :)
Comment 12 KDF 2004-09-23 00:17:19 UTC
Created attachment 140 [details]
show DRM info, and skip playback of DRM'd WMA

Simple patch to CPAN module to return a flag when DRM block found.  Show DRM
info in songinfo.html and trackinfo player display.  Skip song with the
standard error message in player display if DRM song is played.
Comment 13 KDF 2004-09-23 10:11:00 UTC
changing status, pending approval from CPAN.
Comment 14 Stuart Beesley 2004-09-23 11:27:49 UTC
Great!!! Thanks!!! How do I apply this patch. Is it in the nightlys?
Comment 15 Stuart Beesley 2004-09-29 11:57:18 UTC
Any update from CPAN? It would be great to get this fixed.
Comment 16 KDF 2004-09-29 12:49:47 UTC
the cpan module has been patched, but the rest is slated for after 5.3.1. 
Unless that plan changes, this patch should hit the nightlies within a day or
two of the release of 5.3.1. until then, you will have to be patient :)
Comment 17 Blackketter Dean 2004-10-01 14:21:56 UTC
Feel free to apply this patch to the main trunk of CVS.
Comment 18 KDF 2004-10-01 15:47:44 UTC
ok, I'll commit tonight before nightly builds get made.
Comment 19 Stuart Beesley 2004-10-02 02:52:36 UTC
I've just tried it and it's all working - thanks!! Could I request two things? 
1/On the SB instead of saying "error opening file" can it say "skipping DRM 
protected file"
2/on SlimeServer, next to the rescan button, can there be an option to exclude 
from the scan DRM protected files?
Comment 20 KDF 2004-10-02 02:59:45 UTC
sure, you can request it.
managing DRM isnt my interest tho.  I'll leave that to someone else.
dont want it indexed....dont have it in the slimserver music folder is my feeling.
Comment 21 KDF 2004-10-02 03:13:01 UTC
oh yeah...
for 1, you probably want to reopen this bug.

for 2, that woudl probably be best done as a new request since its far enough
removed from the subject of this bug
Comment 22 Blackketter Dean 2004-10-04 07:30:58 UTC
Can we have slimserver just ignore the tracks during scanning instead of adding a track that can never 
be played to the library?
Comment 23 Blackketter Dean 2004-10-04 07:31:59 UTC
Whoops, this bug has already been created..


*** This bug has been marked as a duplicate of 604 ***
Comment 24 Chris Owens 2008-12-18 11:53:10 UTC
Routine bug db maintenance; removing old versions which cause confusion.  I apologize for the inconvenience.