Bugzilla – Bug 5511
mismatched language between jive and SS messes up jive settings menu hierarchy
Last modified: 2009-09-08 09:13:55 UTC
this is all subject to change with discussion of settings cleanup, but: if locale is matched between SS and Jive, Setting menus look like this: SETTINGS-> PLAYER_SETTINGS-> REMOTE_SETTINGS-> if locales are mismatched, settings menus get rendered like this: REMOTE_SETTINGS-> SETTINGS-> PLAYER_SETTINGS-> mismatching localizations between the two is not likely, but this isn't how our software should work either...
Actually I think this is the start of a big problem, having strings from slimserver and jive is just going to lead to confusion :-/. slimserver really needs to always send data in the same locale that jive is using, but afaik that's a big architectural change in slimserver to do that.
I think that this is about language, not system locale, right?
*** Bug 5785 has been marked as a duplicate of this bug. ***
Fixed in r754.
This is not fixed in r754. The fix is for bugs 5905 and (dup) 5785
grr, sorry. bad bugzilla day :)
Another issue I've encountered today is the fact that Slim::Control::Jive::registerPluginMenu() is called during startup (initPlugin), and it's using expanded strings instead of tokens. Thus if you change SC's language, this change won't take effect for the strings exported to Jive. Today I ended up having EN, DE and IT in one menu :-). If SC is to deliver the strings in the langue asked for by Jive this should be covered anyway. Just another possible issue to keep in mind.
in the main menu rework that is in progress, all menu items sent over from SC will require a unique "id" token, and the localized strings are just properties of the menu item. So, you definitely won't be seeing repeated SC items (plugins or otherwise) across different languages. It may, however some work so the SC items are re-delivered in the new language choice. That needs to be revisited after this menu rework is complete. Also, FWIW, the issue first reported in this bug will go away completely with the menu rework.
The issue originally reported in the bug is gone with the menu rework, as we do not rely on localized strings as identifiers for menu items. The only remaining thing to consider is whether, when Jive changes language, it should send a command to SC to change its language as well, then send a new localized menu back to Jive. Further, when SC language changes, should Jive be sent a directive to change as well? Jive supported langs are a subset of SC langs, so there may need to be some added logic to handle that. My two cents: it works well enough right now. I'm moving this to "Future" for target milestone. Assigning to Dean for comment. Michael, feel free to comment as well.
Marking fixed, opening new bug 6461 for the remaining issue.
This bug appears to have been fixed in the latest release! If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look. Make sure to include the version number of the software you are seeing the error with.