Bug 5173 - äöü change to strange characters
: äöü change to strange characters
Status: RESOLVED WONTFIX
Product: Logitech Media Server
Classification: Unclassified
Component: Display
: 6.5.3
: PC Windows Vista
: P2 normal (vote)
: Future
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-07-21 02:13 UTC by Schindler
Modified: 2008-01-07 07:25 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Schindler 2007-07-21 02:13:45 UTC
Stored Radiostationnames in Favorites or even Squeezebox names containing äöü change letters in the name.

example:

correct: Musigwälle 531
 
changes to:

incorrect: Musigwälle 531


This is with Linux (ClarkConnect) and Windows Versions 6.5.3. The change is happening after a period of time, not immedeately.
Comment 1 KDF 2007-07-21 10:46:37 UTC
system info please, as reported at the bottom of the server settings page.
are you using mucimagic or itunes?
Comment 2 Michael Herger 2007-07-21 12:52:40 UTC
In the forum thread (German) he mentionned having run 6.5.3 (7/11 nightly) on ClarkConnect and Vista. And I think I've seen it on MacOS 10.4.10, too (latest trunk).

Christian - can you confirm that the problem arrises when restarting the server? 
- I've set the player name to "Ältere Kiste"
- played some songs, rescanned my collection (with or without iTunes)
- no problem so far.
- restart SlimServer
- Now it's "Ältere Kiste"

It looks as if the configuration file wasn't read as UTF8.
Comment 3 Michael Herger 2007-07-21 13:17:28 UTC
We need to set the utf8 flag for preferences. Possible patch for trunk:

Index: /Users/mh/Documents/workspace/slimpy/Slim/Utils/Prefs/Namespace.pm
===================================================================
--- /Users/mh/Documents/workspace/slimpy/Slim/Utils/Prefs/Namespace.pm	(revision 12394)
+++ /Users/mh/Documents/workspace/slimpy/Slim/Utils/Prefs/Namespace.pm	(working copy)
@@ -31,6 +31,9 @@
 
 my $log = logger('prefs');
 
+# make sure preferences are flagged UTF8 (https://bugs-archive.lyrion.org/show_bug.cgi?id=5173)
+$YAML::Syck::ImplicitUnicode = 1;
+
 # Simple validator functions which may be referenced by name in setValidate calls
 my $simpleValidators = {
 	#                   $_[0] = pref, $_[1] = value, $_[2] = params hash, $_[3] = old value, $_[4] = object (client) if appropriate
Comment 4 Michael Herger 2007-07-21 13:28:33 UTC
I'm not sure about 6.5.x. There are the following lines around line 768 in Slim::Utils::Prefs.pm:

# We always want to write out just bytes to the pref file, so turn off
# the UTF8 flag.
$value = Slim::Utils::Unicode::utf8off($value);

...and exactly this line seems to break things :-/. If I disable it, the characters get read/written correctly.
Comment 5 Schindler 2007-07-22 00:44:31 UTC
Sorry use Vista not XP, here the version:

VERSIONSINFORMATIONEN
SlimServer-Version: 6.5.3 - 12376 - Windows Vista - DE - cp1252
IP-Adresse des Servers: 192.168.1.xxx
Perl-Version: 5.8.8 MSWin32-x86-multi-thread
MySQL-Version: 5.0.22-community-nt 

then on the other box the official 6.5.3 for ClarkConnect Linux.

- If I restart SlimServer service Favourites are changed immediately. The Squeezebox name not, I don't know when that will change... (this I only can test on VISTA right now)
Christian
Comment 6 Schindler 2007-07-22 00:51:41 UTC
btw. I am not using mucimagic or itunes both are dissabled on the plug-in page. Just use "MyPicks" to add radiostations to Favourites.

christian
Comment 7 Michael Herger 2007-07-22 01:53:28 UTC
Hey, that's a good pointer: MyPicks has nothing to do with the favourites. It just replaces it (if I'm not wrong). So there's an issue with MyPicks - which is best reported to its author, as it's not part of SlimServer.

Could you please confirm the issue with the player name?
Comment 8 Schindler 2007-07-22 01:59:24 UTC
Michael, the playername changed too... but not on server service restart. I had the problem with the server of my parents they have several SQBs one named "Küche". But I changed mine to Küche too and maybe I will be able to see when it changes...

christian
Comment 9 Adrian Smith 2007-07-22 09:17:53 UTC
So are there two problems here - one with player names [which are stored in preferences] and a separate one with MyPicks, which probably transfers to 7.0 Favorites as its the same underlying code?

In the case of MyPicks/Favorites - what does the opml file look like that stores the info if you open it in an editor?
Comment 10 Adrian Smith 2007-07-22 09:43:08 UTC
Confirmed no problem with MyPicks or 7.0 favorites.  The problem is with prefs.
Comment 11 Michael Herger 2007-08-02 03:48:18 UTC
*** Bug 2926 has been marked as a duplicate of this bug. ***
Comment 12 Chris Owens 2007-08-07 12:32:57 UTC
Which opml file are you trying to find out about, Triode?
Comment 13 Adrian Smith 2007-08-07 12:49:43 UTC
There's actually no issue with the opml handling - the problem is that preferences won't store unicode strings at present.  Need to assess whether there are any side effects of allowing unicode encoding in the preference files.
Comment 14 Chris Owens 2007-09-18 12:41:01 UTC
I would rather not change the format of the prefs file to support unicode this close to the 7.0 release.
Comment 15 Schindler 2007-09-21 13:46:43 UTC
there is also something wrong in v.7 (9.21)

In the favoriten it is correct but on the squeezebox it is wrong - always... (Musigwälle 531)
)

christian

Comment 16 Michael Herger 2007-12-10 01:21:58 UTC
*** Bug 6297 has been marked as a duplicate of this bug. ***
Comment 17 Michael Herger 2007-12-10 05:59:06 UTC
Christian - can you still reproduce this on the latest nightly build? 
Auronthas - can you please give us some information about your system? What language settings are you using?

I just tried German umlauts and some Hebrew text and wasn't able to reproduce.
Comment 18 Michael Herger 2007-12-10 06:08:09 UTC
Oh, and what browsers are you using?
Comment 19 Schindler 2007-12-10 06:13:37 UTC
and which nightly? I currently use 6.5.4 and there this bug is still present.
Comment 20 KDF 2007-12-10 07:58:49 UTC
Use the 7.0 nightly builds.  Development has stopped for 6.5.5 builds so no fixes will be ported to that.
Comment 21 Lim Chiau Wu 2007-12-10 14:20:24 UTC
(In reply to comment #17)
> Christian - can you still reproduce this on the latest nightly build? 
> Auronthas - can you please give us some information about your system? What
> language settings are you using?
> I just tried German umlauts and some Hebrew text and wasn't able to reproduce.

My OS is Window Vista - EN - cp1252, SqueezeCenter Version: 7.0 - 14651.

My language setting is English(Malaysia). I can view the chinese text in Squeezenetwork with no problem after editing in favorite but not in SC.  

I have posted two screenshots at bug 6297, you may take a look.


Comment 22 Michael Herger 2007-12-13 04:03:30 UTC
Development on 6.5.x has stopped, thus this issue won't be fixed. Feel free to add comments to bug 6297 if you still see this problem on SC7. Thanks!
Comment 23 Michael Herger 2008-01-04 07:20:30 UTC
I've checked in a patch for bug 6297 which should fix this issue in SC7. Please give it a try.
Comment 24 Lim Chiau Wu 2008-01-07 05:52:10 UTC
I installed nightly build 6 Jan yesterday. When i click on the edit icon at favorite, it leads me to a blank page on the left pane. When I hit refresh, it is back to Home. I have tried few times, even shutdown and restart, same result.
Comment 25 Michael Herger 2008-01-07 07:25:28 UTC
This bug is closed - please update bug 6297 instead. Thanks.