Bugzilla – Bug 4710
AIFF & WAV id3 tags no longer read by Slimserver.
Last modified: 2008-12-18 11:12:12 UTC
Slimserver no longer reads id3 tag data from iTunes created AIFF files. I have tested Slimserver 6.5.1 & 7.0a1 on both Mac OS X & Win XP. Slimserver 6.3.1 does read the tags.
Created attachment 1788 [details] iTunes AIFF with id3 tags
I second this bug. Most of my audio files are AIFF tagged by iTunes.
and to further iterate, version 6.5.0 also read the tags fine, this bug shows up in 6.5.1
Chris, who should this be assigned to?
oddly, the sample file is working fine for me with 7.0 Unfortunately, there are a lot of differences between MP3::Info for 6.5.1 and 7.0, so I'm afraid it's up to Dan.
Really? I will try again with 7.
It still does not work for me :( KDF, is it possible that your Slimserver is getting the tag information from iTunes and not from the file itself?
not itunes. old MP3::Info it seems. I had svn9959, when the fully updated version is 10616. Turns out change 10616 is the culprit. change 10533 works fine. The change in question is the fix for bug 4486. With change 10533, I get tags returned. With change 10616 I get "No ID3 or APE tag found".
Awesome! Thanks KDF! Chris, should this be assigned to Dan then?
Yep. Also, please set the 'Target Milestone' to 7.
setting target. funny, as it's MP3::INFO, this ends up still being a Dan thing :)
Turns out WAV files with id3 tags are no longer read by Slimserver either. WAV list tags are still read by Slimserver however. An unrecommended workaround would be to replace the current MP3::INFO with a previous one.
See also bug 1604
For reference, the change KDF refers to as causing this bug was implemented to fix bug 4486
(In reply to comment #13) > See also bug 1604 > Um, please forgive me for asking, but what does guess tags have to do with MP3::INFO no longer able to read AIFF & WAV id3 tags as a result of change 10616? Thanks :)
Change 12247 has a fix. Works for me but I ain't got WAV files.
Steven, the reason for linking bug 1604 with this one is that the guess tags results (which are often problematic because they are only a 'guess') are a symptom of this bug. Where users previously had tagged values showing up, now they see guessed results (easily resulting in odd album, artist, and title results unless formatting is carefully chosen)
KDF, thank you for the clarification. That's what I figured, but I did not want to assume. Fred, I am going to try your Change 12247 against some AIFF and WAV files along with the MP3 from bug 4486 and report back, thanks!
Change 12247 looks great to me. SlimServer now reads AIFF & WAV ID3 tags and does not crash on the files from Bug 4486. Chris, can we move this change into the 6.5.3 branch?
I would want to hear from the KDF or some other trusted developer(s) about how much effort and risk would be involved.
The change appears safe enough to me. It simply removes an optimisation to bypass id3 reading for irrelevant file types. With more recent optimisation, this check is no longer valid, always fails and thus blocked id3 reading for the correct file types. Of course, that's basically restating what Fred added in the comments, and I think it's certainly safe to trust Fred :) cc'ing fred for his input on porting to 6.5.3. If it is worth porting, it should definitely be done sooner rather than later.
IMHO it's pretty easy and safe to port. Code is the same I think so just apply the svn diff.
I am reassured. Would you, Fred, or KDF please go ahead and commit to 6.5.3 then?
merged to 6.5.3 at change 12273 updated changelogs in trunk to reflect new target