Bugzilla – Bug 4351
change to idle screensaver when playback stops during Now Playing" screensaver.
Last modified: 2008-12-18 11:12:53 UTC
currently, if the player is set to use the Now Playing screensaver, the player cannot change to the idle saver if playback is stopped. This is becuase the sanity check makes sure we're not in 'screensaver' mode already, even if the new screensaver is no longer 'screensaver' mode. diff to come.
Created attachment 1640 [details] check that saver is validMode and compare to itself, or sanity check. we currently check that $mode ne 'screensaver' to protect against multiple pushes into 'screensaver' mode. This is to catch the case where the screensaver pref points to a mode that isn't valid, such as a badly updated or newly disabled plugin. The improvement checks if the $saver is valid, then makes sure if it is valid, that we arent' already in that mode. The sanity check only needs to be in place to check against 'screensaver' mode if the $saver is not valid. comments included in the diff. Input welcome on possibly more efficient conditionals.
*** Bug 4415 has been marked as a duplicate of this bug. ***
I think the "cure" was worse than the disease. This used to work, and I experienced no problems. If there are bad plugins, they should be liable and responsible for fixing themselves. Don't penalize the rest of us. This is more than an enhancement. It is a regression, and needs fixing.
nothing has been regressed. My mention of the case to cover bad plugins has ALWAYS been there, but it is simply alawys been incomplete. A more recent fix to avoid another problem, has resulted in the revelation of this limitation that has been there since very early in the screenasaver support. please turn off rant mode.
James, since you are running SuSE, you can apply the patch yourself and at least confirm that this change does what you need it to do. edit /usr/local/slimserver/server/Slim/Buttons/ScreenSaver.pp, or download the attachment and apply with: patch -p0 < bug4351.diff then restart the server. If you can confirm it, then that will be one step closer to the ability to apply the patch. I'll at least change the severity.
That worked! I played a short album, and when it finished, it immediately jumped to my screensaver. Thanks. Sorry about the rant.
in trunk at change 10469 for the 7.0a1 nightly builds. James, this won't make it for the official 6.5.1, but the patch can bee applied to that if you upgrade.
Kevin - could this easily be applied to 6.5.x?
the patch should port directly.
It works quite nicely. I do not understand why it has not been applied.
Change 12239 for 6.5.x branch
This bug is being closed since it was resolved for a version which is now released! Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html If you are still seeing this bug, please re-open it and we will consider it for a future release.