Bugzilla – Bug 4174
add playlist as favorite option does not appear to exist in Default skin.
Last modified: 2009-09-08 09:15:19 UTC
SSIA
I don't believe there has ever been an 'add to favourites' in the web interface? enhancement?
so, question is... where should the "add this to favorites" link exist: each playlist item? Now playing? every browse list item? song info page? digital inputs list?
bug 2769 touches on this subject a bit as well.
I can't seem to find it in the Default skin in 6.3.1. Please let me know if we're crazy, Kevin!
We haven't added favorites to the web interface yet. Will do so for 7.0. Maybe we'd have a heart graphic that would have a tooltip of "Add to favorites" on the various pages. Need to think about this in the context of the web rerfresh.
Created attachment 2332 [details] rough mockup the blocks exist for this, but we need to support them in browsecontrols, set the favorites flag from browsedb and handle the http request to add with a given url/title, rather than just an index. mockup currently only adds playlists, still needs a way to refresh the page or update control images. delete will need to determine the favorite index for the url, or extend the delete command to work on a url
Michael: what do you think of this?
Will merge with some more playlist fixes.
This is not as simple as I hoped it would be. Why the heck is the favorites handler a plugin? There are so many special cases for it, and I'm pretty sure some functionality would break SC if a user actually disabled the plugin. Kevin - as you said your patch does only (un-)register a playlist as a favorite, but the change isn't reflected in the web UI. The problem is we don't have a handler for the favorites. Everything is hardcoded somewhere in xmlbrowser or the favorites plugin itself. If we want to make this compatible with non ajaxed skins, we'd have to add another handler in browsedb....
The favourites feature, like most extended features started with the intention of a simple way to do an annoying task - store a radio link for later. Then, as often happens, users want it to be available for everything everywhere. Much of the favourites handling is merged into server, but it also comes from the mypicks plugin later on in order to support the editing within an opml framework.
change 16012 - add a favorites button to all browsable items which have an url (playlists, artists, albums etc.) Please test! Thanks.
This bug is being closed since it was resolved for a version which is now released! Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html If you are still seeing this bug, please re-open it and we will consider it for a future release.