Bug 3906 - Sort By pulldown has no effect on sort order on lower levels
: Sort By pulldown has no effect on sort order on lower levels
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 6.5b1
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-08-10 11:13 UTC by Jim McAtee
Modified: 2008-12-15 11:58 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments
feed sort to lower levels (1.14 KB, patch)
2006-08-10 18:23 UTC, KDF
Details | Diff
log (3.56 KB, text/plain)
2006-08-11 10:20 UTC, Jim McAtee
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jim McAtee 2006-08-10 11:13:39 UTC
I'm not sure if this is a new bug, a symptom of bug 3882, or if it's just a work in progress.  The only place that the pulldown is changing the sort order is Browse Albums.  Under either artist > albums (through Browse Artists or Browse Genres) or year > albums (Browse Years) changing the pulldown reloads the page, but does nothing to the sort order.
Comment 1 KDF 2006-08-10 18:23:18 UTC
Created attachment 1411 [details]
feed sort to lower levels

This patch fixes the problem, but the comment in the code suggests this should not be done yet as other descend functions may not yet be ready to deal with this.
Comment 2 Chris Owens 2006-08-11 09:30:30 UTC
Dan, I sense that this is one of the class of bugs we were speaking of, which will go away as work continues on 6.5.  Shall I just leave it assigned to me and remind myself to test it again in a week or two?
Comment 3 Chris Owens 2006-08-11 09:54:56 UTC
Is this a dupe of bug 3882?
Comment 4 Jim McAtee 2006-08-11 10:20:25 UTC
Created attachment 1414 [details]
log

(In reply to comment #1)
> Created an attachment (id=1411) [edit]
> feed sort to lower levels
> This patch fixes the problem, but the comment in the code suggests this should
> not be done yet as other descend functions may not yet be ready to deal with
> this.

I'm afraid the patch caused a crash when the pulldown was changed.  See the attached log.
Comment 5 KDF 2006-08-13 01:07:14 UTC
Chris, 3882 is about the persistence of the setting.  going back to the top level currently resets to album sort every time.

this bug is about the levels below the top level, where the feature is not yet implemented.  Technically, neither is really a bug; it's those work in progress cases that fill up the changelog.
Comment 6 Chris Owens 2006-08-14 13:22:43 UTC
Roger that.  I will ignore "sort by" errors for now.
Comment 7 Chris Owens 2006-08-25 09:37:19 UTC
Ross, could you try to reproduce this with today's nightly, please?
Comment 8 Ross Levine 2006-08-28 18:09:30 UTC
This 'issue' is indeed still prevalent. All the options from this pull-down make no changes to the order. 

SlimServer Version: 6.5b1 - 9195 - Windows XP 
Comment 9 KDF 2006-08-28 20:17:18 UTC
The patch previously is the right fix for this specific issue.  However, as also mentioned, this causes a crash in many cases.  Unfortunately, that's outside my ability as far as working with the schema, so I'd have to rely on Dan to get the lewer levels ready to accept sort order.
Comment 10 Dan Sully 2006-09-10 15:49:36 UTC
Fixed in change 9574
Comment 11 Ross Levine 2006-09-11 17:29:59 UTC
Verified to be fixed in 6.5b2.
Comment 12 James Richardson 2008-12-15 11:58:11 UTC
This bug has been fixed in the latest release of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.