Bugzilla – Bug 3882
album sort order pulldown not persistent
Last modified: 2008-09-15 14:39:24 UTC
The new pulldown doesn't seem to stick on a full window refresh. I had it set to artist, year, album. On a refresh, it came up as "album" and the list is sorted by album name again. Also, when selecting the sort order, sometimes it is switching from gallery to list view at the same time.
gallery to list view issue fixed at change 8856
Should a cookie be used here?
that's one option. web/http.pm would have to feed an existing cookie through to TT the same way we do for artwork. I can probably get something working during a break today. the only part I'm unsure about is getting the pulldown to show the current state on load. I do that with the browse pulldown, but it's always painful.
fix is along the lines of: add to common.js at lnie 103: setCookie( 'SlimServer-orderBy', option ); add to Web/HTTP.pm around line 703: # Check for the album order cookie. if ($params->{'cookies'}->{'SlimServer-orderBy'} && $params->{'cookies'}->{'SlimServer-orderBy'}->value) { $params->{'orderBy'} = $params->{'cookies'}->{'SlimServer-orderBy'}->value unless defined $params->{'orderBy'}; } The only possible issue here is that orderBy is really only applicable on the album levels, so far. This has no affect currently on other levels, but if we were to introduce different order sets for different levels we would have a problem. There is no knowledge of the levelName in this part of the code.
Created attachment 1416 [details] full diff this is the full diff for above with changelog entry.
Ok, let's go ahead and do this, since I don't have a better suggestion.
done at change 9029