Bug 368 - "Group Discs" doesn't function
: "Group Discs" doesn't function
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Tagging
: 5.x or older
: PC Windows (legacy)
: P2 enhancement with 2 votes (vote)
: ---
Assigned To: Blackketter Dean
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-06-11 11:47 UTC by bill
Modified: 2008-12-18 11:51 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description bill 2004-06-11 11:47:18 UTC
SlimServer's Group Discs function states:

You can specify if multiple disc sets are treated as a single album (with a 
single name) or as multiple albums, each with a unique name per disc, for 
example "Album Title (Disc 2 of 3)". Changing this setting will start a rescan 
of your music library.

I have a Two Disc Set, Concrete Blonde's Live in Brazil ripped and compressed 
as individual mp3s. Each Disc lives in a seperate directory, structure as 
follows:
K:\NewMP3 - Music Root
K:\NewMP3\Concrete Blonde - Artist Directory
K:\NewMP3\Concrete Blonde\Live in Brazil (Disc 1 of 2) - Disc One Album 
Directory
K:\NewMP3\Concrete Blonde\Live in Brazil (Disc 2 of 2) - Disc Two Album 
Directory

All mp3s in Disc One have an Album Tag of "Live in Brazil (Disc 1 of 2)"
All mp3s in Disc Two have an Album Tag of "Live in Brazil (Disc 2 of 2)"
each mp3 has both V1 and V2 tags and the data is consistent between them. The 
artist tag is also populated for V1 and V2 and consistent between all files.

When the SlimServer's Group Discs setting is set to, "treat multi-disc sets as 
a single album", and then the cache is wiped, after reparsing, using Browse 
Artists, I find two Albums under Concrete Blonde "Live in Brazil (Disc 1 of 2)" 
and "Live in Brazil (Disc 2 of 2)", which tells me that at least SS thinks the 
artist is the same. Browsing by Album shows both albums as well.

I would EXPECT to find a single Album "Live in Brazil" (or Perhaps "Live in 
Brazil " which contained the songs ordered by album, then track. (Note that all 
V1 and V2 tags had track populated as well).

I have also altered the spelling from "Disc" to "Disk" in all tags/names and 
seen identical behavior.

I have other album sets that exhibit the same behavior. This behavior is seen 
most recently in the 2004-06-11 nightly build.
Comment 1 KDF 2004-06-14 14:28:22 UTC
I dont think the feature extracts the info from the album tag.  Does't is
require the SET tag to be filled in?
Comment 2 Blackketter Dean 2004-06-14 14:45:24 UTC
Yes, it uses the SET tag to obtain the group information.  Bill:  is this the problem you are seeing?  If 
not, could you please attach a couple of tracks that exhibit this problem?
Comment 3 bill 2004-06-14 15:00:37 UTC
Have looked over this and found a TPOS field which (I believe) indicates that a 
song is part of a set. My current tag editor doesn't support it. If someon can 
point me at one that does, I'll try that. Regardless, IMNSHO this needs to 
stand as a bug until the feature is defined/understood/documented/?fixed? or is 
removed from the server.
Comment 4 Blackketter Dean 2004-06-14 15:35:24 UTC
Right, that's the issue.  There's a specific tag for this that SlimServer uses, TPOS in ID3v.2.3 and TPA in 
ID3v2.2. 

iTunes supports it as do many other applications.  

We're not going to fix this for 5.2, but we will get to it after 5.2 is out the door.
Comment 5 bill 2004-06-14 16:58:06 UTC
Funny, I downloaded 5 taggers after my last addendum and none of them 
(including JJ, which I use often) support this tag. I don't use iTunes as it 
screws w/ my system a bit, and isn't very useful for batch editing tags. A 
batch tag editor recommendation would be appreciated.
Comment 6 KDF 2004-06-15 07:12:58 UTC
I've used Tag & Rename for mass tagging.  It doesn't support TPOS, however. 
Given that the server parses the TPOS, it might be simple enough to parse the
album tag to get the "DISC of DISCC" if it exists, and the multiple discs as one
album setting is chosen.
Comment 7 bill 2004-06-16 11:58:03 UTC
OK. Found a tagger that supports TPOS and tagged the files either 01/02 or 
02/02 as appropriate. Wiped the Cache and SlimServer still sees two albums, 
Live in Brazil (Disc 1 of 2) and Live in Brazil (Disc 2 of 2). The only place 
this nomenclature is used is in the directory name (never in any of the tags 
(that I can find)), so it's botching something even when these tags are set. 

I'm in agreement w/ KDF that this might be easier for users (especially non-
technical ones) if SS parsed out (away?) the set info from the album name. 
something like:

(.*)\s*\([Dd]is[ck]\s+(\d+)\s+of\s+(\d+)\)

(but I'm no RegEx guru....)
Comment 8 bill 2004-06-16 12:05:42 UTC
Correction! Had the Group Discs set incorrectly. Things work appropriately 
(including song order, which was another but) when tagged this way (in both 
settings).
Comment 9 KDF 2004-07-23 09:18:14 UTC
so, bill, would you consider this one closed?
Comment 10 bill 2004-09-24 07:29:55 UTC
Not really, as I've seen this question pop up on the forum at lease twice in 
the last few months. It either needs to be better documented, or the behavior 
changed to work from the title (which has its own problems).
Comment 11 KDF 2004-09-24 09:41:27 UTC
ok.  I think at this point it will wait for the new SQL backend for any new
methods of handling this.  The recent posts on teh list mentioned new ways, some
of which should be easy enough to implement once the SQL db is in place.
Comment 12 Peter Watkins 2004-09-30 12:17:58 UTC
*** Bug 597 has been marked as a duplicate of this bug. ***
Comment 13 Peter Watkins 2004-09-30 12:28:17 UTC
Please at least update the interface language. SETUP_GROUPDISCS_DESC (EN) in
strings.txt reads 

"You can specify if multiple disc sets are treated as a single album (with a
single name) or as multiple albums, each with a unique name per disc, for
example "Album Title (Disc 2 of 3)". Changing this setting will start a rescan
of your music library."

Especially when you consider that the "Multiple Items In Tags" feature does
parse the contents of my ID3v1 tags, the SETUP_GROUPDISCS_DESC language led me
to believe that SlimServer would parse Album tags for identifying multi-disc sets.

I would suggest clarification language, but I'm unsure what the behavior is.
Does SlimServer in certain circumstances add " (Disc M of N)" to the displayed
album name? Does it in certain circumstances (browsing albums? the now playing
display on the SB/web/slimp3 displays?) hide " (Disc M of N)"?

Given the limitations of ID3v1, I can understand why you might want to simply
require nice, clean TPA/TPOS data in ID3v2 tags, but it'd be nice if the
requirements & behavior were more clearly spelled out.

Thanks.


Comment 14 KDF 2004-09-30 13:55:10 UTC
This feature will be easier to implement once the SQL is in place.  The current
wording can be confusing, I agree.
Comment 15 Peter Watkins 2004-10-06 09:52:52 UTC
From what I understand, the SQL backend isn't supposed to be ready for 5.4.0
(http://lists.slimdevices.com/archives/developers/2004-September/010508.html),
and I would not expect this to be addressed in the first SQL release. With that
in mind, I'd like to suggest the following be added to the SETUP_GROUPDISCS_DESC
language in strings.txt to help clarify the requirements (until the behavior
changes):

This feature only works with MP3 files that use the ID3v2 "TPA" or "TPOS" tags;
it does not work with ID3v1 tags and does not use the ID3 "Album" tag to
associate groups of discs.
Comment 16 Caleb Epstein 2004-11-30 05:39:03 UTC
Regarding comment #15 (https://bugs-archive.lyrion.org/show_bug.cgi?id=368#c15), the
Group Discs feature also works with FLAC files having the "DISCNUMBER" tag.

I feel bad for having started this whole mess when I added this feature :-)
Comment 17 KDF 2004-12-14 12:39:07 UTC
try not to worry about it.  some users have a way of making people feel bad for
their hard work. I still believe its not generally intentional.
Comment 18 KDF 2005-11-03 20:04:45 UTC
This should be working as of svn 5015
use DISKNUMBER is flac files, DISC and DISCC for mp3.

if this is about parsing the album tags to extract from (1 of 3) etc, then this
could use  rewording of the summary.
Comment 19 Dan Sully 2006-05-06 09:22:16 UTC
This has long been fixed.
Comment 20 Chris Owens 2008-12-18 11:51:00 UTC
Routine bug db maintenance; removing old versions which cause confusion.  I apologize for the inconvenience.