Bug 3322 - Manually setting compilation status doesn't work
: Manually setting compilation status doesn't work
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Tagging
: 6.2.2
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-04-26 05:10 UTC by Nigel Birch
Modified: 2008-09-15 14:38 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nigel Birch 2006-04-26 05:10:11 UTC
This is with the v6.2.2 release candidate (SlimServer Version: 6.2.2 - 7135 - Windows XP - EN - cp1252 
).

If "List compilation albums under each artist" is set, and COMPILATION=1 (for FLAC) and TXXX ITUNESCOMPILATION=1 (for MP3) are in the tags for all tracks of an album, I'd expect that those albums about be treated as various artists albums (i.e. remove artists from Browse Artists & Browse Albums shows as "AlbumName by Various Artists" if "Show Artist with Albums" is enabled).  This doesn't a happen - the COMPILATION=1 comment is ignored and all artists are shows in Browse Artists and Browse Albums shows "AlbumName by Artist1, Artist2, etc.).

Similarly, if "Group compilation albums together" is set then setting COMPILATION=0 for an album doesn't defeat the various artists auto-detection logic.  This is useful where you have an album where tracks 1 - 4 are by Artist1, and tracks 5 - 8 are by Artist2.  Although strictly a VA album, it'd be better to treat it as a non-AV one since there's no that many artists there.  For example:

ALBUM=Triple Concerto & Double Concerto
ARTIST=Ludwig van Beethoven (Tracks 1 - 3)
ARTIST=Johannes Brahms (Tracks 4 - 6)

With "Group compilation albums together" set, albums like the one above get classed as various artists albums. If the changes in bug 2976 get committed (which they should, IMO) then various artists albums with identical titles will get merged.  Since titles like "Violin Concertos" are fairly common with classical music, it'd be best to have the ability to force them not be to a compilation.

"Various Artists" does appear under Browse Artists by its empty.  Also "Treat multi-disc sets as a single album" works for VA albums - meaning that the COMPILATION=1 is being read (I think COMPLILATION=1 is required for these).  All the above applies to both the player and web interface.

Thanks.
Comment 1 Blackketter Dean 2006-04-26 10:19:50 UTC
Dan: what do you think?
Comment 2 Dan Sully 2006-06-07 11:56:41 UTC
Nigel - I've commited a fix for recognizing explitly set COMPILATION=0 tags in change 7788

The change will be in the June 8th, 2006 nightly.

I've not seen any tracks with the 'TXXX ITUNESCOMPILATION=1' tag for MP3.

Can you please upload one of those to this bug?

Thanks.
Comment 3 Nigel Birch 2006-06-12 12:22:32 UTC
With SlimServer v6.3.0 (7895 - Windows XP - EN - cp1252), setting COMPILATION=0 in FLAC works just fine.  Thanks.

I've only got FLAC and MP3s to test it on, but will that setting work for any supported format that use a tag called COMPILATION, or just those that use Vorbis comments, or just FLAC (I'll update the wiki with this)?

Sorry, I've been confusing myself by thinking that the iTunes compilation frame (TCMP) was actually a text frame (TXXX) called "ITUNESCOMPILATION" with a value of "1".  I'd misread http://www.mp3tag.de/en/help/main_tags.html and also seen ITUNESCOMPILATION listed by Tag.exe (MP3Tag creates an APEv2 tag called ITUNESCOMPILATION as well as TCMP, and it's the APEv2 one that that Tag.exe lists).  So, ignore that part.

It wouldn't make sense supporting setting TCMP to "0" for MP3s anyway, since iTunes doesn't support it (I think it just removes the TCMP frame when you un-check the Compilation box, rather than setting it to 0 - just did a test of this).  Might be wrong on that.

The remaining problem I'm seeing is that group discs doesn't work for VA albums.  I'm not sure when it broke, so it might not be caused by this enhancement.  For example, browse albums shows "The Rebirth Of Cool 7 (1998) by Various Artists" twice - once for each disc.  Single artist albums get grouped okay, and so do VA albums that I've set COMPILATION=0 for (e.g. "The Clarinet In Concert (1988) by Felix Mendelssohn, Julius Rietz, Bernhard Crusell, Louis Spohr, Max Bruch, Gustaf Heinze, Etienne Sol�re ").  There's a few bugs open for similar symptoms, but non for v6.3.  Shall I create one for v6.3 or is there another bug I can add details to?  Thanks, again.
Comment 4 Nigel Birch 2006-06-12 13:00:48 UTC
Sorry - ignore the group dics/VA problem.  I'd removed the COMPILATION=1 comments from all multi-disc VA albums during testing.

Thanks for the enhancement.
Comment 5 Chris Owens 2006-06-12 16:54:20 UTC
Verified fixed in SlimServer Version: 6.3.0 - 7895 - Windows XP - EN - cp1252
Comment 6 Chris Owens 2006-06-27 14:21:46 UTC
This bug fix is now part of a released version, and so has been marked closed. If you are still experiencing this problem, please reopen the bug.