Bug 2976 - Albums with same name - tracks get merged
: Albums with same name - tracks get merged
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 6.2.1
: All Windows XP
: P2 normal (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-02-11 05:57 UTC by Jim Willsher
Modified: 2009-09-08 09:30 UTC (History)
0 users

See Also:
Category: ---


Attachments
Patch to remove Common Album Titles, and use contributor as a search criteria (7.05 KB, patch)
2006-04-24 19:53 UTC, Dan Sully
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Willsher 2006-02-11 05:57:53 UTC
I have two albums called "The Collection", one by Mary Black and one by Ultravox. If I use "Browse Albums" in the web interface I only get one occurrence of "The Collection". If I choose that item I then see my tracks merged:


Home / Browse Albums / The Collection   
 
 1 album with 28 songs by 2 artists.  
  
All Songs      
1. Dancing With Tears In My Eyes from The Collection by Ultravox      
1. The Moon And St. Christopher from The Collection by Mary Black      
2. Hymn from The Collection by Ultravox      
2. No Frontiers from The Collection by Mary Black      
3. Babes In The Wood from The Collection by Mary Black      
3. The Thin Wall from The Collection by Ultravox      
4. Carolina Rua from The Collection by Mary Black      
4. The Voice from The Collection by Ultravox      
5. Katie from The Collection by Mary Black      
5. Vienna from The Collection by Ultravox      
6. Columbus from The Collection by Mary Black      
6. Passing Strangers from The Collection by Ultravox      
7. Adam At The Window from The Collection by Mary Black  
 
etc. 


I'm runing 6.2.1+ (a January nightly) on Ubuntu with MySql as the database.
Comment 1 KDF 2006-02-11 12:19:30 UTC
server settings->behaviour, Common Album titles.

put the common titles in there and then the scan will separate albums by name AND the directory that they are in.
Comment 2 Jim Willsher 2006-02-13 13:47:47 UTC
Hmmm...not convinced. Yes "The Collection" is a common title, but surely Slim shouldn't be merging the two when I'm browsing by album, it should keep them separate.
Comment 3 KDF 2006-02-13 14:20:22 UTC
Common titles is a feature that allows you to specify album titles that you have which may be comme among more than one artist.  As such, that is EXACTLY what you have.  I have offered a suggestion to try, that should fix your issue. I suggest you at least try it. As many users claim to have some need to put songs from the same album all over the place, then the server db will merge ANY tracks using the same album name.  Common album titles is the preference used to specify which album titles should be restricted to one folder.  Thus, an album of the same name in a different location will be considered different.
Comment 4 Blackketter Dean 2006-04-22 22:01:32 UTC
Dan: is this a hard thing to fix for 6.2.2?  My "Greatest Hits" album has 178 tracks in it.
Comment 5 Dan Sully 2006-04-24 19:53:41 UTC
Created attachment 1198 [details]
Patch to remove Common Album Titles, and use contributor as a search criteria

Dean - please test this patch (against 6.2.2). It removes the "Common Albums Titles" hack, and if the album isn't explictly marked as a compilation - will use the primary contributor in addition to the album title as search criteria for determining if a new album object should be created, or an old one reused.

This should work for 99% of the users out there.

There is a drawback however - for albums that each track has a different primary contributor _AND_ the album is not explitly marked as a compilation (iTunes, Tag & Rename, metaflac) - a duplicate album will be created for each track in that album.

Instead of continuing to put in hacks and prefs that confuse users, I believe this is much more straightforward. The answer for the duplicate problem is "Tag those albums as compilations".

The drawback there is a VA album that has the same name as another VA album. I'm not sure how to get around that one. Suggestions welcome. But I think we have the common case fixed here.
Comment 6 Blackketter Dean 2006-04-25 10:25:30 UTC
not a showstopper
Comment 7 Dan Sully 2006-05-02 16:20:27 UTC
Fixed in change 7270 - will be in the next 6.3 nightly. Already in 6.5

You'll need to wipe & rescan.

Thanks
Comment 8 Chris Owens 2006-06-27 14:21:43 UTC
This bug fix is now part of a released version, and so has been marked closed. If you are still experiencing this problem, please reopen the bug.