Bug 2626 - option to show year with 'browse artists'
: option to show year with 'browse artists'
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 6.2.2
: PC Other
: P3 normal with 1 vote (vote)
: ---
Assigned To: Blackketter Dean
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-11-24 06:02 UTC by Greg Klanderman
Modified: 2008-09-15 14:37 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
show artist/year in any album context and not previously selected. (858 bytes, patch)
2005-11-24 10:27 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Klanderman 2005-11-24 06:02:02 UTC
I cannot reopen bug 739 so I am opening a new bug.

The bug was not fixed; the request was to show the year when browsing artists.
However, the year is only displayed when browsing by album, due to the code in
server/Slim/Buttons/BrowseDB.pm being surrounded by the condition "$level == 0", i.e.:

        } elsif (($levels[$level] eq 'album') && $level == 0) {
                my @name = &{$levelInfo->{'resultToName'}}($item);
                if (Slim::Utils::Prefs::get('showYear')) {
                        my $year = $item->year;
                        push @name, " ($year)" if $year;
                }

I believe this condition should be moved down into subsequent condition which checks the "showArtist" option, though even that may be questionable.
Comment 1 Greg Klanderman 2005-11-24 06:03:24 UTC
CC KDF since he made the fix for the original bug.
Comment 2 KDF 2005-11-24 10:27:17 UTC
Created attachment 1051 [details]
show artist/year in any album context and not previously selected.

The bug was fixed, but not kept the same when converting to browsedb.  The real solution here is to do the same as is done in the web interface (which is the same policy as before).  This means, show artit and year if pref is set for any album context where the artist or year is not already known (ie browse artist -> album = don't show artist)
Comment 3 Greg Klanderman 2005-11-24 20:06:11 UTC
Ah, yeah, that sounds even better.. thanks KDF
Comment 4 KDF 2005-11-25 09:09:47 UTC
committed to 6.5b1 builds at change 5305
awaiting word on whether this can go into 6.2.2 or not.
Comment 5 KDF 2006-02-09 00:40:36 UTC
looking at this, it IS more a feature add than a bug fix, so leaving this for 6.5 (given the last quoted timeline of March-ish, it wont be a long wait anyway)
Comment 6 Chris Owens 2006-06-16 14:41:48 UTC
There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.