Bug 739 - Request: option to show year with 'browse artists'
: Request: option to show year with 'browse artists'
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 5.x or older
: All All
: P5 enhancement with 2 votes (vote)
: ---
Assigned To: Vidur Apparao
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-12-18 19:12 UTC by Wim Melis
Modified: 2008-12-18 11:55 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
patch against 5.4.1 (1.73 KB, patch)
2005-01-11 14:15 UTC, Greg Klanderman
Details | Diff
patch against head of 6.0 branch (1.83 KB, patch)
2005-05-09 10:47 UTC, Greg Klanderman
Details | Diff
patch against 6.1, formatted same as web UI. (1.25 KB, patch)
2005-05-09 16:35 UTC, KDF
Details | Diff
slight rework (1.34 KB, patch)
2005-05-09 20:38 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wim Melis 2004-12-18 19:12:00 UTC
As title states: similar to the existing ability to show the year when browsing albums, it would be nice 
to also have that option when browsing by artist (as I always do).
Comment 1 KDF 2004-12-19 12:07:53 UTC
something for the SQL featureset.
Comment 2 KDF 2004-12-20 14:33:53 UTC
Actually, if you browse by artist, then descend to an album it DOES show the
year.  If you are asking to show year alongside artist, please let us know what
year you expect applies to an artist? 

The SQL would allow the eventual option of filtering by year, if that solves
your desire.
Comment 3 Wim Melis 2004-12-21 04:37:34 UTC
Ah, I wrote too quickly from the top of my head, sorry. 
What i meant was: the year is shown with the album in the Slimserver interface, but it's not shown in the 
Squeezebox display when doing the same browsing. It would be nice to see the same behavior on the 
Squeezebox.
Comment 4 Greg Klanderman 2005-01-11 06:42:07 UTC
I've got a small patch for this against 5.4.1 if anyone's interested.
I'd attach but the anonymous CVS seems to be broken right now so I
cannot do a "cvs diff".
Comment 5 Greg Klanderman 2005-01-11 14:15:14 UTC
Created attachment 250 [details]
patch against 5.4.1

here's a patch for this against 5.4.1.
Comment 6 Greg Klanderman 2005-05-09 10:47:54 UTC
Created attachment 506 [details]
patch against head of 6.0 branch

And here's a patch against the head of the 6.0 branch.
Comment 7 KDF 2005-05-09 12:22:40 UTC
Thanks greg.  BrowseID3 is actually deprecated as of 6.1 (next release), so it
would be worth patching against that instead. cvs isn't being used any more.
SlimServer is now accessible via subversion
Comment 8 KDF 2005-05-09 12:31:22 UTC
oh...server uses BrowseDB now (player and web ui)
Comment 9 Greg Klanderman 2005-05-09 12:55:48 UTC
OK, I've been using subversion, but hadn't realized the main trunk had diverged
much from 6.0.  How stable is it to run from there?  Is the server any faster?
I'll take a look at some point..
Comment 10 KDF 2005-05-09 14:14:32 UTC
brwosedb is faster.  6.1 is the trunk, 6.0.2/3 is the branch.  BrowseID3 still
exists in trunk ..well, I'm not totally sure why. If you have been using
subversion, then you should have the latest code, but I'm not sure how you
confirmed your fix with BrowseID3 :)
Comment 11 Greg Klanderman 2005-05-09 14:39:47 UTC
Right, I've been using subversion, but on the 6.0 branch with latest code there.
I can check out the trunk, I'm just not thrilled about running something unstable.
I don't know how stable you keep the trunk (6.1) code.
Comment 12 KDF 2005-05-09 16:35:43 UTC
Created attachment 507 [details]
patch against 6.1, formatted same as web UI.

ok, here is the similar thing done for browseDB.  displayed format is the same
as the web UI: $album ($year) by $artist.

I'll leave it for dan/vidur to decide if patching 6.0.x is useful at this time.
Comment 13 KDF 2005-05-09 20:38:53 UTC
Created attachment 509 [details]
slight rework

sorry, didn't cover the empty string case.
Comment 14 Greg Klanderman 2005-05-10 13:47:33 UTC
thanks!
Comment 15 Greg Klanderman 2005-05-10 13:55:32 UTC
hmm do you want the " (<year>)" before or after the " by <artist>"?
Comment 16 KDF 2005-05-10 14:01:40 UTC
currently, it should be after album, before artist.  thus matching the web UI. 
There is no preference for formatting order at this time (since this would
involve something just slightly less painful than a hot lead enema, ie a
duplicate of inforFormat() for albums)
Comment 17 KDF 2005-05-19 20:02:18 UTC
committed to 6.1 at change 3273

I tested attachment 506 [details] against 6.0.x branch, and i do see year in the browse
albums.  there is no showArtist pref in 6.0.x so that part is not applicable. 

As I am not sure whether this is appropriate for 6.0.x this late in the game,
I'll leave this open until vidur decides to patch using 506 or close this.  If
nothing happens before 6.1 is released, I'll close this on release.

Comment 18 Blackketter Dean 2005-06-07 13:22:45 UTC
Consider for 6.1, vidur?
Comment 19 KDF 2005-06-07 13:27:39 UTC
This has already been made part of 6.1.  The reason it is still open is the
submitted patch against 6.0.x
Comment 20 Blackketter Dean 2005-06-10 15:42:47 UTC
Fixed for 6.1, not going to do for 6.0.x
Comment 21 Chris Owens 2008-03-11 11:27:58 UTC
This bug was marked resolved in Slimserver 6.1, which is several versions ago.  If you're still seeing this bug, please re-open it.  Thanks!
Comment 22 Chris Owens 2008-12-18 11:55:44 UTC
Routine bug db maintenance; removing old versions which cause confusion.  I apologize for the inconvenience.