Bug 2312 - Make keepSlimServerInMemory() configurable
: Make keepSlimServerInMemory() configurable
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Audio
: 6.2.0
: PC Linux (other)
: P2 enhancement (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-10-18 02:44 UTC by Hakan Tandogan
Modified: 2011-03-16 04:39 UTC (History)
0 users

See Also:
Category: ---


Attachments
A possible implementation (946 bytes, patch)
2005-10-18 02:47 UTC, Hakan Tandogan
Details | Diff
A better implementation ;-) (1.26 KB, patch)
2005-10-18 04:52 UTC, Hakan Tandogan
Details | Diff
Patch with setup pref (3.62 KB, patch)
2005-10-18 13:09 UTC, Hakan Tandogan
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hakan Tandogan 2005-10-18 02:44:21 UTC
Change 4366 introduced a keepSlimServerInMemory task that gets periodically
called to keep the server process unswapped. (See bugs
https://bugs-archive.lyrion.org/show_bug.cgi?id=1934 and
https://bugs-archive.lyrion.org/show_bug.cgi?id=1470).

Please make this call configurable. Perhaps an parameter for the number of
minutes  after which to "wake up" the server, and, if this parameter is set to
"0" or "-1", disable this behaviour?


Regards,
Hakan
Comment 1 Hakan Tandogan 2005-10-18 02:47:34 UTC
Created attachment 917 [details]
A possible implementation
Comment 2 Hakan Tandogan 2005-10-18 04:52:41 UTC
Created attachment 918 [details]
A better implementation ;-)
Comment 3 Dan Sully 2005-10-18 09:02:08 UTC
Looking good - care to create a Setup pref for this?
Comment 4 Hakan Tandogan 2005-10-18 09:31:40 UTC
Setup pref in the Web interface? Would "Server Settings" / "Performance" be a
good place for this pref?

I'll try to add the pref later today.


Regards,
Hakan
Comment 5 Dan Sully 2005-10-18 09:34:26 UTC
Sounds good to me.
Comment 6 Hakan Tandogan 2005-10-18 13:09:03 UTC
Created attachment 919 [details]
Patch with setup pref

This patch adds a default value for the setting, an entry in the
setup/performance page and german translations for the descriptive strings.


Regards,
Hakan
Comment 7 Dan Sully 2005-10-18 13:24:12 UTC
Checked in as subversion change 4676

Thanks!
Comment 8 Mike Cappella 2005-10-18 13:54:30 UTC
This is a curious patch to me.  How does this routine keep the "server" in 
memory?  Swapping occurs at page granularity, not process granularity.  It seems 
to me that only the pages that hold the code path for executing the timer and 
callback function are being kept active.
Comment 9 Hakan Tandogan 2005-10-19 01:42:46 UTC
The start page is reloaded, which makes a database query. Basically, the memory
pages that hold the database access layer, the templating engine and the timer
are forced back into main memory.

Then again, the problem occured mostly on Windows, which has its own strange
quirks with virtual memory ;-)


Regards,
Hakan
Comment 10 Mike Cappella 2005-10-19 09:26:36 UTC
Thanks for the clarification.
Comment 11 Chris Owens 2006-06-16 14:42:35 UTC
There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.