Bugzilla – Bug 1913
Browsing by artist also lists tracks with artist as composer
Last modified: 2009-09-08 09:29:03 UTC
Originally described in https://bugs-archive.lyrion.org/show_bug.cgi?id=1877 When browsing Home / Browse Artists / Artist Name, as well as listing tracks by the artist, tracks by other artists are listed where the composer of these tracks is the same as the artist name. To reproduce the problem:- Set Composer to "A" in track "P" of artist "X" Set Composer to "B" in track "Q" of artist "Y" Set Composer to "C" in track "S" of artist "Z" Where "A", "B" and "C" are existing artist names in the music library. After a clear and rescan:- browsing artist "A" should list track "P" of artist "X" browsing artist "B" should list track "Q" of artist "Y" browsing artist "C" should list track "R" of artist "Z" in addition to tracks by the artist. This is with "Don't include composer, band and orchestra in artists" set under Server Settings / Behaviour. I don't think this is the correct behaviour - if the option "Don't include composer, band and orchestra in artists" is set then surely it shouldn't include ANY composer, but it appears to list tracks where the composer is the same as the artist.
Hi Mike: Are you saying that if this setting is configured to not include the composers in the artist list, then it should also hide artists that happen to be the same as composers?
I read it as tracks by Artist B with Composer A, will be listed under Artist A. Thus you have a combination of Tracks by Artist A and Tracks by Artist B, the latter seemingly included because composer of those tracks matches the Artist name instead of being a unique name.
Sorry for not describing the issue more clearly - KDF's interpretation is correct. When "Don't include composer..." is set and you browse "Artist A", you will see albums by "Artist A" and "Artist B" if there are tracks by "Artist B" with a composer of "Artist A". e.g. if you browsed the Ramones, you would see Ramones albums and some Pearl Jam albums because Pearl Jam have covered Ramones songs and the Ramones are listed as a composer in some Pearl Jam tracks. My interpretation of "Don't include composer..." is if this is set, and you browse "Artist A", then you should only see albums/tracks by "Artist A" irrespective of the composer field in other artist's tracks.
And just to clarify again... the desired behaviour is that when I browse "Artist A" I only see albums/tracks by "Artist A" if "Don't include composer..." is set.
I see, yep. That's a real bug.
Should this happen at the album level and the track level? Or just album? What about genre -> artist -> ?
I think that the items in the composer field should not appear in any list of artists at all. (If we have a browse or search by composer, only then would it appear.)
I agree with Dean. From my perspective, if "Don't include composer..." is set, then whatever is in the composer field shouldn't influence what you see when browsing. I believe what you see should be purely based on the tag data relevant to the available browsing options - album, artist, genre etc. Speaking purely selfishly, I have spent a lot of time sorting out the tag data in my music collection based upon the available browsing options in Slimserver (well, except for year which was added recently...) I haven't bothered sorting out the composer tags which have got all sorts of inconsistent stuff in them from CDDB or where ever. As long as "Don't include composer..." is set, I don't think whatever is in the composer tag should influence the browse results (and this includes having "Various Artists" in the composer tag which seems to include "Various Artists" when browsing by artist as mentioned on another thread with Dan :) ) Personally, I wouldn't use a browse by composer option but I'm sure some people would want it. There may be a risk of having two many browse by options. I quite like the approach in iTunes where you can enable or disable the fields you can sort by but the browsing options Slimserver supports at the moment are fine with me.
I've checked in what I think is a complete fix as subversion change 3923. Could you please test it out and let me know? Thanks.
Created attachment 712 [details] Composer Blank Slimserversql.db file with Artist = "Masters At Work", Composer = "" Artist is displayed when browsing by artist.
Created attachment 713 [details] Composer = Artist Slimserversql.db file with Artist = "Masters At Work", Composer = "Masters At Work" Artist is not displayed when browsing by artist.
I'll test the fix in the next nightly however I've come across another Artist/Composer issue that might be related. I can raise another bug report however have provided information as it may be relevant to the previous issue. I noticed that a particular artist was missing when browsing by artist however the artist's albums were present when browsing by album. The artist details were: Artist: Masters At Work Albums: Masters at Work In The House [Disc 1], [Disc 2], [Disc 3] (3 albums in total) Composer: Masters At Work I deleted Masters At Work from the Composer field and did a clear and rescan of the database. The artist was now displayed. I pointed the Slimserver music folder to the relevant albums to cut down on the time to do a rescan, collected the following information and attached the slimserversql.db files. 1. slimserversql1.db Artist = Masters At Work Composer = blank Artists were displayed correctly when browsing by artist. 2. slimserversql2.db Artist = Masters At Work Composer = Masters At Work Browsing by artist showed 3 albums with 35 songs by 0 artists and the artist was not displayed. Browsing by albums showed 3 albums with 35 songs by 0 artists and the 3 albums were displayed. Selecting the album showed 1 album with 15 songs by 1 artist (or the number of tracks for the other albums) Selecting a track showed the Composer as Masters At Work I'm not sure why this particular artist didn't display when browsing as there are other albums where the artist name and composer name are the same and they were displayed when browsing by artist.
Forgot to mention - "Don't include composer..." is set.
Please also see https://bugs-archive.lyrion.org/show_bug.cgi?id=1958 which also describes the problem where artists are missing if the composer and artist are the same. This looks like a different symptom of the same cause, where Slimserver is assigning the contributor role only based upon Composer rather than Artist.
I tried out the 2005-08-11 nightly. Browse "Artist A" no longer displays albums by "Artist B" containing tracks with composer "Artist A" however the album counts are wrong. The "Artist A" album count of "x albums with y songs by 1 artist" still includes albums by "Artist B" even though the "Artist B" albums are not displayed. I verified this by adding existing artist names to the composer field of a number of different tracks, cleared and rescanned the database. In each case the album count for the artist was the number of their own albums plus the other albums I had added the artist name as a composer. Several albums have the same name in artist and composer and the album counts are being double counted. e.g. the album count will say 4 albums with y songs by 1 artist when there are actually 2 albums. There is one specific album not being displayed where the composer and artist name are the same - information provided previously in this bug report. I believe this is the same issue as bug id 1958 and I'm guessing that the incorrect assignment of contributor roles is the root cause of both this bug and 1958. Unfortunately the issue I described in https://bugs-archive.lyrion.org/show_bug.cgi?id=1877 is back. One particular artist (Sin�ad O'Connor) is being displayed twice. I think this issue is related to Music Magic Mixer. With Music Magic Mixer off (no "m" icons when browsing), Sin�ad O'Connor is displayed twice and with MMM on ("m" icons beside tracks and albums) Sin�ad O'Connor is displayed once. It is possible this bug was never fully fixed as I almost always have MMM on.
Michael - can you try out the latest 6.2 nightly, and do a wipe & rescan? Thanks.
I tried the 2005-08-15 nightly and the Artist album count isn't correct yet. That is, if a track by "Artist A" has a composer of "Artist B", the album count for "Artist B" is the number of "Artist B" albums plus the "Artist A" album. I added existing artist names to the composer field of several tracks to verify this, cleared and rescanned, and in each case the album count for the artist name added was incorrect. When I deleted the artist names from the composer field, cleared and rescanned, the album count was correct again. The problem mentioned above with double counting of albums when the composer name and artist name are the same has been fixed.
Michael - there were some changes as of the 2005-08-16 nightly that might help with this - what's the current status on your end? Thanks.
Dan, I tried the 2005-08-24 nightly and the album count issue is still there. To verify this, I added artist names as the composer to a number of tracks, cleared and rescanned and in each case the album count was the artist's albums + the number of albums with tracks where I had added the artist as a composer. I deleted the artist names from the composer field, cleared and rescanned and the album count was correct again.
Large Various Artists / Multiple Artists in Tags update checked in as subversion change 4258.
Created attachment 819 [details] screen shot 1 incorrect album counts
Created attachment 820 [details] screen shot 2 incorrect album counts
I am still getting incorrect album and track counts when Browsing by Artist - see attached files for screen shots illustrating this. The album count is greater than the number of albums listed. The album count is the albums by the artist plus albums where the artist is a composer on one of the tracks. The track count is the tracks by the artist plus tracks where the artist is a composer. I believe the album and track counts are being calculated based on contributors of both artist and composer rather than just artist. In Home / Server Settings / Behavior the Composer is not checked.
I tried this out in 6.2b2 and I am still getting incorrect album counts when browsing to Home / Browse Artist / "Artist A" if "Artist A" is also a composer in another artist's tracks. The albums listed are correct - it only lists the albums by "Artist A" - but the number of albums in "x albums with y songs by 1 artist" is incorrect. The album count = the number of albums that have "Artist A" as artist PLUS the number of albums that have "Artist A" as a composer in a track. e.g. If I have 3 albums with Artist A as the artist name and there are 5 albums with Artist A as a composer name in one of the tracks, Browsing to Artist A will list the 3 albums by Artist A but will say 8 albums with y songs by 1 artist. Composer, Conductor or Band/Orchestra are not checked under "Composer, Band and Orchestra in Artists" under Home / Server Settings / Behavior
Fixed now in change 4747
seems fixed in 6.2 - thanks