Bug 17944 - Artwork doesn't work on streams from local network
: Artwork doesn't work on streams from local network
Status: RESOLVED WORKSFORME
Product: SqueezePlay
Classification: Unclassified
Component: Applet
: unspecified
: All Other
: -- normal with 2 votes (vote)
: ---
Assigned To: Unassigned bug - please assign me!
http://forums.slimdevices.com/showthr...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-05 07:44 UTC by pssc
Modified: 2016-03-10 08:14 UTC (History)
5 users (show)

See Also:
Category: Bug


Attachments
ImageSourceServer.lau.patch (1.41 KB, patch)
2012-04-05 07:44 UTC, pssc
Details | Diff
ImageSourceServer.patch Update 2 (1.40 KB, patch)
2012-04-05 08:01 UTC, pssc
Details | Diff
This patch includes fixes for the caption handling when it returns userdata (2.26 KB, patch)
2012-04-12 09:51 UTC, pssc
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description pssc 2012-04-05 07:44:19 UTC
Created attachment 7662 [details]
ImageSourceServer.lau.patch

patch to fix the fix The old bugs is closed and didn't reopen on comment...

Fixes for Fix

This fix breaks the facebook suff as facebooks image URL's are quite rightly
over https.... So should we... , fix for images with https ie facebook 
screensavers and a complete private networks list...

Patch with fixes...


+++ This bug was initially created as a clone of Bug #13937 +++

When I use Spotify through DSBridge its stream contains a reference to an
artwork url. The artwork is shown correctly in the Squeezebox Server web
interface but on the Controller I just get a blank image.

The image url in the web interface looks like this:
http://172.16.0.223:8124/cover/1252558053.png

By looking at the Squeezeplay code it seems like all http based artwork urls
are sent to SqueezeNetwork for resizing. This will of course not work in this
case since DSBridge runs on my local network behind a firewall so
SqueezeNetwork has no access to it.

There is a comment in the Squeezeplay code saying "Use the SN image resizer on
all remote URLs until SP can resize images with better quality" which I suppose
is related to this.

Would it be possible to do the rescaling on artwork urls that refers to the
local sub network internally in Squeezeplay and use SN for the rest ?

Or maybe try SqueezeNetwork first and if that doesn't work use Squeezeplay ? 

Or could the Squeezebox Server on the local network be used to do the resizing
for local streams ?
Comment 1 pssc 2012-04-05 08:01:45 UTC
Created attachment 7663 [details]
ImageSourceServer.patch Update 2 

2nd version should apply cleanly
Comment 2 pssc 2012-04-12 09:51:30 UTC
Created attachment 7664 [details]
This patch includes fixes for the caption handling when it returns userdata

Fixes for caption handling included this is now suitable for the PatchInstaller Applet ;-)