Bug 13937 - Artwork doesn't work on streams from local network
: Artwork doesn't work on streams from local network
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: Now Playing
: unspecified
: PC Other
: P1 normal with 1 vote (vote)
: 7.4.0
Assigned To: Andy Grundman
http://forums.slimdevices.com/showthr...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-09-10 00:34 UTC by Erland Isaksson
Modified: 2012-04-05 07:31 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments
patch to fix the fix (1.41 KB, patch)
2012-04-05 07:27 UTC, pssc
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erland Isaksson 2009-09-10 00:34:54 UTC
When I use Spotify through DSBridge its stream contains a reference to an artwork url. The artwork is shown correctly in the Squeezebox Server web interface but on the Controller I just get a blank image.

The image url in the web interface looks like this:
http://172.16.0.223:8124/cover/1252558053.png

By looking at the Squeezeplay code it seems like all http based artwork urls are sent to SqueezeNetwork for resizing. This will of course not work in this case since DSBridge runs on my local network behind a firewall so SqueezeNetwork has no access to it.

There is a comment in the Squeezeplay code saying "Use the SN image resizer on all remote URLs until SP can resize images with better quality" which I suppose is related to this.

Would it be possible to do the rescaling on artwork urls that refers to the local sub network internally in Squeezeplay and use SN for the rest ?

Or maybe try SqueezeNetwork first and if that doesn't work use Squeezeplay ? 

Or could the Squeezebox Server on the local network be used to do the resizing for local streams ?
Comment 1 SVN Bot 2009-09-18 13:11:33 UTC
 == Auto-comment from SVN commit #7658 to the jive repo by andy ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7658 ==

Fixed bug 13937, don't use imageproxy for private IP address URLs
Comment 2 James Richardson 2009-10-05 14:38:07 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 3 pssc 2012-04-05 07:27:45 UTC
Created attachment 7661 [details]
patch to fix the fix

Fixes for Fix

This fix breaks the facebook suff as facebooks image URL's are quite rightly
over https.... So should we... , fix for images with https ie facebook 
screensavers and a complete private networks list...

Patch with fixes...