Bugzilla – Bug 1770
Browse New Music - All Songs list errors
Last modified: 2008-08-18 10:54:16 UTC
From bug 1766, comment 1: Tracks are displayed as TRACKNUM. TITLE by without an artist listed. Seems this should be displayed the same as track listings in other browse modes TRACKNUM. TITLE from ALBUM by ARTIST Second, clicking a track name brings you to a page with a single link showing the track's album. I would assume this should take you to the detailed track information page. Third, clicking that album link brings you to a page displaying two links: "Play this song" and "Add this song to the playlist". Clicking these links will play (or enqueu) the entire New Music "All Songs" list of tracks.
Thsi seems to be due to bizarre heirarchy. new music is "age,track", but browsedb is doing a push of 'albums' onto @levels for some unknown reason. This results in all_songs being "track, album" instead of just "track". this patch changes the heirarchy to track, and seems to work. --- Slim/Web/Pages.pm.old 2005-07-06 12:11:46.421875000 -0700 +++ Slim/Web/Pages.pm 2005-07-06 12:11:31.640625000 -0700 @@ -1647,9 +1647,9 @@ sub browsedb { # XXX - is this the right thing to do? # For artwork browsing - we want to display the album. - if (my $transform = $info->{'nameTransform'}) { - push @levels, $transform; - } + #if (my $transform = $info->{'nameTransform'}) { + # push @levels, $transform; + #} # If we don't have this check, we'll create a massive query # for each level in the hierarchy, even though it's not needed The problem is, WHY is that push needed? Commenting it out, I expected from the comments that there would be a problem with artwork, and it seems ok.
Created attachment 604 [details] updated patch ok, this should now list tracks properly, including the removal of the No Artist, No Album as always. an extra semi-colon removed. I'm still trying to locate the reason for the push that I've commented out. Will have to make sure that doesn't affect anything, or that whatever it is can be fixed.
right, the commented out bit of code breaks the pwd for browse artwork when you descend. I think I get what I was not liking about nameTransform earlier. In some cases it needs to apply, others not.
Created attachment 605 [details] add 'descendTransform' param ok, so artwork needs to push levels for the pwd to work. new music needs to keep the hierarchy intact for the 'all songs' link. to do this we stick with the old code, but add a new param for %fieldinfo, called 'descendTransform'. If this exists, the server can override the heirarchy for the allTitle links, if needed. It seems to work, giving the right title, pwd, and itemlists for both cases. hopefully someone else has time to test this just to make sure I haven't missed anything.
committed to trunk at change 3647
This bug was marked resolved in Slimserver 6.1, which is several versions ago. If you're still seeing this bug, please re-open it. Thanks!