Bugzilla – Bug 1766
New Music -> All Songs shows wrong songs
Last modified: 2009-09-08 09:26:31 UTC
Browsing New Music -> All Songs shows everything in the library and takes minutes to complete.
Additional broken behavior of New Music -> All Songs. Tracks are displayed as TRACKNUM. TITLE by without an artist listed. Seems this should be displayed the same as track listings in other browse modes TRACKNUM. TITLE from ALBUM by ARTIST Second, clicking a track name brings you to a page with a single link showing the track's album. I would assume this should take you to the detailed track information page. Third, clicking that album link brings you to a page displaying two links: "Play this song" and "Add this song to the playlist". Clicking these links will play (or enqueu) the entire New Music "All Songs" list of tracks.
please file these as individual bugs so they can be tracked separately, and are more easily searchable by summary
actually, J, the all three issues in comment 1 look like they are the same cause (heirarchy=track,album, instead of just track). Probably makes sense to just make all three into one new bug. There are few more issues that are closely related to that, which I'll tack into the new bug.
*** Bug 1807 has been marked as a duplicate of this bug. ***
The trick here is that the "new music" listing is just doing a find on albums, using the 'age' sort order, and a limit on the number of items displayed. The find still refers to a complete list, thus the 'all' option drops into all songs, rather than a new find based on the listed albums. the same applies for the 'play all' from web OR player, the list of songs is a find for all albums.
I've got a working idea that makes use of a listref param in the url. The listref is stored temporarily as a client->param (same way we do musicmagic mixes). The listref is a hash linking types and the list of that type (ie 'album' => [437,23,458], for a list of albums). The only thing missing now is a way to tell when the list has been limited. For new albums, the 'find' key takes care of the sorting by age, and limiting the number of items returned. Any suggestions on how to detect this?
Created attachment 649 [details] the story so far This uses the album list to create a listref. When this exists, the song list is limited to those albums. Right now, this gets into all album lists, which isn't ideal. It is only of benefit when the album lis is filtered (a full find on all songs is faster than a find all songs for all albums). I still need a way to detect if the $limit param has been used on the album find (as done for new music). hopefully this stuff will be of use if anyone is trying to do this, or someone can offer any ideas on how to complete this.
Pushing this off to post 6.1
it's much faster now, but still shows all songs. First step is to show all tracks where age < threshold. sorting is a bonus.
Fixed! Subversion change 4627 and change 4640
This doesn't seem to work correctly in 6.5.1, I get completely the wrong list of songs. Running latest 6.5.1 on Mandrake linux.
Yes, it's broken in the trunk as well. I get every track in the library, sorted by album name, disc number, track number.
I understand this link has been removed, which in some sense is a fix.
This bug is being closed since it was resolved for a version which is now released! Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html If you are still seeing this bug, please re-open it and we will consider it for a future release.