Bug 1719 - Playlist edit or overwrite crashes slimserver
: Playlist edit or overwrite crashes slimserver
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Playlists
: 6.1.0
: All RedHat Linux
: P2 major (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-06-26 01:18 UTC by Patrick Dixon
Modified: 2008-08-18 10:54 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Dixon 2005-06-26 01:18:45 UTC
FC3/SB2/6.1 svn 3554

slimserver.log ends with:

Argument "61b1" isn't numeric in numeric gt (>) at
/usr/local/slimserver//Plugins/Alien/Plugin.pm line 541.
Can't locate object method "path" via package
"Class::DBI::Object::Has::Been::Deleted" at
/usr/local/slimserver//Slim/Web/EditPlaylist.pm line 242.
Argument "61b1" isn't numeric in numeric gt (>) at
/usr/local/slimserver//Plugins/Alien/Plugin.pm line 541.
2005-06-25 20:21:25.3619 Could not open /PlayLists/Untitled two.m3u for writing.
Use of uninitialized value in join or string at
/usr/local/slimserver/CPAN/Class/DBI.pm line 726.
Slim::DataStores::DBI::Track->retrieve() parameters don't include defined values
for all primary key columns (id) at
/usr/local/slimserver//Slim/DataStores/DBI/DBIStore.pm line 167
Comment 1 KDF 2005-06-26 02:52:39 UTC
please give more details as to steps leading up to this.  Saving a playlist was
tested during the branch and does appear to work.  this log looks like you are
trying to save an object that no longer exists.
Comment 2 Patrick Dixon 2005-06-26 03:58:52 UTC
Playlists are on a Win XP share, slimserver is FC3.

It's a bug in itself that slimserver crashes when editing a cached playlist that
it can no longer find - it should fail gracefully eg if a NAS share is
temporarily unavailable.  However, I have also created a Playlist called
"Untitled two" which does exist.  I then edit it, deleting a song and then
clicking the "Add" button - whereupon slimserver crashes.  It's completely
repeatable for me!

Strangly, the log is also full of files that can't be found, even though I can
browse the songs with slimserver OK and they are only some of the entries in the
directory tree.

slimserver.log tail:

[/Music/Music3/Various/Soul Searching (Disc 2)/01-Arethra Franklin-(You Make Me
Feel Like) A Natural Woman.flac] does not exist or cannot be read: No such file
or directory at /usr/local/slimserver/CPAN/Audio/FLAC/Header.pm line 59,
<GEN338> line 3.
[/Music/Music3/Various/Soul Searching (Disc 2)/12-Willam Bell & Judy
Clay-Private Number.flac] does not exist or cannot be read: No such file or
directory at /usr/local/slimserver/CPAN/Audio/FLAC/Header.pm line 59, <GEN338>
line 25.
[/Music/Music3/Walter Becker/11 Tracks Of Whack/01-Becker, Walter-Down In The
Bottom.flac] does not exist or cannot be read: No such file or directory at
/usr/local/slimserver/CPAN/Audio/FLAC/Header.pm line 59, <GEN341> line 3.
[/Music/Music3/Walter Becker/11 Tracks Of Whack/02-Becker, Walter-Junkie
Girl.flac] does not exist or cannot be read: No such file or directory at
/usr/local/slimserver/CPAN/Audio/FLAC/Header.pm line 59, <GEN341> line 5.
[/Music/Music3/Walter Becker/11 Tracks Of Whack/03-Becker, Walter-Surf And,Or
Die.flac] does not exist or cannot be read: No such file or directory at
/usr/local/slimserver/CPAN/Audio/FLAC/Header.pm line 59, <GEN341> line 7.
[/Music/Music3/Walter Becker/11 Tracks Of Whack/04-Becker, Walter-Book Of
Liars.flac] does not exist or cannot be read: No such file or directory at
/usr/local/slimserver/CPAN/Audio/FLAC/Header.pm line 59, <GEN341> line 9.
[/Music/Music3/Walter Becker/11 Tracks Of Whack/05-Becker, Walter-Lucky
Henry.flac] does not exist or cannot be read: No such file or directory at
/usr/local/slimserver/CPAN/Audio/FLAC/Header.pm line 59, <GEN341> line 11.
[/Music/Music3/Walter Becker/11 Tracks Of Whack/06-Becker, Walter-Hard Up
Case.flac] does not exist or cannot be read: No such file or directory at
/usr/local/slimserver/CPAN/Audio/FLAC/Header.pm line 59, <GEN341> line 13.
[/Music/Music3/Walter Becker/11 Tracks Of Whack/07-Becker,
Walter-Cringemaker.flac] does not exist or cannot be read: No such file or
directory at /usr/local/slimserver/CPAN/Audio/FLAC/Header.pm line 59, <GEN341>
line 15.
[/Music/Music3/Walter Becker/11 Tracks Of Whack/08-Becker,
Walter-Girlfriend.flac] does not exist or cannot be read: No such file or
directory at /usr/local/slimserver/CPAN/Audio/FLAC/Header.pm line 59, <GEN341>
line 17.
[/Music/Music3/Walter Becker/11 Tracks Of Whack/09-Becker, Walter-My
Waterloo.flac] does not exist or cannot be read: No such file or directory at
/usr/local/slimserver/CPAN/Audio/FLAC/Header.pm line 59, <GEN341> line 19.
[/Music/Music3/Walter Becker/11 Tracks Of Whack/10-Becker, Walter-This Moody
Bastard.flac] does not exist or cannot be read: No such file or directory at
/usr/local/slimserver/CPAN/Audio/FLAC/Header.pm line 59, <GEN341> line 21.
[/Music/Music3/Walter Becker/11 Tracks Of Whack/11-Becker, Walter-Hat Too
Flat.flac] does not exist or cannot be read: No such file or directory at
/usr/local/slimserver/CPAN/Audio/FLAC/Header.pm line 59, <GEN341> line 23.
[/Music/Music3/Walter Becker/11 Tracks Of Whack/12-Becker, Walter-Little
Kawai.flac] does not exist or cannot be read: No such file or directory at
/usr/local/slimserver/CPAN/Audio/FLAC/Header.pm line 59, <GEN341> line 25.
Argument "61b1" isn't numeric in numeric gt (>) at
/usr/local/slimserver//Plugins/Alien/Plugin.pm line 541.
Can't locate object method "path" via package
"Class::DBI::Object::Has::Been::Deleted" at
/usr/local/slimserver//Slim/Web/EditPlaylist.pm line 242.
Argument "61b1" isn't numeric in numeric gt (>) at
/usr/local/slimserver//Plugins/Alien/Plugin.pm line 541.
2005-06-25 20:21:25.3619 Could not open /PlayLists/Untitled two.m3u for writing.
Use of uninitialized value in join or string at
/usr/local/slimserver/CPAN/Class/DBI.pm line 726.
Slim::DataStores::DBI::Track->retrieve() parameters don't include defined values
for all primary key columns (id) at
/usr/local/slimserver//Slim/DataStores/DBI/DBIStore.pm line 167
Argument "61b1" isn't numeric in numeric gt (>) at
/usr/local/slimserver//Plugins/Alien/Plugin.pm line 541.
Use of uninitialized value in join or string at
/usr/local/slimserver/CPAN/Class/DBI.pm line 726.
Slim::DataStores::DBI::Track->retrieve() parameters don't include defined values
for all primary key columns (id) at
/usr/local/slimserver//Slim/DataStores/DBI/DBIStore.pm line 167
Argument "61b1" isn't numeric in numeric gt (>) at
/usr/local/slimserver//Plugins/Alien/Plugin.pm line 541.
Slim::DataStores::DBI::Track->retrieve() parameters don't include defined values
for all primary key columns (id) at
/usr/local/slimserver//Slim/DataStores/DBI/DBIStore.pm line 167

HTH
Comment 3 Vidur Apparao 2005-06-30 14:03:02 UTC
Dan to look at, since he believes he fixed it.
Comment 4 Dan Sully 2005-07-05 16:45:30 UTC
Patrick - does this happen any time, or only when the NAS drive has gone away?
Comment 5 Patrick Dixon 2005-07-06 00:15:04 UTC
The edit crash happens any/every time.  The overwrite crash may have been as a
result of left-over Playlists with '%20' in place of spaces.

I can also reproduce bug 1744 consistently, and they both give the same error log.
Comment 6 KDF 2005-07-06 00:57:53 UTC
1744 should now be fixed.  if you update to nightly...should be building in
about an hour...and do a rescan w/ clearing of library, that should clear up old
data and you can see if anything is still going wrong.
Comment 7 Patrick Dixon 2005-07-06 03:24:53 UTC
I'm still seeing problems in r3625 - has the fix for 1744 been checked in to
this revision?
Comment 8 KDF 2005-07-06 19:42:31 UTC
it went in at 3623, so yes.

Haw were you creating this playlist?  there may be some methods still not using
the db. How is this related to Alien BBC?
Comment 9 Patrick Dixon 2005-07-07 00:50:06 UTC
The Playlist was created by saving the current playlist (I'm using Fishbone).  I
just called it "Untitled two"

It's the same whether or not it includes AlienBBC items - the one I'm testing
this on at the moment, doesn't.

Using the Fishbone interface, I

Browse Playlists
Select the Playlist by clicking on it
Click on "Edit Playlist"
Now if I click on "Edit Playlist/" or "Add" the server crashes

It happen every time.

PS Once in the "Edit Playlist" page, there doesn't appear to be any way to get
back to the previous menu (other than the browser back button)
Comment 10 KDF 2005-07-07 01:11:58 UTC
right...found it.
committed to trunk at change 3364.
mere minutes too late for the july 7 build.  fortunately its an html fix so it
can be done even on windows.

Fishbone/edit_playlist.html, line 36 changes to:
 <input type="hidden" name="id" value="[% playlist.id %]">

instead of the old dir references.
Comment 11 Patrick Dixon 2005-07-07 05:33:57 UTC
On 3636

"Add" seems cured, but "Edit Playlist" still kills it.
Comment 12 KDF 2005-07-07 08:57:05 UTC
er, how do you get to ADD if edit playlist has already killed it?
I can't reprodce that one.
Comment 13 KDF 2005-07-07 09:28:51 UTC
ok, the pwd links.  will have to fix those later.

line 9 and 10 become this:
    [% "EDIT_PLAYLIST" | string %] / <a href="browsedb.html?player=[% player |
uri %]&hierarchy=playlist,playlistTrack&level=1&playlist=[% playlist.id %]">[%
playlist.title %]</a>
Comment 14 KDF 2005-07-07 18:55:43 UTC
ok, change 3645 should cover it.  re-open if there is anything new.
Comment 15 Chris Owens 2008-03-11 11:28:24 UTC
This bug was marked resolved in Slimserver 6.1, which is several versions ago.  If you're still seeing this bug, please re-open it.  Thanks!