Bugzilla – Bug 1744
Edit Zapped Songs playlist crashes Slimserver
Last modified: 2008-08-18 10:54:16 UTC
I zapped a track that I was playing last week. I just tried to browse the zapped playlist via SlimServer Version: 6.1b1 - trunk - Windows XP - EN - cp1252. The track I zapped was listed twice (maybe I somehow zapped it twice?). When I click "Edit Playlist", I can see the title and URL fields (title is blank, but I guess that's because Zapped Songs is special), and then below that, there are two rows of up-arrow, down-arrow and remove from playlist icons, but no text - just the icons. I guess something is wrong here, but I've hardly ever used edit playlist before, and can't remember what it used to be like. Also, when I'm on the "Edit Playlist" page for the "zapped songs" playlist, the browse path line only contains "Edit Playlist /". If I click Edit Playlist link from here, the server crashes with the following in the event log: Slim::DataStores::DBI::Track->retrieve() parameters don't include defined values for all primary key columns (id) at /PerlApp/Slim/DataStores/DBI/DBIStore.pm line 167 I guess this is related to the zapped songs playlist not having a title?
the zap function was not using the new db commands for dealing with playlists. I only started testing after a full scan, so I alreayd had a zapped.m3u in my db. However, I'll attach a patch shortly that writes to the db instead, and lets the db write out to file in its own time. This should avoid the crash.
Created attachment 599 [details] write zapped to db write to the db instead of a file and let the db handling deal with writing to file.
committed to trunk at change 3623. please confirm, reopen if issues remain.
This bug was marked resolved in Slimserver 6.1, which is several versions ago. If you're still seeing this bug, please re-open it. Thanks!