Bug 1716 - Artist and album names have url style escaping
: Artist and album names have url style escaping
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Database
: 6.1.0
: PC Windows XP
: P2 normal with 1 vote (vote)
: ---
Assigned To: Dan Sully
:
Depends on:
Blocks: 1717
  Show dependency treegraph
 
Reported: 2005-06-25 16:51 UTC by Jim McAtee
Modified: 2008-08-18 10:54 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
Typical m3u (148 bytes, text/plain)
2005-06-25 19:14 UTC, Jim McAtee
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jim McAtee 2005-06-25 16:51:05 UTC
The Windows compiled EXE was doing the same, but I'm now running the Perl 
version.  Using Subversion, I have the latest SlimServer rev 3559.  Most artist 
and album names appear twice in the data and in most browse modes - once 
without and once with URL style special characters.  Items with leading 
articles are not repeated.  The data _is_ in the database, not just the browse 
views, although the duplicate items are not seen in Browse Music Folder or 
Browse Years.  In Browse Genres the special characters dupes are only seen 
under 'All Artists' and 'No Genre'.
Comment 1 Dan Sully 2005-06-25 17:01:57 UTC
Are you using Music Magic, MoodLogic or iTunes?

Comment 2 Jim McAtee 2005-06-25 17:08:52 UTC
No.  In fact, these plugins are disabled.
Comment 3 Dan Sully 2005-06-25 18:26:14 UTC
Could you attach your slimserver.db file to this bug?

Do you remember when this behavior started happening?
Comment 4 Jim McAtee 2005-06-25 19:03:10 UTC
After the merge.

Since the major work in the branch had to do with playlists, let me see what 
happens if I delete all the m3u files that I have stored in each album 
directory.  They're easily regenerated by a script.  I'll post back...
Comment 5 Jim McAtee 2005-06-25 19:14:34 UTC
Created attachment 575 [details]
Typical m3u

That was it.  Apparently the problem has to do with the m3u files in the album
directories.  Both bug #1716 and bug #1717 were cleared up by deleting the
m3u's.	FWIW, I've attached one.
Comment 6 Dan Sully 2005-06-25 19:28:04 UTC
Ok - that's good to hear, Jim.

If you could - what's the logic behind having the m3u's per album? For something other than SlimServer?

Obviously I'd like to get this back to the previous behavior, but i need a little background.

Should we just be ignoring non-cuesheet playlists inside the audiodir, but not playlistdir?

Thanks
Comment 7 Jim McAtee 2005-06-25 20:14:35 UTC
> If you could - what's the logic behind having the m3u's per album? For 
> something other than SlimServer?

Yes.  I was generating them for album playback with Winamp or other PC-based 
audio playback software to give me one click ability to queue up an album.

> Obviously I'd like to get this back to the previous behavior, but i need a
> little background.
> 
> Should we just be ignoring non-cuesheet playlists inside the audiodir, but
> not playlistdir?

I'm not sure if that's necessary (or desirable).  Other than these playlists, I 
don't use playlists much, so I'm not sure of the problems that might cause 
other people.  The problems seem to stem from incorrectly putting together the 
paths to the files being referenced by the playlist.  I assume that if a 
playlist references a track already in the database (based on its full path) 
then it shouldn't be added again.  The paths in Bug 1717 show that the full 
paths to the playlist referenced files aren't be constructed correctly, maybe 
because of the relative paths used in the m3u files.  This bug is seemingly 
from not reversing the special characters in album and contributor names, 
apparently happening at the same time those tracks are incorrectly added for 
the second time.  If both of those problems (Windows only?) can be fixed, then 
there shouldn't be an issue reading playlists in audiodir.
Comment 8 Vidur Apparao 2005-06-30 13:59:57 UTC
Dan is working on this one for 6.1.
Comment 9 KDF 2005-07-09 20:29:25 UTC
possible fix for 1717 in svn.  try next build and see how the results here might
change.
Comment 10 KDF 2005-07-09 23:21:29 UTC
note: it seems the use of simple splitdir/catdir would maintain url escaping,
while using pathFromFileURL, and fileURLFromPath to wrap them would deal with
escaping nicely.  change 3662 goes back to the old method, using that wrapper
(pre change 3427), so the nightly build should now clear this up.
Comment 11 Jim McAtee 2005-07-10 13:20:34 UTC
I believe that's got it.  Updated to r3662, recreated all the m3u files within 
the music directory tree, then did a wipe/rescan.  Everything in the database 
looks good - no URL escaping and no invalid paths (bug 1717).  Thanks.
Comment 12 Dan Sully 2005-07-10 14:12:01 UTC
Thanks KDF
Comment 13 Chris Owens 2008-03-11 11:28:23 UTC
This bug was marked resolved in Slimserver 6.1, which is several versions ago.  If you're still seeing this bug, please re-open it.  Thanks!