Bugzilla – Bug 1688
Need a "Do Nothing" screensaver
Last modified: 2008-12-15 12:14:02 UTC
There used to be a non-screensaver that would just dim the display when there wasn't any music playing. That seems to have disappeared. We should add it back in as an explicit screensaver that does nothing. Let's make that the default when we're not playing.
there was? must have been before my time. if you are referring to the auto dim, its still there. It depends on the setting to adjusting brightness manually, and the setting for idle brightness. however, a completely blank screensaver should be easy enough. would be useful to link it with the request to power off the display when off (so you dont have that glow at the sides during the screensaver)
Sorry, I wasn't clear. The "screensaver" i'm talking about would appear to do nothing, i.e. leave the screen exactly as it was, but potentially dim. (I'm not talking about a blanking screensaver.) This would be the default if we weren't playing. It's pretty weird to have the player jump to "Now Playing/Nothing" if you walk away from the player.
this was replaced with the 'idlesaver' setting. given that there is no 'do nothing', I think the default must be now playing. maybe this setting is best done with a default left undef, so that in the absence of a setting, we should get the old behaviour. assign to me if that sounds right
I'm not sure if the setting should be undef, but it definitely appear as a choice in both the player and web settings. (actually, undef is probably not right either, so we can change the default behavior by changing a default setting) wanna take a crack at this?
right now, there is the now playing and jump back screensavers that are registered by the core code. I'll just add a 'none' screensaver setting and this will cause Screensaver::screensaver() to leave the mode unchanged aside from dimming to the idleBrightness setting.
Thanks!
Created attachment 555 [details] register 'nosaver' screensaver registers a 'nosaver' screensaver that has no functions or mode. The screensaver routine checks for 'nosaver' and skips the mode change section, leaving only the dimming of the display.
Looks good. (Let's just call it "None" without the parenthetical.) Thanks!
KDF: when you commit this can you make this a SN bug so we remember to merge over the change? Thx.
committed to trunk at change 3453. still needs to be merged with SqueezeNetwork
Dan is merging in KDF's change as we speak. Will be visible in the next SqueezeNetwork pushout.
This bug has been fixed in the latest release of SqueezeNetwork! If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.