Bug 16552 - Beta 7.6.0 R9113 Stops local USB playback without network attached
: Beta 7.6.0 R9113 Stops local USB playback without network attached
Status: CLOSED FIXED
Product: SB Touch
Classification: Unclassified
Component: TinySC
: unspecified
: PC Windows 7
: P3 critical with 5 votes (vote)
: 7.6.0
Assigned To: Felix Mueller
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-09-16 10:41 UTC by touchproblems
Modified: 2011-05-02 09:06 UTC (History)
6 users (show)

See Also:
Category: ---


Attachments
.mov video of problem steps (16.07 MB, video/quicktime)
2010-09-16 10:41 UTC, touchproblems
Details
Possible patch - check if Fab4 and TinySC running (803 bytes, patch)
2010-09-17 08:38 UTC, Felix Mueller
Details | Diff
updated patch to not push diags window on screen when tinySC is running (3.26 KB, patch)
2010-09-20 12:02 UTC, Ben Klaas
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description touchproblems 2010-09-16 10:41:10 UTC
Created attachment 6968 [details]
.mov video of problem steps

After installing this beta nightly build onto my touch, i cannout playback any
music from USB or SD card unless the network cable is plugged in and connected
to another device. If i try to select music from my local USB drive plugged
directly into the back of the touch, it tells me there is a problem with my
network connection. And there is no skip network option. There should be an
option to complelety disable network and not ask, if you are only using local
sources or at the very least "a skip network" option.

I have attached a video of problem steps
Comment 1 touchproblems 2010-09-16 11:09:46 UTC
Sorry about the large video size (16mb) only realized after i clicked commit :-(
Comment 2 touchproblems 2010-09-17 05:58:45 UTC
Also happening in R9120. Please can someone look into, as this seems a fairly major bug for people using USB and no network
Comment 3 Alan Young 2010-09-17 07:31:18 UTC
Downgrading from blocker to normal as networkless-working is not officially supported.
Comment 4 touchproblems 2010-09-17 08:02:12 UTC
Sorry is that actually an official statement, because i thought the whole point of having a USB port and tinysc was to allow networkless music, Whats the point of allowing local music playback if you need a network cable attached, that is just illogical. Im glad i found this out before my 10 days return period is up!!What a dissapointment
Comment 5 Felix Mueller 2010-09-17 08:38:16 UTC
Created attachment 6974 [details]
Possible patch - check if Fab4 and TinySC running

Patch most likely needs more refinement.
Comment 6 George 2010-09-17 10:27:32 UTC
*** This bug has been confirmed by popular vote. ***
Comment 7 Jim McAtee 2010-09-17 11:26:35 UTC
See bug 14086 and bug 14974 and bug 15192 (same) and bug 15633.  This and related bugs have been thought to have been fixed many times to date.
Comment 8 Jim McAtee 2010-09-17 13:19:38 UTC
(In reply to comment #3)
> networkless-working is not officially supported

Any chance that somebody could at least create a test in the firmware verification routine to make sure this doesn't keep happening?
Comment 9 touchproblems 2010-09-20 07:17:07 UTC
Dont know how this bug patching works but if you have added it in R1920 it didnt fix it. Any ideas how long this may take to implement. Cheers
Comment 10 Ben Klaas 2010-09-20 08:06:40 UTC
hello all-- just back from 4 days of holiday. I broke this and is my bug to fix-- Felix's patch looks like exactly the right direction. I hope to refine as needed, test, and check something in a.s.a.p.
Comment 11 Ben Klaas 2010-09-20 12:02:37 UTC
Created attachment 6985 [details]
updated patch to not push diags window on screen when tinySC is running

Felix, can you review this updated patch when you get a chance?

What this patch *doesn't* do, is anything useful when there is a network problem, tinySC is both present and running, and an item that does require the network is touched (e.g. My Apps, Internet Radio). In this situation, the menu item just has a small spinny to show a request has been made and it does nothing.

That's actually not a regression, but goes against what the new code is intending to accomplish, which is to push useful information and diagnostics options when network errors occur.

I'm inclined to check this in as is and tackle the fix for the issue listed above as a "nice to have".
Comment 12 Ben Klaas 2010-09-20 12:04:23 UTC
assigning to Felix for comment on patch and remaining issue described in last comment
Comment 13 Felix Mueller 2010-09-21 06:04:00 UTC
Ben - patch looks good to me.

I am wondering if we somehow could use SC UUID to distinguish between a local connection attempt (TinySC) and a remote connection attempt?
Comment 14 Ben Klaas 2010-09-21 06:33:00 UTC
We'd still want to push the diags window for situations where networkError was true and a remote player was trying to browse to something on a SBTouch tinySC (e.g. a Radio using a Touch's tinySC for local tracks), so I don't think using the SC UUID would work for deciding whether or not to ignore the networkError.

Thanks for the review, will check in the patch this morning.
Comment 15 SVN Bot 2010-09-21 06:43:48 UTC
 == Auto-comment from SVN commit #9125 to the jive repo by bklaas ==
 == http://svn.slimdevices.com/jive?view=revision&revision=9125 ==

Fixed Bug: 16552
Description: add hasTinySC to capabilities list in System.lua
add System object method hasTinySC()
do not push diags window in situations where networkError is true but player has tinySC and it is running
Comment 16 touchproblems 2010-09-24 12:33:39 UTC
Installed Patch onto touch, device now does not start squeezebox server it errors with "Local music service has been stopped due to a problem" I have tried factory reseting device and reloading updated patch and tried 2 hard drives and 1 SD card that were working before. I have wiped both the drives and tested again, still the same problem. Please help!
Comment 17 Ben Klaas 2010-09-24 13:42:42 UTC
thanks for the alert

r9129 should not have been pushed out because of a merge error. It was fixed a few revs after that yesterday but the build server had a hiccup, which I've also fixed. Next daily build, r9135 will resolve the problem.

FWIW, this is unrelated to the earlier bug and fix. It was a simple merge error that happened to hit a file that was important to tinySC and caused the failure.
Comment 18 touchproblems 2010-09-25 10:12:02 UTC
Great, thanks for the quick response, i thought it was going to take a while to fix. :-)
Comment 19 Paul Chandler 2011-05-02 09:06:28 UTC
Was able to play from the Touch with the local USB-drive as the server
and did not have the Ethernet plugged -in   or a wireless connection attached