Bug 16048 – self:string() localization method does not work when used in QVGA child skins

Bug 16048 - self:string() localization method does not work when used in QVGA child skins

Summary:

self:string() localization method does not work when used in QVGA child skins

Status:	RESOLVED FIXED

Product:	SqueezePlay
Classification:	Unclassified
Component:	UI Skin
Version:	7.5.x
Platform:	PC Other

Importance:	-- normal (vote)
Target Milestone:	7.5.1
Assigned To:	Ben Klaas

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-04-12 11:51 UTC by Ben Klaas
Modified:	2010-04-13 07:15 UTC (History)
CC List:	2 users (show)

See Also:
Category:	Bug

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ben Klaas 2010-04-12 11:51:34 UTC

need to find a way so the value for the text key in tables such as below in QVGAlandscapeSkin and QVGAportraitSkin is operational. I'm assuming that the method we are using for inheritance in these child skins inhibits the use of self:string()

       {
                                style = 'nowplaying',
                                artworkSize = '320x320',
                                --FIXME: self:string() does not work here
                                --text = self:string('LARGE_ART'),
                                text = 'Large artwork',
                         },


this bug is a side effect of the checkin for bug#15926

Comment 1 Michael Herger 2010-04-12 22:37:02 UTC

Here's my naive question: why should the base skin be inheriting from itself?

Index: src/squeezeplay/share/applets/QVGAbaseSkin/QVGAbaseSkinApplet.lua
===================================================================
--- src/squeezeplay/share/applets/QVGAbaseSkin/QVGAbaseSkinApplet.lua	(revision 8694)
+++ src/squeezeplay/share/applets/QVGAbaseSkin/QVGAbaseSkinApplet.lua	(working copy)
@@ -58,7 +58,7 @@
 
 
 module(..., Framework.constants)
-oo.class(_M, QVGAbaseSkinApplet)
+oo.class(_M, Applet)
 
 

This simple change seems to be fixing this issue in desktop SP.

Comment 2 SVN Bot 2010-04-13 07:15:40 UTC

 == Auto-comment from SVN commit #8697 to the jive repo by bklaas ==
 == http://svn.slimdevices.com/jive?view=revision&revision=8697 ==

Fixed Bug: 16048
Description: QVGAbaseSkin needed to be a class of applet, not itself.
Good catch Michael-- that's why I cc:ed you on the bug :)