Bugzilla – Bug 15926
which Now Playing "views" should be user configurable
Last modified: 2010-09-13 12:01:47 UTC
on Controller and Radio, Large Artwork and Small Artwork are two different Now Playing styles or "views". on Squeezebox Touch, there are more-- Artwork + Text, Artwork only, Text only, and two visualizers (if local player) different users want different sets of these views to be available. I propose we allow configuration of the set that's available to toggle through. Default for any given skin is all enabled. I have a patch already, and I will also write up some EVT tests for this feature before the bug is considered complete.
Created attachment 6670 [details] screenshot of np views user settings menu in Radio skin
Created attachment 6671 [details] screenshot of np views user settings menu in SB Touch skin
Created attachment 6672 [details] patch to allow user configurable settings for which now playing styles are used Devil's in the details here-- special accommodation had to be made for situations where the user is changing from a local to a non-local player (reasonably common) as well as between skins (currently only a situation on squeezeplay desktop) This has been thoroughly tested and works in all the corner cases attempted. There is one known FIXME, which is that self:string() localizations do not work in the param() method of the QVGA child skins...
Targeting for 7.5.1 at Ben's suggestion that all patch_waiting bugs be fixed
Has the case where all NP views are disabled been tested? Does it essentially become the same as setting the NP screensaver to 'none'?
It's not possible to disable every NP view. The UI will not allow you to uncheck every box. On the last one you get a "bump".
== Auto-comment from SVN commit #8688 to the jive repo by bklaas == == http://svn.slimdevices.com/jive?view=revision&revision=8688 == Fixed Bug: 15926 Description: add user configurable views for Now Playing screen to all skins this will be especially useful on Touch, where there are many NP views and not all will delight all customers There is a remaining issue where 'Large Artwork' and 'Small Artwork' are hard coded into the QVGA skins because of a bug where self:string() doesn't work for skins using the QVGA inheritance model. I'll open a separate bug for that.
Since these are fixed, they must not be patch_waiting after all