Bug 15965 - Replaygain tags are ignored on FLAC files with embedded cuesheet
: Replaygain tags are ignored on FLAC files with embedded cuesheet
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Tagging
: 7.4.2
: PC All
: P1 major with 2 votes (vote)
: 7.5.x
Assigned To: Andy Grundman
: patch_waiting
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-03-28 08:48 UTC by Arn0
Modified: 2011-01-14 14:04 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
patch Schema.pm to handle cuesheet RG values correctly (683 bytes, patch)
2010-04-01 14:39 UTC, Arn0
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arn0 2010-03-28 08:48:06 UTC
All replaygain informations are ignored on FLAC files with embedded cuesheet.
Replaygain info does not appear on web interface for each song contained in a FLAC file with embedded cuesheet. So the player doesn't apply replaygain settings when playing.

Replaygain is fine with single FLAC files (no cuesheet)

Please note this bug is not present in Squeezecenter 7.3.2
Comment 1 mr-b 2010-03-31 13:42:49 UTC
It seems to be a bug where the scanner doesn't like a space before the "dB" in either the .cue file or the CUESHEET tag (in the case of the embedded flac file).
Foobar2k writes them with a space.

scanner.log says:
[10-03-30 15:45:50.1722] Slim::Schema::_preCheckAttributes (2066) Invalid ReplayGain tag found in blah.flac: REPLAYGAIN_TRACK_GAIN -> -4.81 

Change the tag as below and then the scanner picks up the RG tag:

REM REPLAYGAIN_TRACK_GAIN -4.81 dB --> REM REPLAYGAIN_TRACK_GAIN -4.81dB

More on this at http://forums.slimdevices.com/showthread.php?t=76660
Comment 2 Arn0 2010-04-01 14:38:20 UTC
You got it !

Actually scanner is confused by this space between the replaygain value and the word "dB"

This behavior was introduced in 7.4.2 with the fix for Bug 15483.

First the scanner munge the replaygain values contained in the cuesheet but the space before "dB" remains. Then it checks to see if the value is valid but it got confused by the trailing space.

A quick fix is to remove any spaces in the replaygain value.
I attached a small patch for the file Schema.pm.
It now works for me
Comment 3 Arn0 2010-04-01 14:39:19 UTC
Created attachment 6735 [details]
patch Schema.pm to handle cuesheet RG values correctly
Comment 4 SVN Bot 2011-01-14 14:04:15 UTC
 == Auto-comment from SVN commit #31756 to the slim repo by agrundman ==
 == http://svn.slimdevices.com/slim?view=revision&revision=31756 ==

Fixed bug 15965, patch to strip out additional spaces in replaygain strings