Bug 15483 - Scanner falls over when ReplayGain tag are invalid
: Scanner falls over when ReplayGain tag are invalid
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Scanner
: 7.4.1
: PC Windows (legacy)
: P1 normal (vote)
: 7.4.2
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-01-17 01:39 UTC by Barry Caruth
Modified: 2011-03-16 04:45 UTC (History)
1 user (show)

See Also:
Category: Bug


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Barry Caruth 2010-01-17 01:39:35 UTC
Bug logged as requested by andyg - http://forums.slimdevices.com/showpost.php?p=507304&postcount=61.

Scanner falls over when it encounters an invalid replaygaintag:

[10-01-16 15:40:53.5801] Slim::Plugin::iTunes::Importer::handleTrack (379) Got a track named Halo location: file:///C:/Users/x/Music/iTunes/iTunes%20Media/Music/Compilations/Now%20That%27s%20What%20I%20Call%20Music%2073/45%20Halo.mp3
[10-01-16 15:40:53.6344] Slim::Schema::Storage::throw_exception (82) Error: DBI Exception: DBD::mysql::st execute failed: Data truncated for column 'replay_peak' at row 1 [for Statement "INSERT INTO tracks (tagversion,bitrate,audio_offset,drm,audio_size,bl ock_alignment,replay_peak,extid,remote,titlesort,a udio,cover,timestamp,replay_gain,url,lossless,chan nels,samplerate,secs,filesize,content_type,tracknu m,titlesearch,title,disc,year) VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,? ,?)"]
[10-01-16 15:40:53.6351] Slim::Schema::Storage::throw_exception (82) Backtrace:

The file in question had these tags:

ALBUM: Now That's What I Call Music 73
ARTIST: Beyonce 
COMMENT: Adjusted by iVolume 01/04/2010 20:08:00
COMMENT ITUNENORM: 0000108C 0000108C 0000295E 0000295E 0002568C 000227A7 00000000 00000000 00005CE1 000231A1
COMMENT MUSICMATCH_PREFERENCE: DL
DISCNUMBER: 1/1
ENCODEDBY: hifi2007
GENRE: Pop
ITUNESCOMPILATION: 1
LANGUAGE: UK
MP3GAIN_ALBUM_MINMAX: 048,210
MP3GAIN_MINMAX: p3gain_
MP3GAIN_UNDO: p3gain_undo
REPLAYGAIN_ALBUM_GAIN: -7.080000 dB
REPLAYGAIN_ALBUM_PEAK: 1.069149
REPLAYGAIN_TRACK_GAIN: eplaygain_tr
REPLAYGAIN_TRACK_PEAK: eplaygai
TITLE: Halo
TRACK: 45/46
YEAR: 2009

Clearing the invalid replaygain tag (containing nonnumeric text) allowed the scan to complete.

andyg said:

"SBS should be more resilient and ignore corrupted non-numeric RG tags like in this case. Please file a bug."
Comment 1 SVN Bot 2010-02-04 11:12:29 UTC
 == Auto-comment from SVN commit #30014 to the slim repo by andy ==
 == https://svn.slimdevices.com/slim?view=revision&revision=30014 ==

Fixed bug 15483, scanner fails when invalid (non-numeric) ReplayGain tags are found
Comment 2 SVN Bot 2010-02-04 13:16:06 UTC
 == Auto-comment from SVN commit #30018 to the slim repo by adrian ==
 == https://svn.slimdevices.com/slim?view=revision&revision=30018 ==

Bug: 15483
Description: update regexp to allow replaygain tags starting with +
Comment 3 SVN Bot 2010-02-05 14:57:28 UTC
 == Auto-comment from SVN commit #30018 to the  repo by adrian ==
 == https://svn.slimdevices.com/?view=revision&revision=30018 ==

Bug: 15483
Description: update regexp to allow replaygain tags starting with +