Bug 15827 - present options after inserting first removable media
: present options after inserting first removable media
Status: RESOLVED FIXED
Product: SB Touch
Classification: Unclassified
Component: TinySC
: unspecified
: PC Other
: P1 normal (vote)
: 7.5.1
Assigned To: Ben Klaas
: CX
Depends on:
Blocks: 15916
  Show dependency treegraph
 
Reported: 2010-03-03 10:29 UTC by Ben Klaas
Modified: 2010-09-13 12:01 UTC (History)
5 users (show)

See Also:
Category: Bug


Attachments
Present manual options after attaching first removable media (5.56 KB, patch)
2010-03-05 14:38 UTC, Ben Klaas
Details | Diff
add "Start Slideshow" item (8.43 KB, patch)
2010-03-08 05:31 UTC, Michael Herger
Details | Diff
add "Browse for images" media menu item (6.53 KB, patch)
2010-04-30 00:41 UTC, Michael Herger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Klaas 2010-03-03 10:29:32 UTC
right now the first removable media attached starts tinySC automatically. this results in a full screen "spinny" that stays on the screen for 30+ seconds. This is a bad path for a user that e.g., inserts an SD card for image viewing.

Suggest instead that a user should be presented with options on this first device insertion, after the "Attaching <device>" spinny is dismissed.

Scan for music->
View images->
Software Update->
Skip this->

first choice would bring up the 30+ second spinny while starting up tinySC
second choice would push to the ImageViewer applet
third choice would only appear if firmware(s) were present at the root dir of the removable media
fourth choice would go to the home menu, where an eject icon would be present for the device

note: tinySC should start automatically and not present user options if a device is attached at boot time
Comment 1 Michael Herger 2010-03-03 13:12:04 UTC
Please note that we don't have a "Browse images" menu item yet when a memory card is plugged in. The ImageViewer currently is well hidden away in the settings. But I think there's a request to make it an App (bug 12499).

Please also note that there's currently no "browse my music collection" feature. Once you enter it, it will start a slideshow of max(all, 1000) items found on the medium.
Comment 2 Spies Steven 2010-03-04 09:23:14 UTC
Moving to 7.5.x
Comment 3 Ben Klaas 2010-03-05 14:38:12 UTC
Created attachment 6601 [details]
Present manual options after attaching first removable media

After inserting SD or USB card, this patch will instead of immediately starting tinySC, will present the user with a menu with the following options:

(help message on this window is warning about unsafe eject)

Start Squeezebox Server->
Software Update-> (only if fab4*.bin file at root of media)
Skip->
Eject Card->

If Start Squeezebox Server is selected, it will bring up the 30-second "spinny", followed by a menu with "Squeezebox Server Status" and "My Music"
Comment 4 Michael Herger 2010-03-05 22:33:50 UTC
Ben - was wondering about the image viewer. I think there actually is no easy way to start it right away, as it could be configured to be using http as a source or other. Did you try it? I'll probably give your patch a try and add IV if possible.
Comment 5 Ben Klaas 2010-03-06 04:29:50 UTC
I did not try to do anything with IV as you said that there wasn't a way to start it effectively.

Would require work on the IV side, but what perhaps should be done is to present a menu item that says "Scan for Images". The callback for this item would call a method in IV that would set the media card as the source, scan for images, and then display them. May require a "spinny" while the initial scan is happening?
Comment 6 Michael Herger 2010-03-08 05:31:12 UTC
Created attachment 6609 [details]
add "Start Slideshow" item

Ben - besides adding the slideshow menu item I also changed the patch so it does _always_ show the menu, not only if it's the media previously used for SBS. Instead the "start server" item is always shown, if SBS isn't running yet. If we don't do this, then it would eg. be confusing that plugging in a SD card while SBS was already running and using the USB disk wouldn't bring up any option at all.

Other than that I think we'd need to add the "start slideshow" item to the home menu (or some other more intuitive place than Settings/ImageViewer) too.
Comment 7 Michael Herger 2010-03-08 09:03:42 UTC
I came to the conclusion that we should not only have the "remove..." item in the main menu, but rather make this a menu of its own, offering the same set of options as that menu you've been working on

- start/stop server
- start slideshow
- eject media

because if the user decides to start SBS, there will be no obvious way to star the slideshow too and vice versa
Comment 8 SVN Bot 2010-04-14 14:47:01 UTC
 == Auto-comment from SVN commit #8701 to the jive repo by bklaas ==
 == http://svn.slimdevices.com/jive?view=revision&revision=8701 ==

Bug: 15827
Description: first pass at MediaManager applet. Note that this applet as checked in is not live because all relevant enabling code in the meta file is commented out.
Getting it into subversion so we can collaborate on it further...
Comment 9 SVN Bot 2010-04-19 13:39:29 UTC
 == Auto-comment from SVN commit #8717 to the jive repo by bklaas ==
 == http://svn.slimdevices.com/jive?view=revision&revision=8717 ==

Bug: 15827
Description: First live checkin of new Media Manager framework
handling of media management now handled by a separate applet than SqueezeCenterApplet
service methods are defined in MediaManagerApplet that allow other applets to:
	1. add an item to the menu for an attached device
	2. register handlers for service methods to be run when a device is mounted
	3. register handlers for service methods to be run when a device is ejected
Behavior of Fab4 when a device is added is different than 7.5.0 now-- a menu of choices is presented to the user when a device is mounted rather than automatically starting up SqueezeCenter
There is more work to be done with this before 7.5.1 release, but this has been tested as initially okay for 7.5.1 nightly builds
Comment 10 Jim McAtee 2010-04-20 13:30:25 UTC
Is this intended to control only whether or not TinySC is started, or will it also allow the user to decide whether or not to scan the inserted media?

This is a comment just posted in the forums:

> My experience was 2 minutes to rescan a drive with 3400 files, 90 minutes 
> to rescan a drive with 38000 files. It's obviously not linear with the 
> number of files. While you can play music during the rescan, the UI is 
> pretty sluggish.

So someone intending to use TinysSC has to endure a 90 minute period of sluggish behavior whenever they turn on the Touch or attach a drive with a large library.  Could they not also be given the option of skipping the startup scan?  They should know whether or not any library changes have taken place.
Comment 11 SVN Bot 2010-04-21 11:17:36 UTC
 == Auto-comment from SVN commit #8719 to the jive repo by bklaas ==
 == http://svn.slimdevices.com/jive?view=revision&revision=8719 ==

Bug: 15827
Description: patches from Michael
1. do not present SBS as a menu option when drive is read-only (this will likely be reworked to better message the user, but this is a start)
2. only add menu items for mounts that end in numbers (i.e., partitions)
Comment 12 Michael Herger 2010-04-30 00:41:13 UTC
Created attachment 6812 [details]
add "Browse for images" media menu item
Comment 13 Ben Klaas 2010-04-30 05:36:40 UTC
Michael- if you're feeling good about the patch, go ahead and check it in.
Comment 14 SVN Bot 2010-04-30 06:28:48 UTC
 == Auto-comment from SVN commit #8755 to the jive repo by mherger ==
 == http://svn.slimdevices.com/jive?view=revision&revision=8755 ==

Bug: 15827
Bug: 15734
Description: add "Browse folder for images" item to media menu and ImageViewer. Allow setting a folder as the source for the ImageViewer screensaver using a contexte menu on folders and files.
Comment 15 SVN Bot 2010-04-30 08:55:35 UTC
 == Auto-comment from SVN commit #8757 to the jive repo by bklaas ==
 == http://svn.slimdevices.com/jive?view=revision&revision=8757 ==

Bug: 15827
Description:
Sort media manager menu by weight, then alpha
Push eject item to bottom of media manager menu

Add support in mmOnEjectHanlders for ejectWarningText and ejectWarningText conditionals
allows for appended text on the eject confirmation window, e.g. things like "This drive is running SBS. Ejecting will stop playback"

Remove subtext line again from Starting Squeezebox Server spinny popup, because of bug 16157
Fix improperly dereferenced table in _scDrive() method

Add EN string for SBS drive eject warning
Comment 16 SVN Bot 2010-05-10 12:19:08 UTC
 == Auto-comment from SVN commit #8766 to the jive repo by bklaas ==
 == http://svn.slimdevices.com/jive?view=revision&revision=8766 ==

Bug: 15827
Description: add Software Update menu item on media that contain firmware files at top level of directory
Comment 17 Ben Klaas 2010-05-10 12:41:08 UTC
Bug 16208 I believe now encapsulates what is left to do related to this bug.
Comment 18 Chris Owens 2010-09-13 12:01:47 UTC
Since these are fixed, they must not be patch_waiting after all