Bugzilla – Bug 16208
make switching server via media management menus more efficient
Last modified: 2019-01-25 10:10:46 UTC
If you select the MM menu item "Squeezebox Server" for a device that is not currently running tinySC while tinySC is running, you are prompted as to whether you'd like to switch the server to this device. In 7.5.1 code as of May 10th, this causes the following to happen: 1. /etc/squeezecenter/prefs.json is written to by SP with the change 2. server is restarted (prompting a full screen spinny, delay as scan.json file is created, file rescan, etc.) This bug states that the process should be quicker. By simply changing the prefs.json file, the server (through inotify) should recognize this has been changed and it should trigger a rescan without restarting the server.
Created attachment 6828 [details] server-side patch to correctly watch for prefs.json file change
Created attachment 6829 [details] client-side patch to not restart server after server switch this patch assumes that the server will handle the business of detecting prefs.json has changed.
On the two patches attached above this comment-- they work in that tinySC picks up the change to prefs.json and that triggers the correct server-side pref change (which results in the server doing the necessary rescan for the media change). It does not work, however, in user experience. After changing e.g. from SD card to USB as the tinySC dir, navigating to the My Music directory immediately results in poor behavior. Eventually things get sorted out correctly, but for a while the My Music menu still lists "Squeezebox Touch (SD card)" in the title bar after switching to USB. The submenus when in this state are inoperable. I don't know what event gets things to the "everything's sorted out correctly" stage, but probably related to file scanning and the creation of a scan.json file. IMO, for this bug to be fixed we need to ensure that the user doesn't get a confusing experience going into My Music immediately after a media switch. Either don't allow them into My Music, or fix it so My Music is not broken during this process.
While I didn't see the oddities in the My Music menu, the lack of any feedback selecting the switch menu item (it only bumped) is something else we need to improve.
Nice to have in 7.5.1 - but we'll better design it for later release.
Ben - do you think this is something we need to do?
not important enough for 7.6.0
TinySC will not be updated any more.