Bug 15826 - Need volume up / down events to be sent to SC even if at min or max
: Need volume up / down events to be sent to SC even if at min or max
Status: RESOLVED FIXED
Product: SB Touch
Classification: Unclassified
Component: UI
: 7.5.0
: PC Other
: P5 normal with 13 votes (vote)
: 7.6.0
Assigned To: Felix Mueller
:
Depends on:
Blocks: 12997 14807
  Show dependency treegraph
 
Reported: 2010-03-03 10:07 UTC by Felix Mueller
Modified: 2011-05-19 10:15 UTC (History)
10 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Mueller 2010-03-03 10:07:54 UTC
a) Server side plugins like IR Blaster need to be able to get volume up / down events sent to SC even if the volume is already at maximum or minimum. Right now that works from the WebUI and when using an IR remote but not when using the volume down / up buttons on the touch screen.

There are two places where a check "new value == old value" then do nothing prevents events sent to SC.

- NowPlaying.lua - _setPlayerVolume()
- Slider.lua - _moveSlider()

b) IR Blaster also needs to be able to set the local player volume to a fixed value, i.e. Touch UI or IR remote volume changes should not change the local volume but only send events to SC so plugins can work with it.
Comment 1 Chris Owens 2010-03-04 18:14:03 UTC
We should talk about the timeframe and assignee in the bug meeting
Comment 2 Chris Owens 2010-03-08 09:13:37 UTC
Felix notes he will work with Ben on this.
Comment 3 Felix Mueller 2010-07-18 01:43:07 UTC
*** Bug 16084 has been marked as a duplicate of this bug. ***
Comment 4 Jim McAtee 2010-09-12 19:10:11 UTC
Possibly related to the unfinished parts of bug 14807.
Comment 5 SVN Bot 2011-01-21 02:27:11 UTC
 == Auto-comment from SVN commit #9294 to the jive repo by fmueller ==
 == http://svn.slimdevices.com/jive?view=revision&revision=9294 ==

Bug: 15826 
Description: 
- Add hasIRBlasterCapability() function
- Catch volume up/down button events on NP screen
- Catch volume up/down IR events
Comment 6 SVN Bot 2011-01-21 02:31:29 UTC
 == Auto-comment from SVN commit #9295 to the jive repo by fmueller ==
 == http://svn.slimdevices.com/jive?view=revision&revision=9295 ==

Bug: 15826 
Description: Disable IRBlaster capability for now
Comment 7 Mike 2011-01-21 07:32:01 UTC
Felix - now that this has been marked future, can you clarify the impact of the two changes you made?

In 7.5.3 today... 
1) when I use my SB Controller to increase the volume on my SB3 via IRBlaster, everything works as expected.  Even with the volume fixed at 100%, pressing volume up on the SB Controller will increase the volume on my Pre-Amp.
2) when I use the SB Touch (as a controller) to increase the volume on my SB3 via IRBlaster,the volume does not increase on my Pre-Amp (per this incident).

I don't have a spare system to test 7.6 right now, but wanted to make sure that #1 above will still work in 7.6 as that is the much more important use case for me than #2.  I am hoping the change you made will not prevent the SB Controller from continuing to control the volume correctly via the IRBlaster connected to an SB3.

Thanks.
Comment 8 Felix Mueller 2011-01-24 00:33:18 UTC
Hi Mike

No worries. The changes I applied intend to fix what you describe as scenario #2 where SB Touch is used as a controller.

What you describe in scenario #1 (SB Controller and SB3) is not changed and will continue to work as it has in 7.5.x.

Felix