Bugzilla – Bug 15717
Sleep at end of song feedback not shown using IR
Last modified: 2010-03-01 10:15:57 UTC
Now that sleep at end of song is fixed for internet radio( bug 15675 ) for other content sleep at end of song is not displayed when sleep is selected via the remote control sleep button. If you use browse through the menus the selection is there.
works fine for me, r30171 from 7.5/embedded.
oh.. I guess you probably mean the touch when using the remote. That, I did not test. Probably means a problem in lua-land as it may not call the sleepSettingsQuery when a remote button is pressed.
seems to work as far as I can tell with squeezeplay filling in for touch (using keyboard shortcuts for remote input). The problem I see is that there is no popup feedback. Observing the web UI (fishbone skin, since it shows sleep time) I can see that the first selection is "end of song". Can you provide more details as to what you are testing, and is what I'm experiencing matching what you are seeing with the real hardware in any way?
I just tried it again the touch is on fw 8504 radio 8445. Using the remote's sleep button I get no sleep at end of song popup while playing local content or pandora. The option is there under the menus. I did notice that I press the button once with no result and the second press gives the 15 min popup.
could you try again, but this time check the fishbone skin web ui for sleep time? My guess is that the first press where you see no results is giving you the end of song setting, just no popup. I only have accesss to hardware in the evenings, and unfortunately too many things are different with the desktop builds
Yes it shows the sleep at end of song with the squeezeserver skin so maybe the popup is to short to be seen by mere mortals.
Some popup events can be blocked from showing. It could be that the logic is a bit off for this case (perhaps looking for numeric values). I don't know where that section of code comes from, so I won't promise anything. At least it's narrowed down a bit. Rewording summary to suit. Feel free to change if you feel there is a better way to write it.
I noticed yesterday that on older fw7915 on Radio in addition to the winking eye with number of minutes 15,30,60,90 there is a second pop-up that is first behind but persists longer that has text descriping "sleeping in ## minutes" or "sleeping at end of song", or "sleep cacelled". This second pop-up is no longer happening.
The "second" popup was disabled in change 29965. reverting that brings up the text popup and shows "end of song" where appropriate. Desktop jive seems to not have access to the icon-based popup that is supposed to be there without the redundant text popup. Using the baby skin, I can see the winking eye in the status bar across the bottom, but no minutes. My current workaround involves commenting out line 1154 (Jive => undef,) in Slim::Buttons::Common I can see that there is no asset for the 'eye'con needed to show sleep at end of song. cc'ing Ben for assistance.
mine to fix
== Auto-comment from SVN commit #30190 to the repo by bklaas == == https://svn.slimdevices.com/?view=revision&revision=30190 == Fixed Bug: 15717 Description: have Slim::Control::Commands render all sleep showBrieflies to Jive, including SLEEPING_AT_END_OF_SONG this covers both the IR sleep case (uses Slim::Buttons::Common) and the menu choice (uses Slim::Control::Jive)
FW 8601 the current behavior is fine