Bug 15675 - sleep at end of song not applicable for internet radio
: sleep at end of song not applicable for internet radio
Status: VERIFIED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Sleep
: unspecified
: PC Windows XP
: -- normal (vote)
: ---
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-02-10 09:03 UTC by Ryan
Modified: 2010-02-16 09:32 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
patch to clock 'end of song' option on squeezeplay if it's a radio stream (530 bytes, patch)
2010-02-10 14:58 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan 2010-02-10 09:03:28 UTC
Playing internet radio select sleep at end of song mut there is no end to the stream so sleep never happens.
Comment 1 KDF 2010-02-10 14:20:37 UTC
which UI is having the issue? I believe the remote for ip3k players and web ui are doing the right thing and skipping the "end of song" issue.  If it is just Squeezeplay-based devices, it's a bit more of a stretch but I'm willing to take a crack at it.
Comment 2 KDF 2010-02-10 14:58:09 UTC
Created attachment 6506 [details]
patch to clock 'end of song' option on squeezeplay if it's a radio stream

remote/webUI essentially drop the 'end of song' as an option of the $client->controller()->playingSongDuration() is coming back as 0.  So, in the case of squeezeplay, we can also drop the option if there is no known, and non-zero, $client->controller()->playingSongDuration().
Comment 3 KDF 2010-02-10 14:58:46 UTC
adding ben in case he wants to review or commit it.
Comment 4 SVN Bot 2010-02-10 15:11:43 UTC
 == Auto-comment from SVN commit #30130 to the  repo by bklaas ==
 == https://svn.slimdevices.com/?view=revision&revision=30130 ==

Fixed Bug: 15675
Description: applied patch from KDF (thanks) to not display Sleep at end of song for tracks without duration.
Comment 5 Ryan 2010-02-16 09:32:36 UTC
verified with touch fw8504 and radio fw8445