Bugzilla – Bug 15328
CLI artists query should respect Accept-Language header for the Various Artists item when called via Comet
Last modified: 2010-04-08 17:24:07 UTC
As there is now a bug for this... This also affects the "Various Artists" item in the artists list, that one also is shown as set in the server settings instead of in the "Accept-Language" language.
Yeah, really any CLI call that calls string() should respect Accept-Language. This may be tricky for some cases, as right now the language override value is stored in $client.
Created attachment 6397 [details] add language override to requests Jörg - could you please test this? Client language has priorty over override.
"getstring" looks good with the patch. "Vaious Artists" is still "Various Artists", though, instead of "Diverse Interpreten" (or "Diverse Artisten" how the scanner would call it :) )
== Auto-comment from SVN commit #29668 to the slim repo by michael == == https://svn.slimdevices.com/slim?view=revision&revision=29668 == Bug: 15328 Description: respect "Accept-Language" headers from JSON/RPC requests to override server language settings when no client is available.
Created attachment 6400 [details] localize VA object in artists query Jörg - would I need a more recent iPeng to test this? My 1.2.1 is EN only?
Yes. I'll send you one later today. 1.2.1 uses the language setting of the server but that won't work with localization since iPhone automatically sets it's default language so future iPeng versions will use the client language.
== Auto-comment from SVN commit #7825 to the network repo by michael == == https://svn.slimdevices.com/network?view=revision&revision=7825 == Bug: 15328 Description: roll out workaround for dropped UUID in json issue
Oops... wrong bug. Ignore please.
== Auto-comment from SVN commit #29676 to the slim repo by michael == == https://svn.slimdevices.com/slim?view=revision&revision=29676 == Fixed Bug: 15328 Description: localize "Various Artists" item in artists query when language override is requested by the controlling client
I'm not 100% sure whether this is another "ignoring" of AcceptLanguage or https://bugs-archive.lyrion.org/show_bug.cgi?id=15333 But the "tooltips" for Love/Ban icons (the ones for the Repeat/Shuffle button replacements on the NowPlaying screens, not the context menus) are not localized, at least for Last.fm and Slacker. Slacker might not need to be localized since it's only available for the US, but Last.fm would be nice. I use the tooltips for the accessibility (screen reader) support in iPeng and VoiceOver really reads stuff badly if it's in the wrong language.
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release. If you are still seeing this issue, please let us know!