Bugzilla – Bug 15008
Redundant "Save to Favorites" song action
Last modified: 2010-03-31 12:51:33 UTC
I notice that in WebUI Song Info page, there's an icon to save the song as a favorite, but there is also an option in the song info items list to "Save to Favorites", which is duplicating the function of the icon. When clicking "Save to Favorites" it changes the Song Info section to report "Saving Favorites...", and leaves this message up. Whereas clicking the Favorite icon changes the icon to a Favorite icon with a "-" in it, to indicate that there is a favorite that can be deleted. I suggest the "Save to Favorites" item is not needed in the Web UI (only for player UI).
I would be inclined to disagree, that there is a use case for people using the webUI as their main system UI and/or they might want to mark a track as a favorite using the WebUI's richer interface. But I won't yet mark it as 'wontfix'
(In reply to comment #1) > I would be inclined to disagree, that there is a use case for people using the > webUI as their main system UI and/or they might want to mark a track as a > favorite using the WebUI's richer interface. > I think you have misunderstood/not read the bug report properly. I am saying that in the WebUI Song Info page, there are TWO ways to save a song as a favorite: a) click the "heart" icon, which has a tooltip "Save". b) click the "Save to Favorites" action, which is in the list of song info/actions. I am saying that in the WebUI, (b) isn't necessary, as (a) is better (icon changes to a heart with a "-" in it to indicate that the song has been stored as a favorite, and this icon would now remote the favorite). The "Save to Favorites" textual action is only needed in the context menu on Player UI's (eg SB3, because it won't display the heart icon).
Thanks for the clarification, Philip!
Is this a dupe of 13953?
This bug is reporting that there are two ways to save a favorite, and suggesting that "Save to Favorites" is redundant in WebUI. Whereas bug 13953 is about the presentation and what happens when the "Save" link is clicked. Nb. I think "Save" meant the textual action that appears in the Song Info items list - this must have changed, because it now says "Save to Favorites". If it is agreed that "Save to Favorites" is not required in WebUI, the change should be easy to just remove it, therefore you could close bug 13953. If there's some reason why "Save to Favorites" AND the heart button icon are both needed, then this bug can be closed, and bug 13953 should be looked.