Bug 14927 - Radio missing in "Choose Player" drop down on SBS
: Radio missing in "Choose Player" drop down on SBS
Status: CLOSED FIXED
Product: SB Radio
Classification: Unclassified
Component: SB Server
: Include FW version in comment
: PC Windows XP
: P1 normal with 1 vote (vote)
: 7.5.0
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-10-24 20:09 UTC by George Hines
Modified: 2010-04-08 17:24 UTC (History)
7 users (show)

See Also:
Category: Bug


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description George Hines 2009-10-24 20:09:46 UTC
Detail:

http://forums.slimdevices.com/showthread.php?t=70307
Comment 1 Jim McAtee 2009-10-24 21:51:51 UTC
Also see bug 12207, which addressed the same problem, but was never fully fixed.  I guess the support is now there in the player to do this, but the web interface end was never completed.
Comment 2 Michael Herger 2009-10-26 03:44:59 UTC
George - don't you see it even when browsing your local music on the Radio?
Comment 3 James Richardson 2009-10-26 06:09:28 UTC
QA has seen something like this in 7.4.1.  When the SP device is attached to MySB, the last locally attached SBS does not show the SP device in the player drop down box.  IP3K devices do properly show up.

Steps to repo:
1 Attach a SP device to local SBS 7.4.1
2 Move SP device to MySB, move IP3K device to MySB
3 In local SBS, click on Player Dropdown, notice the IP3K device is listed as being attached to MySB while the SP device is missing
Comment 4 George Hines 2009-10-26 07:40:37 UTC
(In reply to comment #2)
> George - don't you see it even when browsing your local music on the Radio?

To be clear: I can't see my Radios in SBS's Choose player drop down when the
radios are connected to mysqueezebox.com.  When I switch the Radios back to SBS, they show up again.

Thanks,

George
Comment 5 Michael Herger 2009-11-25 09:15:26 UTC
I'm sorry, not critical enough to hold off the Touch release.
Comment 6 Michael Herger 2009-11-26 05:34:02 UTC
Andy - investigating this issue I've found that we're filtering out all devices with deviceid 9. This means all SP based players like Radio/Touch. I'd suggest changing the query as follows:

Index: lib/SDI/Service/Model/Player.pm
===================================================================
--- lib/SDI/Service/Model/Player.pm	(revision 7736)
+++ lib/SDI/Service/Model/Player.pm	(working copy)
@@ -73,7 +73,7 @@
 		FROM   __TABLE__
 		WHERE  userid = ?
 		AND    connected IS NOT NULL
-		AND    deviceid != 9
+		AND    (deviceid != 9 OR model != 'controller')
 	} );
 	
Thoughts?
Comment 7 SVN Bot 2009-11-30 06:28:10 UTC
 == Auto-comment from SVN commit #7742 to the network repo by michael ==
 == https://svn.slimdevices.com/network?view=revision&revision=7742 ==

Fixed Bug: 14927
Description: only exclude Controller, but not Touch/Radio. Need to change filter criteria to only ignore if deviceid == 9 && controller
Comment 8 Chris Owens 2010-04-08 17:24:52 UTC
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release.

If you are still seeing this issue, please let us know!