Bug 12207 - SP player needs UDAP support so remote contollers can switch a disconnected SP player to a new server
: SP player needs UDAP support so remote contollers can switch a disconnected S...
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: Networking
: unspecified
: PC Windows XP
: P1 normal (vote)
: 7.4.0
Assigned To: Felix Mueller
:
Depends on:
Blocks: 10403 13336
  Show dependency treegraph
 
Reported: 2009-05-29 15:25 UTC by Jim McAtee
Modified: 2009-10-05 14:36 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim McAtee 2009-05-29 15:25:48 UTC
This is the only player on my network (apart from software players) that I cannot pull from one server to another using the web interface.  Following the confirmation dialog box, the music stream stops, but the player remains connected to the original server.
Comment 1 Richard Titmuss 2009-07-22 07:45:27 UTC
Can you confirm if this is now fixed
Comment 2 Felix Mueller 2009-07-23 07:41:49 UTC
How is that actually done / implemented?

Didn't you implement that, Michael?
Comment 3 Michael Herger 2009-07-23 08:03:08 UTC
I've done the UI, but not the background work. SC should be sending the player some slimproto command to tell it to switch over. I wonder whether this is broken due to the "autoswitch" changes. Tom might know better than I do.
Comment 4 Richard Titmuss 2009-07-23 08:28:06 UTC
*** Bug 11850 has been marked as a duplicate of this bug. ***
Comment 5 Felix Mueller 2009-07-29 13:53:45 UTC
Well, we are talking two things here.

- Pulling a player from one SC to another SC (this should work with slimproto)
- Pulling a player (not connected) to a SC (this needs UDAP)
Comment 6 Wadzinski Tom 2009-08-03 18:47:11 UTC
Pat, FYI, a consequence of pushing this out of the 7.4 release (moving to P2), is that for Jive, (or Baby as a controller) autoswitching will remain broken while controlling a SP based player (Baby, Fab4, Jive). See dependent bug 10403

Specifically, the SP UDAP code (Richard, can you confirm?) is not yet coded on the player side when the player's server connection is lost. Without this there is not a way for a controller to switch a server-less remote player to SN (or back).
Comment 7 Felix Mueller 2009-08-03 21:33:04 UTC
I would agree with Tom. We should include that into 7.4. I already was working on that feature (UDAP for squeezeplay based players) but got sidetracked by fixing MP relevant bugs. I am confident to finish within my original estimate.
Comment 8 Jim McAtee 2009-08-23 12:45:16 UTC
"Pulling a player from one SC to another SC" appears to be working now with both Fab4 and Baby.  Can someone else confirm this?
Comment 9 Ben Klaas 2009-08-26 07:52:44 UTC
this is an administrative shuffle on priority fields to help make better judgment on the top end of the priority list. P4->P5, P3->P4, and P2->P3.
Comment 10 Pat Ransil 2009-08-28 12:27:31 UTC
Tom/Felix - Is this is an issue for any controller moving any player? Jim's initial comments say Fab4 is his only device where this does not work.
Comment 11 Jim McAtee 2009-08-28 13:22:31 UTC
(In reply to comment #10)
> Tom/Felix - Is this is an issue for any controller moving any player? Jim's
> initial comments say Fab4 is his only device where this does not work.

I think this was filed prior to my having Baby.  I believe it's also true for Baby.

Fixed: Can pull a device from another SB server.

Needed: Being able to take over control of a device connected to SqueezeNetwork.
Comment 12 Felix Mueller 2009-08-28 23:23:53 UTC
It's an issue for squeezeplay based players only.
Comment 13 Wadzinski Tom 2009-09-09 07:36:09 UTC
is really a P1 talking to Richard. Richard has offered to take it as well, 
Felix.
Comment 14 Felix Mueller 2009-09-09 08:05:10 UTC
Thanks for the offer, Richard. I'll see what I can do and let you know if I need help.
Comment 15 SVN Bot 2009-09-14 14:45:18 UTC
 == Auto-comment from SVN commit #7562 to the jive repo by felix ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7562 ==

Bug: 12207 +4 
Description: Work in progress 
- Separate function to allow being used via 'serv' slimproto command and UDAP
Comment 16 Felix Mueller 2009-09-15 09:38:21 UTC
Updating hours worked.
Comment 17 Felix Mueller 2009-09-17 09:49:14 UTC
Updating hours worked.
Comment 18 SVN Bot 2009-09-18 04:13:18 UTC
 == Auto-comment from SVN commit #7653 to the jive repo by felix ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7653 ==

Bug: 12207 +8 
Description:  
- Add functions to Udap.lua to parse udap requests and generate udap responses.
- Add UdapControl.lua to handle received udap requests (discover, advanced discover, set server address and get uuid) and send answers.
- Added function to LocalPlayer.lua to allow connection to server via ip. 

- A player only responds to udap requests if it is local and not connected to a server, i.e. status is 'wait_slimserver'.
Comment 19 Felix Mueller 2009-09-18 06:40:53 UTC
Udap commands verified on Fab4 and Baby. Also tested it's not affecting Jive when setting up a Ray.

Implemented in r7653
Comment 20 Felix Mueller 2009-09-18 10:00:32 UTC
We also need to support slimserver_address
Comment 21 SVN Bot 2009-09-19 04:57:50 UTC
 == Auto-comment from SVN commit #7663 to the jive repo by felix ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7663 ==

Bug: 12207 +2 
Description: Added set slimserver address method
Comment 22 Felix Mueller 2009-09-19 04:58:49 UTC
Ok Tom, please try again.
Comment 23 James Richardson 2009-10-05 14:36:14 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.