Bugzilla – Bug 14474
Music Folder browsing ignores non-alphanumeric characters in it's sorting algorithm
Last modified: 2010-04-08 17:25:28 UTC
The sorting algorithm when browsing the music folder ignores non-alphanumeric characters. This makes it very difficult for one to manually manage it via the file system on the server... I have folders in my music folder named: __FLAC __<Artist Name starting with Letter A> __<Artist Name starting with Letter Z> <Artist Name starting with Letter M> <Artist Name starting with Letter O> __MP3 __<Artist Name starting with Letter A> __<Artist Name starting with Letter B> __<Artist Name starting with Letter F> <Artist Name starting with Letter C> <Artist Name starting with Letter G> __VIDEO Random Album #1 Random Album #2 That's the sort order I'd expect to see them in on both my players and the web interface, but it's not... What I end up with is: __FLAC __<Artist Name starting with Letter A> <Artist Name starting with Letter M> <Artist Name starting with Letter O> __<Artist Name starting with Letter Z> __MP3 __<Artist Name starting with Letter A> __<Artist Name starting with Letter B> <Artist Name starting with Letter C> __<Artist Name starting with Letter F> <Artist Name starting with Letter G> Random Album #1 Random Album #2 __VIDEO Wouldn't it make more sense to match the file systems sorting order since when we use "Browse Music Folder" we're ignoring all ID3 tags and just looking at the files as if they were on the computer? This is a big deal for me because not all of my music is tagged properly, if it was I'd be using the Artist/Album/Song browsing on my players.
*** This bug has been marked as a duplicate of bug 14503 ***
Not a dupe... different issue.
Michael: is this one yours or Andy's to look at? please re-target if needed.
We should review this. The sorting function is only used for BMF. Thus it should be relatively safe to change the behaviour. Obviously this sorting has caused some discussion before. From the code: # File sorting should look like ls -l, Windows Explorer, or Finder - # really, we shouldn't be doing any of this, but we'll ignore # punctuation, and fold the case. DON'T strip articles. I'll second this.
(In reply to comment #4) > # File sorting should look like ls -l, Windows Explorer, or Finder - > # really, we shouldn't be doing any of this, but we'll ignore > # punctuation, and fold the case. DON'T strip articles. > It also shouldn't fold the case. On case-sensitive OS's you want two folders with the same spelling but differing case to be distinct. It essentially looks like the folders have merged if you fold the case. On OSs that are case-sensitive it won't matter, since you can't have two directories or filenames with the same spelling and different case. When you do the readDirectory() for BMF, doesn't every OS offer a sorting facility so that you don't have to do it yourself in SbS?
== Auto-comment from SVN commit #28943 to the slim repo by michael == == https://svn.slimdevices.com/slim?view=revision&revision=28943 == Fixed Bug: 14474 +1 Description: don't strip out non alphanumerical characters before sorting directory content. Sort by lower case value to make a few more characters show up before the actual list.
== Auto-comment from SVN commit #28944 to the slim repo by michael == == https://svn.slimdevices.com/slim?view=revision&revision=28944 == Bug: 14474 Description: don't use ignorePunct to display the indes character in SP
Safe change. Should be made to 7.4.1.
Wait a minute... What's the reason for continuing to fold the case? Changing uc() to lc() just gives you a different sort order.
This bug has been marked fixed in a released version of Squeezebox Server or the accompanying firmware or mysqueezebox.com release. If you are still seeing this issue, please let us know!